X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fcontroller%2FAlignViewController.java;h=1fc194651420304580924613f7fd21dc3386c389;hb=038cb9c86641c3de91d8f330c5e3267507c46643;hp=a5a35910c1b5d9ac7139d4c228d2cb5354a87835;hpb=6c2b68627777b6731f3e1081fb7437b9678c9670;p=jalview.git

diff --git a/src/jalview/controller/AlignViewController.java b/src/jalview/controller/AlignViewController.java
index a5a3591..1fc1946 100644
--- a/src/jalview/controller/AlignViewController.java
+++ b/src/jalview/controller/AlignViewController.java
@@ -90,7 +90,8 @@ public class AlignViewController implements AlignViewControllerI
         gps = jalview.analysis.Grouping.makeGroupsFromCols(
                 (sg == null) ? viewport.getAlignment().getSequencesArray()
                         : sg.getSequences().toArray(new SequenceI[0]),
-                cs, viewport.getAlignment().getGroups());
+                cs, viewport.getAlignment().getGroups(),
+                viewport.getAlignment().getHiddenColumns());
       }
     }
     if (gps != null)
@@ -107,8 +108,7 @@ public class AlignViewController implements AlignViewControllerI
         viewport.getAlignment().addGroup(gps[g]);
         if (colours != null)
         {
-          gps[g].setColourScheme(colours.getInstance(viewport, gps[g],
-                  viewport.getHiddenRepSequences()));
+          gps[g].setColourScheme(colours.getInstance(viewport, gps[g]));
         }
         Color col = new Color((int) (Math.random() * 255),
                 (int) (Math.random() * 255), (int) (Math.random() * 255));
@@ -167,9 +167,10 @@ public class AlignViewController implements AlignViewControllerI
     // JBPNote this routine could also mark rows, not just columns.
     // need a decent query structure to allow all types of feature searches
     BitSet bs = new BitSet();
-    SequenceCollectionI sqcol = (viewport.getSelectionGroup() == null
-            || extendCurrent) ? viewport.getAlignment()
-                    : viewport.getSelectionGroup();
+    boolean searchSelection = viewport.getSelectionGroup() != null
+            && !extendCurrent;
+    SequenceCollectionI sqcol = searchSelection ? viewport
+            .getSelectionGroup() : viewport.getAlignment();
 
     int nseq = findColumnsWithFeature(featureType, sqcol, bs);
 
@@ -205,9 +206,10 @@ public class AlignViewController implements AlignViewControllerI
     }
     else
     {
-      avcg.setStatus(MessageManager
-              .formatMessage("label.no_feature_of_type_found", new String[]
-              { featureType }));
+      String key = searchSelection ? "label.no_feature_found_selection"
+              : "label.no_feature_of_type_found";
+      avcg.setStatus(MessageManager.formatMessage(key,
+              new String[] { featureType }));
       if (!extendCurrent)
       {
         cs.clear();
@@ -309,16 +311,34 @@ public class AlignViewController implements AlignViewControllerI
   @Override
   public void sortAlignmentByFeatureDensity(List<String> typ)
   {
-    sortBy(typ, "Sort by Density", AlignmentSorter.FEATURE_DENSITY);
+    String methodText = MessageManager.getString("label.sort_by_density");
+    sortByFeatures(typ, methodText, AlignmentSorter.FEATURE_DENSITY);
   }
 
-  protected void sortBy(List<String> typ, String methodText,
+  /**
+   * Sorts the alignment (or current selection) by either average score or density
+   * of the specified feature types, and adds to the command history. If
+   * {@code types} is null, all visible feature types are used for the sort. If no
+   * feature types apply, does nothing.
+   * 
+   * @param types
+   * @param methodText
+   *                     - text shown in Undo/Redo command
+   * @param method
+   *                     - passed to
+   *                     jalview.analysis.AlignmentSorter.sortByFeatures()
+   */
+  protected void sortByFeatures(List<String> types, String methodText,
           final String method)
   {
     FeatureRenderer fr = alignPanel.getFeatureRenderer();
-    if (typ == null && fr != null)
+    if (types == null && fr != null)
+    {
+      types = fr.getDisplayedFeatureTypes();
+    }
+    if (types.isEmpty())
     {
-      typ = fr.getDisplayedFeatureTypes();
+      return; // nothing to do
     }
     List<String> gps = null;
     if (fr != null)
@@ -340,7 +360,7 @@ public class AlignViewController implements AlignViewControllerI
       stop = al.getWidth();
     }
     SequenceI[] oldOrder = al.getSequencesArray();
-    AlignmentSorter.sortByFeature(typ, gps, start, stop, al, method);
+    AlignmentSorter.sortByFeature(types, gps, start, stop, al, method);
     avcg.addHistoryItem(new OrderCommand(methodText, oldOrder,
             viewport.getAlignment()));
     alignPanel.paintAlignment(true, false);
@@ -350,7 +370,8 @@ public class AlignViewController implements AlignViewControllerI
   @Override
   public void sortAlignmentByFeatureScore(List<String> typ)
   {
-    sortBy(typ, "Sort by Feature Score", AlignmentSorter.FEATURE_SCORE);
+    String methodText = MessageManager.getString("label.sort_by_score");
+    sortByFeatures(typ, methodText, AlignmentSorter.FEATURE_SCORE);
   }
 
   @Override