X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fext%2Fensembl%2FEnsemblMap.java;fp=src%2Fjalview%2Fext%2Fensembl%2FEnsemblMap.java;h=97898190f0812a2c1d1b050fa9e6d4e1442fab0a;hb=a83adb45bdf9554e270921b4baad94defd314b36;hp=e9f1af16b93473b3eeb8835a64405d079c101f00;hpb=d4ec118f86b5c9dee801e743c46aaacc7bb521d1;p=jalview.git diff --git a/src/jalview/ext/ensembl/EnsemblMap.java b/src/jalview/ext/ensembl/EnsemblMap.java index e9f1af1..9789819 100644 --- a/src/jalview/ext/ensembl/EnsemblMap.java +++ b/src/jalview/ext/ensembl/EnsemblMap.java @@ -3,10 +3,8 @@ package jalview.ext.ensembl; import jalview.datamodel.AlignmentI; import jalview.datamodel.DBRefSource; import jalview.datamodel.GeneLociI; -import jalview.util.JSONUtils; import jalview.util.MapList; -import java.io.BufferedReader; import java.io.IOException; import java.net.MalformedURLException; import java.net.URL; @@ -18,18 +16,6 @@ import java.util.Map; import org.json.simple.parser.ParseException; -/** - * A client for the Ensembl REST service /map endpoint, to convert from - * coordinates of one genome assembly to another. - *

- * Note that species and assembly identifiers passed to this class must be valid - * in Ensembl. They are not case sensitive. - * - * @author gmcarstairs - * @see https://rest.ensembl.org/documentation/info/assembly_map - * @see https://rest.ensembl.org/info/assembly/human?content-type=text/xml - * @see https://rest.ensembl.org/info/species?content-type=text/xml - */ public class EnsemblMap extends EnsemblRestClient { private static final String MAPPED = "mapped"; @@ -166,7 +152,9 @@ public class EnsemblMap extends EnsemblRestClient { Iterator rvals = (Iterator) getJSON(url, null, -1, MODE_ITERATOR, MAPPINGS); if (rvals == null) - return null; + { + return null; + } while (rvals.hasNext()) { // todo check for "mapped" @@ -233,7 +221,7 @@ public class EnsemblMap extends EnsemblRestClient URL url = null; try { - String domain = new EnsemblInfo().getDomain(division); + String domain = EnsemblInfo.getDomain(division); if (domain != null) { url = getIdMapUrl(domain, accession, start, end, cdsOrCdna); @@ -298,7 +286,9 @@ GeneLociI parseIdMappingResponse(URL url, String accession, { Iterator rvals = (Iterator) getJSON(url, null, -1, MODE_ITERATOR, MAPPINGS); if (rvals == null) - return null; + { + return null; + } String assembly = null; String chromosome = null; int fromEnd = 0;