X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Furls%2FIdentifiersUrlProvider.java;fp=src%2Fjalview%2Furls%2FIdentifiersUrlProvider.java;h=f32e5908ea9599b16b4967a7d627e611aea8e9da;hb=97e2831b327bd80268a39cdd5a6d948d9fe4d185;hp=0988e7d2aa7eb5670ccdf8c145d351390a83929f;hpb=3b8d1bf01af2c83cf767064078852fa5aa8f3394;p=jalview.git diff --git a/src/jalview/urls/IdentifiersUrlProvider.java b/src/jalview/urls/IdentifiersUrlProvider.java index 0988e7d..f32e590 100644 --- a/src/jalview/urls/IdentifiersUrlProvider.java +++ b/src/jalview/urls/IdentifiersUrlProvider.java @@ -83,6 +83,7 @@ public class IdentifiersUrlProvider extends UrlProviderImpl // identifiers.org data HashMap idData = new HashMap(); + String errorMessage = null; try { FileReader reader = new FileReader(idFileName); @@ -116,19 +117,19 @@ public class IdentifiersUrlProvider extends UrlProviderImpl (String) item.get("prefix")); idData.put((String) item.get("id"), link); } - } catch (FileNotFoundException e) + } catch (IOException | ParseException e) { - e.printStackTrace(); - idData.clear(); - } catch (IOException e) - { - e.printStackTrace(); - idData.clear(); - } catch (ParseException e) - { - e.printStackTrace(); + // unnecessary e.printStackTrace(); + // Note how in JavaScript we can grab the first bytes from any file reader. + // Typical report here is "NetworkError" because the file does not exist. + // "https://." is coming from System.getProperty("user.home"), but this could + // be set by the page developer to anything, of course. + errorMessage = (/** @j2sNative String.fromCharCode.apply(null, reader.$in.is.buf.slice(0,12)) || */e.toString()); idData.clear(); } + // BH 2018 -- added more valuable report + if (errorMessage != null) + System.err.println("IdentifiersUrlProvider: cannot read " + idFileName + ": " + errorMessage); return idData; }