X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=test%2Fjalview%2Fbin%2FCommandLineOperations.java;fp=test%2Fjalview%2Fbin%2FCommandLineOperations.java;h=b9959dd69d864d5c018a3d38f007aa846e53f4f9;hb=c0501eaa85c0594f9275766f64de8ea44a59c368;hp=a5067bee5269d4ea18382b21523a7767199d417d;hpb=304e64fb34b32659be1bbfd39fb4e15b2f79586e;p=jalview.git diff --git a/test/jalview/bin/CommandLineOperations.java b/test/jalview/bin/CommandLineOperations.java index a5067be..b9959dd 100644 --- a/test/jalview/bin/CommandLineOperations.java +++ b/test/jalview/bin/CommandLineOperations.java @@ -61,12 +61,12 @@ public class CommandLineOperations JvOptionPane.setMockResponse(JvOptionPane.CANCEL_OPTION); } - private static final int TEST_TIMEOUT = 9000; // Note longer timeout needed - // on - // full test run than on - // individual tests + private static final int TEST_TIMEOUT = 13000; // Note longer timeout needed + // on + // full test run than on + // individual tests - private static final int SETUP_TIMEOUT = 9000; + private static final int SETUP_TIMEOUT = 9500; private static final int MINFILESIZE_SMALL = 2096; @@ -174,8 +174,8 @@ public class CommandLineOperations // not expanded by the shell String classpath = getClassPath(); String _cmd = java_exe + " " - + (withAwt ? "-Djava.awt.headless=true" : "") - + " -classpath " + classpath + + (withAwt ? "-Djava.awt.headless=true" : "") + " -classpath " + + classpath + (modules.length() > 2 ? "--add-modules=\"" + modules + "\"" : "") + " jalview.bin.Jalview "; @@ -233,7 +233,7 @@ public class CommandLineOperations public void setUpForHeadlessCommandLineInputOperations() throws IOException { - String cmds = "nodisplay -open examples/uniref50.fa -sortbytree -props test/jalview/io/testProps.jvprops -colour zappo " + String cmds = "nodisplay -open examples/uniref50.fa -sortbytree -props test/jalview/bin/testProps.jvprops -colour zappo " + "-jabaws http://www.compbio.dundee.ac.uk/jabaws -nosortbytree " + "-features examples/testdata/plantfdx.features -annotations examples/testdata/plantfdx.annotations -tree examples/testdata/uniref50_test_tree"; Worker worker = getJalviewDesktopRunner(true, cmds, SETUP_TIMEOUT); @@ -253,18 +253,53 @@ public class CommandLineOperations public void setUpForCommandLineInputOperations() throws IOException { String cmds = "-open examples/uniref50.fa -noquestionnaire -nousagestats"; - Worker worker = getJalviewDesktopRunner(false, cmds, SETUP_TIMEOUT); - String ln = null; - int count = 0; - while ((ln = worker.getErrorReader().readLine()) != null) + final Worker worker = getJalviewDesktopRunner(false, cmds, + SETUP_TIMEOUT); + + // number of lines expected on STDERR when Jalview starts up normally + // may need to adjust this if Jalview is excessively noisy ? + final int STDERR_SETUPLINES = 50; + + // thread monitors stderr - bails after SETUP_TIMEOUT or when + // STDERR_SETUPLINES have been read + Thread runner = new Thread(new Runnable() { - System.out.println(ln); - successfulCMDs.add(ln); - if (++count > 25) + @Override + public void run() + { + String ln = null; + int count = 0; + try + { + while ((ln = worker.getErrorReader().readLine()) != null) + { + System.out.println(ln); + successfulCMDs.add(ln); + if (++count > STDERR_SETUPLINES) + { + break; + } + } + } catch (Exception e) + { + System.err.println( + "Unexpected Exception reading stderr from the Jalview process"); + e.printStackTrace(); + } + } + }); + long t = System.currentTimeMillis() + SETUP_TIMEOUT; + runner.start(); + while (!runner.isInterrupted() && System.currentTimeMillis() < t) + { + try + { + Thread.sleep(500); + } catch (InterruptedException e) { - break; } } + runner.interrupt(); if (worker != null && worker.exit == null) { worker.interrupt(); @@ -336,7 +371,7 @@ public class CommandLineOperations // headless mode input operations { "CMD [-color zappo] executed successfully!", "Failed command : -color zappo" }, - { "CMD [-props test/jalview/io/testProps.jvprops] executed successfully!", + { "CMD [-props test/jalview/bin/testProps.jvprops] executed successfully!", "Failed command : -props File" }, { "CMD [-sortbytree] executed successfully!", "Failed command : -sortbytree" },