From 61b558f74356428be3b5543cd02b83ac051262ab Mon Sep 17 00:00:00 2001 From: kiramt Date: Mon, 15 Jan 2018 07:51:08 +0000 Subject: [PATCH] JAL-2759 Updates following review --- src/jalview/datamodel/BoundedHiddenColsIterator.java | 10 ++-------- src/jalview/datamodel/HiddenCursorPosition.java | 6 +++--- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/jalview/datamodel/BoundedHiddenColsIterator.java b/src/jalview/datamodel/BoundedHiddenColsIterator.java index aa3f4ad..8ec2a4d 100644 --- a/src/jalview/datamodel/BoundedHiddenColsIterator.java +++ b/src/jalview/datamodel/BoundedHiddenColsIterator.java @@ -11,12 +11,6 @@ import java.util.List; */ public class BoundedHiddenColsIterator implements Iterator { - // start position to iterate from - private int start; - - // end position to iterate to - private int end; - // current index in hiddenColumns private int currentPosition = 0; @@ -67,8 +61,8 @@ public class BoundedHiddenColsIterator implements Iterator private void init(int lowerBound, int upperBound, List hiddenColumns) { - start = lowerBound; - end = upperBound; + int start = lowerBound; + int end = upperBound; if (hiddenColumns != null) { diff --git a/src/jalview/datamodel/HiddenCursorPosition.java b/src/jalview/datamodel/HiddenCursorPosition.java index 3c0b17a..160ed71 100644 --- a/src/jalview/datamodel/HiddenCursorPosition.java +++ b/src/jalview/datamodel/HiddenCursorPosition.java @@ -1,12 +1,12 @@ package jalview.datamodel; -public class HiddenCursorPosition +public final class HiddenCursorPosition { // index of last visited region - private int regionIndex; + private final int regionIndex; // number of hidden columns before last visited region - private int hiddenSoFar; + private final int hiddenSoFar; public HiddenCursorPosition(int index, int hiddencount) { -- 1.7.10.2