From b664e416bc329636167a511e42e2410abb59782f Mon Sep 17 00:00:00 2001 From: Jim Procter Date: Sun, 7 Jul 2013 12:39:43 +0100 Subject: [PATCH] JAL-583 refactor todo about separating code to construct Jmol superposition from the code that obtains the atom matching used to construct the expression --- src/jalview/ext/jmol/JalviewJmolBinding.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/jalview/ext/jmol/JalviewJmolBinding.java b/src/jalview/ext/jmol/JalviewJmolBinding.java index 4ac247c..db1162e 100644 --- a/src/jalview/ext/jmol/JalviewJmolBinding.java +++ b/src/jalview/ext/jmol/JalviewJmolBinding.java @@ -469,6 +469,13 @@ public abstract class JalviewJmolBinding implements StructureListener, } } } + + // TODO: consider bailing if nmatched less than 4 because superposition + // not + // well defined. + // TODO: refactor superposable position search (above) from jmol selection + // construction (below) + String[] selcom = new String[files.length]; int nmatched = 0; // generate select statements to select regions to superimpose structures @@ -534,11 +541,6 @@ public abstract class JalviewJmolBinding implements StructureListener, } } } - // TODO: consider bailing if nmatched less than 4 because superposition - // not - // well defined. - // TODO: refactor superposable position search (above) from jmol selection - // construction (below) for (int pdbfnum = 0; pdbfnum < files.length; pdbfnum++) { if (pdbfnum == refStructure) -- 1.7.10.2