jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I don't really know what you've commented on here Bob! the 'defect' is an indication that this comment needs to be addressed (somehow) by the recipient of your review. I think you might be talking...

I don't really know what you've commented on here Bob! the 'defect' is an indication that this comment needs to be addressed (somehow) by the recipient of your review.

I think you might be talking about the argsParser here... which is uniquely Jalview-esque, and really designed for Jalview's use as a command line tool. The basic reason for separating the Javascript 'main' and Java 'main' is exactly for this reason - to allow us to exclude functionality not relevant for Javascript use of Jalview.

Merge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into Jalview-JS/develop

Refactoring of Jalview, JalviewAppLoader, JalviewApp, various applet-related interfaces

- makes JalviewJSApp the JavaScript interface "app" class

- removes JS interface from Jalview

- removes JalviewAppLoader and associated duplication of classes

- adds JavaScript selection and "oninit" listeners (untested)

    • -0
    • +2216
    /src/jalview/api/JalviewJSApp.java
    • -0
    • +271
    /src/jalview/appletgui/js/JSFunctionExec.java
    • -0
    • +603
    /src/jalview/appletgui/js/JalviewLiteJsApi.java
    • -0
    • +29
    /src/jalview/appletgui/js/JsCallBack.java
    • -0
    • +142
    /src/jalview/appletgui/js/JsSelectionSender.java
    • -0
    • +107
    /src/jalview/appletgui/js/MouseOverListener.java
    • -0
    • +316
    /src/jalview/appletgui/js/MouseOverStructureListener.java
    • -262
    • +287
    /src/jalview/bin/AppletParams.java
    • -12
    • +22
    /src/jalview/bin/ArgsParser.java
    • -910
    • +87
    /src/jalview/bin/Jalview.java
    • -1500
    • +0
    /src/jalview/bin/JalviewAppLoader.java
    • -612
    • +603
    /src/jalview/bin/JalviewJSApi.java
    • -11
    • +13
    /src/jalview/bin/JalviewLite.java
  1. … 15 more files in changeset.
SwingJS upgrade for JSUtil and JSUtilI

    • binary
    /swingjs/ver/3.2.9-j11/SwingJS-site.zip
    • binary
    /swingjs/ver/3.2.9/SwingJS-site.zip
JAL-3446 new Jmol 15.1.3 jar

- into j8lib

- removes netscape package dependence

    • binary
    /j8lib/Jmol-15.1.3.jar
Let's say we have a number of unknown arguments. Then, I believe, for every two unknown arguments, this code will write (over?) the alignment file that was just loaded. And then, if there is still ...

Let's say we have a number of unknown arguments. Then, I believe, for every two unknown arguments, this code will write (over?) the alignment file that was just loaded. And then, if there is still one more argument left, it will notify us of that one last argument. Am I reading that correctly? I'm going to make this Java-only and instead break if an output format was not identified. I don't know what the plan should be for Java. (I just deleted 30 identical files because I had a pile of unknown parameters.)

[What does "[ ] Defect" mean, below in this form?]

JAL-3225 Minor change to building.md for flexmark, and html output files from the process, handy to have in repo for developers

    • -0
    • +692
    /doc/releaseprocess.html
JAL-3225 Minor change to building.md for flexmark, and html output files from the process, handy to have in repo for developers

    • -0
    • +692
    /doc/releaseprocess.html
JAL-3225 Removed dependency on command line pandoc to convert .md files to .html. Now all files in doc/*.md will get converted to doc/*.html using flexmark within gradle process.

    • -0
    • +662
    /utils/doc/github.css
JAL-3225 Removed dependency on command line pandoc to convert .md files to .html. Now all files in doc/*.md will get converted to doc/*.html using flexmark within gradle process.

    • -0
    • +662
    /utils/doc/github.css
JAL-1191 reduce logging level for warnings

    • -5
    • +6
    /src/jalview/ext/so/SequenceOntology.java
JAL-3446 post-merge unit test fixes, formatting

I see...

adds link for __j2sflags.htm to template.html

updated template.html

_jvjmol.txt

    • -0
    • +232
    /utils/jalviewjs/classlists/_jvjmol.txt
JAL-3664 support for new Locale(""), meaning "not actually a ResourceBundle, just one file (MessageManager)

JAL-3664 support for user.home, user.dir, user

    • -5
    • +0
    /src/jalview/urls/IdentifiersUrlProvider.java
    • binary
    /swingjs/ver/3.2.9-j11/SwingJS-site.zip
    • binary
    /swingjs/ver/3.2.9/SwingJS-site.zip
    • -0
    • +232
    /utils/jalviewjs/classlists/_j2sclasslist_jmol.txt
JAL-3446 adds SIFTs JAL-3625 SiftsClient

    • -105
    • +73
    /src/jalview/ws/sifts/SiftsClient.java
    • -0
    • +1
    /src/jalview/ws/sifts/SiftsSettings.java
    • -6
    • +7
    /test/jalview/ws/sifts/SiftsClientTest.java
JAL-3446 from JAL-3253 ApplicationSingletonProvider missing for RestClient; others are just cosmetic

    • -16
    • +18
    /src/jalview/httpserver/HttpServer.java
    • -5
    • +6
    /src/jalview/io/gff/SequenceOntologyFactory.java
AsyncSwingWorker setpaused adjustment

    • -334
    • +380
    /src/javajs/async/AsyncSwingWorker.java
    • binary
    /swingjs/ver/3.2.9-j11/SwingJS-site.zip
JAL-3446 AsyncSwingWorker upgrade

    • -4
    • +50
    /src/javajs/async/AsyncSwingWorker.java
I suggest we close this. It's all ancient history now.

I suggest we close this. It's all ancient history now.

JAL-3446 from JAL-3253 Discoverers

    • -255
    • +266
    /src/jalview/gui/AlignFrame.java
    • -26
    • +18
    /src/jalview/gui/AnnotationLabels.java
    • -10
    • +21
    /src/jalview/urls/IdOrgSettings.java
    • -25
    • +61
    /src/jalview/ws/jws1/Discoverer.java
    • -50
    • +46
    /src/jalview/ws/jws2/Jws2Discoverer.java
    • -7
    • +23
    /src/jalview/ws/rest/RestClient.java
    • -13
    • +32
    /src/jalview/ws/sifts/SiftsSettings.java
    • -1
    • +0
    /test/jalview/ws/sifts/SiftsClientTest.java
JAL-3446 from JAL-3253 ApplicationSingletonProvider StructureSelectionManager and others

    • -1
    • +1
    /src/jalview/ext/ensembl/EnsemblCds.java
    • -2
    • +2
    /src/jalview/ext/ensembl/EnsemblGene.java
    • -2
    • +2
    /src/jalview/ext/ensembl/EnsemblSeqProxy.java
    • -23
    • +16
    /src/jalview/httpserver/HttpServer.java
    • -17
    • +9
    /src/jalview/io/cache/AppCache.java
    • -1
    • +1
    /src/jalview/io/gff/InterProScanHelper.java
    • -10
    • +44
    /src/jalview/io/gff/SequenceOntologyFactory.java
    • -11
    • +52
    /src/jalview/schemes/ColourSchemes.java
    • -24
    • +39
    /src/jalview/structure/StructureImportSettings.java
  1. … 10 more files in changeset.
JAL-3446 from JAL-3253 ApplicationSingletonProvider Desktop

    • -1
    • +1
    /src/jalview/gui/AlignExportOptions.java
    • -22
    • +22
    /src/jalview/gui/AlignFrame.java
    • -1
    • +1
    /src/jalview/gui/AnnotationLabels.java
    • -1
    • +1
    /src/jalview/gui/AssociatePdbFileWithSeq.java
    • -2
    • +2
    /src/jalview/gui/ChimeraViewFrame.java
    • -1
    • +1
    /src/jalview/gui/ColourMenuHelper.java
    • -3
    • +3
    /src/jalview/gui/CutAndPasteTransfer.java
  1. … 52 more files in changeset.
JAL-3446 from JAL-3253 ApplicationSingletonProvider 1/many

    • -17
    • +13
    /src/jalview/analysis/scoremodels/ScoreModels.java
    • -0
    • +163
    /src/jalview/bin/ApplicationSingletonProvider.java
JAL-3446 JAL-3401 from JAL-3253 HoldRepaint and SeqCanvas sizing issues.

- integrated changes from 0b573ed (gmungoc)

    • -6
    • +15
    /src/jalview/gui/AlignmentPanel.java
    • -177
    • +289
    /src/jalview/gui/SeqCanvas.java
    • -44
    • +39
    /test/jalview/gui/SeqCanvasTest.java
    • -1
    • +1
    /test/jalview/ws/PDBSequenceFetcherTest.java
JAL-3225 Using Gradle Git-Version plugin to set gitHash and gitBranch

Using Gradle Git-Version instead of exec to run git directly allows

buildship to successfully import the project into eclipse without a

command line git installed. Essential for development within Eclipse in

Windows without having to install either gradle or git as command line

tools.

JAL-3446 from JAL-3253-applet Jalview2XML integration (retains GeneLocus; switches to invokeLater)

    • -174
    • +317
    /src/jalview/project/Jalview2XML.java