jalview

.gitignore

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 02 Mar 21
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 02 Mar 2021
8:50 pm

Ben Soares

JAL-3826 Simple configuration with CodeStyle implemented in .editorconfig file

Options
    • -0
    • +3
    /.gitignore
  2. … 2 more files in changeset.
Sunday 20 Sep 2020
8:33 pm

Ben Soares

JAL-3753 put resources in gradle run and test path

Options
    • -1
    • +0
    /.gitignore
  2. … 1 more file in changeset.
Friday 18 Sep 2020
12:09 pm

Ben Soares

JAL-3594 Different icon/getdown styling when launching jalview built with -PCHANNEL=DEVELOP

Options
    • -0
    • +2
    /.gitignore
  2. … 45 more files in changeset.
12:09 pm

Ben Soares

JAL-3594 Different icon/getdown styling when launching jalview built with -PCHANNEL=DEVELOP

Options
    • -0
    • +1
    /.gitignore
  2. … 45 more files in changeset.
Tuesday 30 Jun 2020
4:50 pm

Mungo Carstairs

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work! Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this m...

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work!
Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this method seems to be trying to do two different things.

2:24 pm

Mungo Carstairs

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

2:12 pm

Mungo Carstairs

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called). So what is it there for?

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called).
So what is it there for?

1:54 pm

Mungo Carstairs

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

1:52 pm

Mungo Carstairs

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

12:36 pm

Mungo Carstairs

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

12:18 pm

Mungo Carstairs

Needs proper Javadoc

Needs proper Javadoc

11:37 am

Mungo Carstairs

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide...

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide documentation.
e.g. http://source.jalview.org/gitweb/?p=jalview.git;a=blob;f=doc/JalviewJS-startupParams.md;h=9ff33529b2dbc2da34d2a573ccf5d042194fbb0d;hb=refs/heads/Jalview-JS/develop

Thursday 25 Jun 2020
2:16 pm

Mungo Carstairs

Due to the number of changes this is likely to be a 'best efforts' review.

Due to the number of changes this is likely to be a 'best efforts' review.

2:14 pm

Mungo Carstairs

Commits to JS-develop from 2nd to 25th June 2020
Commits to JS-develop from 2nd to 25th June 2020
Wednesday 03 Jun 2020
10:30 pm

Bob Hanson

I see...

Options
    • -0
    • +1
    /.gitignore
10:26 pm

Bob Hanson

updated template.html

Options
    • -1
    • +0
    /.gitignore
  2. … 1 more file in changeset.
Tuesday 02 Jun 2020
4:32 am

Bob Hanson

Bob's gitignore addition

/build-site.xml

/buildcore.xml

/j11lib/intervalstore-v1.0.jar

Options
    • -0
    • +3
    /.gitignore
Friday 17 Apr 2020
1:19 am

Bob Hanson

added .gitignore paths

I need these until I fully grasp the ways that gradle works.

Options
    • -0
    • +2
    /.gitignore
Thursday 26 Mar 2020
5:37 pm

Ben Soares

JAL-3225 This one file needed for project if git clean -dfx run

Options
    • -0
    • +1
    /.gitignore
  2. … 1 more file in changeset.
5:37 pm

Ben Soares

JAL-3225 This one file needed for project if git clean -dfx run

Options
    • -0
    • +1
    /.gitignore
  2. … 1 more file in changeset.
5:13 pm

Ben Soares

JAL-3225 All of .settings now gitignored. org.eclipse...prefs made by buildship or gradle eclipse. Jalview specific prefs pulled in from utils/eclipse/org.eclipse.jdt.core.jalview.prefs

Options
    • -1
    • +1
    /.gitignore
  2. … 6 more files in changeset.
5:13 pm

Ben Soares

JAL-3225 All of .settings now gitignored. org.eclipse...prefs made by buildship or gradle eclipse. Jalview specific prefs pulled in from utils/eclipse/org.eclipse.jdt.core.jalview.prefs

Options
    • -1
    • +1
    /.gitignore
  2. … 6 more files in changeset.
Wednesday 25 Mar 2020
5:07 pm

Ben Soares

JAL-3248 Added instructions for downloading and configuring as gradle project in Eclipse only, i.e. no command line tools needed

Options
    • -1
    • +0
    /.gitignore
  2. … 7 more files in changeset.
Wednesday 18 Mar 2020
5:44 pm

Bob Hanson

JAL-3559 temporary branch adding JS files complete

Options
    • -0
    • +1
    /.gitignore
  2. … 90 more files in changeset.
Sunday 09 Feb 2020
9:38 am

Ben Soares

JAL-3521 Ignore quilt dir /.pc

Options
    • -0
    • +1
    /.gitignore
Monday 09 Dec 2019
2:29 am

Ben Soares

JAL-3449 Fixed Info.plist file insertion. Simplified install4j conf filename

Options
    • -0
    • +1
    /.gitignore
  2. … 2 more files in changeset.
Thursday 21 Nov 2019
12:56 pm

Ben Soares

JAL-3449 Using .gitignore from Jalview-JS/develop

Options
    • -1
    • +8
    /.gitignore
Thursday 14 Nov 2019
3:57 pm

Ben Soares

JAL-3210 need this .gitignore addition for the new location of .build_properties

Options
    • -1
    • +1
    /.gitignore
3:55 pm

Ben Soares

JAL-3210 .build_properties now created in /resources, which is found in Eclipse/buildship classpath. Does not affect jar build

Options
    • -0
    • +1
    /.gitignore
  2. … 1 more file in changeset.
Wednesday 30 Oct 2019
5:10 pm

Ben Soares

JAL-3210 Fixed jalviewjs dependencies. Changed linkCheck to tee output to .out file. Tidying jalviewjs paths.

Options
    • -1
    • +1
    /.gitignore
  2. … 3 more files in changeset.