jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-3739 catch parameter errors and report to the user

    • -2
    • +1
    /resources/lang/Messages_es.properties
    • -30
    • +42
    /src/jalview/ws/jws2/MsaWSClient.java
    • -7
    • +6
    /src/jalview/ws/jws2/dm/JabaOption.java
JAL-3739 validate input on tab out of field

    • -7
    • +17
    /src/jalview/gui/OptsAndParamsPage.java
JAL-3739 always take input values from form fields (not defaults)

    • -15
    • +15
    /src/jalview/ws/jws2/Jws2Client.java
JAL-3739 use logger to reduce debug output

    • -17
    • +19
    /src/jalview/gui/WsJobParameters.java
JAL-3594 Added rotating logo png

    • -23
    • +21
    /src/jalview/gui/WebserviceInfo.java
JAL-3754 fixed a problem with jar task creating a stray dir when building

JAL-3775 added the Platform.isLinux() check for test HiDPISetting2

    • -0
    • +9
    /test/jalview/bin/HiDPISettingTest2.java
Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

JAL-3594 New jalview.util.ChannelProperties to get/cache values and images used in the application. Starting to tidy images in resources/images.

    • binary
    /resources/images/JalviewLogo_Huge.png
    • binary
    /resources/images/JalviewLogo_big.png
    • binary
    /resources/images/Jalview_Logo_small.png
    • binary
    /resources/images/jalview_logo_background_fade-640x480.png
    • -12
    • +8
    /src/jalview/bin/JalviewTaskbar.java
    • -16
    • +17
    /src/jalview/gui/SplashScreen.java
    • -0
    • +136
    /src/jalview/util/ChannelProperties.java
  1. … 6 more files in changeset.
JAL-3594 Generating GIMP XCF files for getdown and new release getdown images

    • binary
    /utils/channels/release/images/jalview_getdown_background.xcf
JAL-3594 Release images and channel properties

    • binary
    /utils/channels/develop/resources/images/UoD_banner.png
    • -0
    • +17
    /utils/channels/release/channel_gradle.properties
  1. … 50 more files in changeset.
JAL-3594 New way for build.gradle to override properties with channel based properties files. Starting to tidy up some old image files

    • binary
    /resources/images/JalviewDevelopLogo_Huge.png
    • -0
    • +31
    /utils/channels/develop/channel_gradle.properties
    • binary
    /utils/channels/develop/images/jalview_develop_getdown_background_initialising.png
    • binary
    /utils/channels/develop/images/jalview_develop_logo.icns
    • binary
    /utils/channels/develop/images/jalview_develop_logo.ico
  1. … 61 more files in changeset.
JAL-3751 second occurrence of bug squashed

    • -22
    • +34
    /test/jalview/util/MapListTest.java
JAL-3761 helper method reinstated to avoid code duplication

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

JAL-3608 cherry pick of 92cb745e7
JAL-3608 cherry pick of 92cb745e7
JAL-3594 new logos, icons and cosmetics for getdown and install4j

    • binary
    /utils/getdown/develop/Jalview-Logo.png
    • binary
    /utils/getdown/develop/jalview_logo_background_getdown_error-640x480.png
    • binary
    /utils/getdown/develop/jalview_logo_background_getdown_instant-640x480.png
    • binary
    /utils/install4j/develop/Jalview-Logo.png
  1. … 20 more files in changeset.
Merge branch 'develop' into merge/develop_and_rebase_squashed_merge_JAL-3628+JAL-3608+JAL-3609+JAL-3541+Release_2_11_1_Branch

JAL-3609 JAL-3775 Updated getdown with re-factored HiDPISetting and ScreenInfo. No real functionality change.

    • binary
    /getdown/lib/getdown-launcher-local.jar
JAL-3609 JAL-3775 Tests for jalview.bin.HiDPISetting

    • -0
    • +116
    /test/jalview/bin/HiDPISettingTest1.java
    • -0
    • +223
    /test/jalview/bin/HiDPISettingTest2.java
    • -0
    • +15
    /test/jalview/bin/hidpiTestProps.jvprops
JAL-3609 JAL-3775 Refactoring a bit of jalview.bin.HiDPISetting so screen display can be mocked in tests by Mockito

    • -0
    • +21
    /src/jalview/bin/ScreenInfo.java
JAL-3775 Adding Mockito jars for tests. Needed for HiDPISettingTest1

    • binary
    /utils/testnglibs/byte-buddy-1.10.15.jar
    • binary
    /utils/testnglibs/byte-buddy-agent-1.10.15.jar
    • binary
    /utils/testnglibs/mockito-core-3.6.0.jar
    • binary
    /utils/testnglibs/objenesis-3.1.jar
JAL-3774 better translation

    • -1
    • +1
    /resources/lang/Messages_es.properties
JAL-3530 Added a -nowebservicediscovery command line argument.

JAL-3774 missing i18n added, overlong translation shortened

    • -1
    • +2
    /resources/lang/Messages_es.properties
JAL-3690 for a laugh, lets enable web services!

JAL-3690 update to next patched 3.2.9 j2s c336e447

    • binary
    /swingjs/ver/3.2.9/SwingJS-site.zip
JAL-3690 update j2s from hanson1 branch 0b8b02bb

    • binary
    /swingjs/ver/3.2.9-j11/SwingJS-site.zip
    • binary
    /swingjs/ver/3.2.9/SwingJS-site.zip
    • binary
    /swingjs/ver/3.2.9/net.sf.j2s.core.jar