Activity jalview/getdown/lib/JVL

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

5:31 pm

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

5:56 pm

Jim Procter

More
Re: CR-JAL-244
commented on review

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

5:53 pm

Jim Procter

More
Re: CR-JAL-244
commented on review

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

5:20 pm

Jim Procter

More
CR-JAL-244
started review

JAL-3608 cherry pick of 92cb745e7

2:57 pm

Ben Soares

More
1a4dd17
changed 14 files
master, JAL-3416_different_look_and_feel_on_linux and 71 more CR-JAL-244

JAL-3609 JAL-3775 Updated getdown with re-factored HiDPISetting and ScreenInfo. No real functionality change.

- -1
- +1
./JVL_VERSION
- History
- Source
- Diff
./JVL_VERSION
… 13 more files in changeset.

6:10 pm

Ben Soares

More
a00010a
changed 12 files
master, JAL-3416_different_look_and_feel_on_linux and 71 more

JAL-3775 Re-compiled Getdown jars

- -1
- +1
./JVL_VERSION
- History
- Source
- Diff
./JVL_VERSION
… 11 more files in changeset.

4:17 pm

Ben Soares

More
846d97a
changed 7 files
master, bug/JAL-3288_override_all_JInternalFrame_with_Classic_JInternalFrame and 34 more

JAL-3718 Fixed getdown auto-update. This commit Getdown jars and version files.

- -1
- +1
./JVL_VERSION
- History
- Source
- Diff
./JVL_VERSION
… 6 more files in changeset.

4:09 pm

Ben Soares

More
2088084
changed 11 files

JAL-3718 fixed getdown auto-update for future updates. Getdown Jars and version files.

- -1
- +1
./JVL_VERSION
- History
- Source
- Diff
./JVL_VERSION
… 10 more files in changeset.

11:23 pm

Ben Soares

More
9c70103
changed 7 files
master, JAL-3416_different_look_and_feel_on_linux and 75 more

JAL-3718 force re-initialise of getdown.txt file when new getdown.txt downloaded from appbase. getdown jar and version files

- -1
- +1
./JVL_VERSION
- History
- Source
- Diff
./JVL_VERSION
… 6 more files in changeset.

12:38 am

Ben Soares

More
0240a9e
changed 20 files
master, bug/JAL-3288_override_all_JInternalFrame_with_Classic_JInternalFrame and 35 more

JAL-3718 Added digestonly key to getdown.txt to copy file to alt or release when building, and to be included in the getdown digest. This key is completely ignored by the getdown-launcher. Looks in j8/j11digestonly.