Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-3633 refactored/simplified LaunchUtils code

    • -41
    • +0
    ./main/java/jalview/bin/LaunchUtils.java
    • -6
    • +17
    ./main/java/jalview/util/ChannelProperties.java
    • -0
    • +56
    ./main/java/jalview/util/LaunchUtils.java
  1. … 5 more files in changeset.
JAL-3503 Added a Startup tab in Preferences, with gui for JVMMEMMAX and JVMMEMPC settings. Allowed jalview.bin.Launcher and getdown to read/use these memory settings at launch. Added channel.props to getdown appdir, used to determing correct .jalview_properties file. Refactored MemorySetting a bit, with more helper methods for the Preferences tab.

    • -0
    • +41
    ./main/java/jalview/bin/LaunchUtils.java
    • -70
    • +179
    ./main/java/jalview/bin/MemorySetting.java
    • -0
    • +277
    ./main/java/jalview/util/ChannelProperties.java
    • -0
    • +585
    ./main/java/jalview/util/StringUtils.java
  1. … 16 more files in changeset.
JAL-3523 Remove getdown setting the working directory to appdir

  1. … 5 more files in changeset.
Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

JAL-3608 cherry pick of 92cb745e7
JAL-3608 cherry pick of 92cb745e7
JAL-3609 JAL-3775 Updated getdown with re-factored HiDPISetting and ScreenInfo. No real functionality change.

    • -7
    • +39
    ./main/java/jalview/bin/HiDPISetting.java
    • -0
    • +21
    ./main/java/jalview/bin/ScreenInfo.java
  1. … 12 more files in changeset.
JAL-3609 formatting save after cherry-picks

    • -46
    • +46
    ./main/java/jalview/bin/MemorySetting.java
  1. … 1 more file in changeset.
JAL-3718 fixed getdown auto-update for future updates. Getdown src files only

  1. … 1 more file in changeset.
JAL-3718 force re-initialise of getdown.txt file when new getdown.txt downloaded from appbase. getdown src files

  1. … 5 more files in changeset.
JAL-3718 force re-initialise of getdown.txt file when new getdown.txt downloaded from appbase. getdown src files

  1. … 5 more files in changeset.
JAL-3718 Added digestonly key to getdown.txt to copy file to alt or release when building, and to be included in the getdown digest. This key is completely ignored by the getdown-launcher. Looks in j8/j11digestonly.

  1. … 18 more files in changeset.
JAL-3633 pass getdown proxy settings in proxy.txt on to Jalview

  1. … 1 more file in changeset.
JAL-3633 pass getdown proxy settings in proxy.txt on to Jalview

JAL-3609 New auto-scale 'formula' for linux HiDPI. Tested to work for UHD screen in various OS display settings.

    • -47
    • +79
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 13 more files in changeset.
JAL-3609 New auto-scale 'formula' for linux HiDPI. Tested to work for UHD screen in various OS display settings.

    • -47
    • +79
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 6 more files in changeset.
JAL-3609 corrected maxdimension to mindimension. Adjusted tallscreen limit

    • -11
    • +11
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 6 more files in changeset.
JAL-3609 corrected maxdimension to mindimension. Adjusted tallscreen limit

    • -11
    • +11
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 6 more files in changeset.
JAL-3609 changed property names to something more palatable and catered for portrait screens

    • -38
    • +62
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 6 more files in changeset.
JAL-3609 changed property names to something more palatable and catered for portrait screens

    • -38
    • +62
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 6 more files in changeset.
JAL-3609 system properties to force a scale, or automatically choose based on OS, Screen DPI and Screen height in pixels

    • -18
    • +80
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 6 more files in changeset.
JAL-3609 system properties to force a scale, or automatically choose based on OS, Screen DPI and Screen height in pixels

    • -18
    • +80
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 6 more files in changeset.
JAL-3609 Added a -DforceHiDPISetting=true option mainly for testing, and updated getdown HiDPISetting

    • -0
    • +20
    ./main/java/jalview/bin/GetMemory.java
    • -15
    • +29
    ./main/java/jalview/bin/HiDPISetting.java
    • -0
    • +20
    ./main/java/jalview/bin/MemorySetting.java
  1. … 7 more files in changeset.
JAL-3609 Added a -DforceHiDPISetting=true option mainly for testing, and updated getdown HiDPISetting

    • -0
    • +20
    ./main/java/jalview/bin/GetMemory.java
    • -15
    • +29
    ./main/java/jalview/bin/HiDPISetting.java
    • -0
    • +20
    ./main/java/jalview/bin/MemorySetting.java
  1. … 7 more files in changeset.
JAL-3609 HiDPI scale setting done via system prop in getdown or halview.bin.Launcher

    • -0
    • +48
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 15 more files in changeset.
JAL-3609 HiDPI scale setting done via system prop in getdown or halview.bin.Launcher

    • -0
    • +48
    ./main/java/jalview/bin/HiDPISetting.java
  1. … 15 more files in changeset.
(Notes for self) - Ben verified on linux, OSX, Windows. Need to check there are docs and logging to indicate that the hard limit is reached, so if people want to adjust the limit they can !

(Notes for self) - Ben verified on linux, OSX, Windows.
Need to check there are docs and logging to indicate that the hard limit is reached, so if people want to adjust the limit they can !

JAL-3477 New sensible default decisions on memory, and new jvmmemmax setting for setting absolute...
JAL-3477 New sensible default decisions on memory, and new jvmmemmax setting for setting absolute...