analysis

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SequencesInfo which is an individual object is doable, but I feel like it would be just a wrapper around a Map. What additional functionality would SequencesInfo have over a traditional Map? I'm n...

SequencesInfo which is an individual object is doable, but I feel like it would be just a wrapper around a Map. What additional functionality would SequencesInfo have over a traditional Map?

I'm not very familiar with serialization in java, I know there are libraries that can serialize beans to json or xml, but what are your expectations in this case?

one class with a static factory method seems to be better than two classes and an external mutable object.

one class with a static factory method seems to be better than two classes and an external mutable object.

JAL-3899 Replace prints with logger messages.

What's wrong with static classes? They are just like regular classes but within other class' namespace. That's non-static inner classes that are special. About factory pattern, I think it would be ...

What's wrong with static classes? They are just like regular classes but within other class' namespace. That's non-static inner classes that are special.
About factory pattern, I think it would be an overkill for a class that is only used by SeqsetUtils' methods.

yes, I see that, but do you really need a nested static class ? in line with my general comments re encapsulating the Map<String,SequenceInfo> further: perhaps it might make sense to simply apply a...

yes, I see that, but do you really need a nested static class ? in line with my general comments re encapsulating the Map<String,SequenceInfo> further: perhaps it might make sense to simply apply a factory pattern rather than have an internal bean that a generic map holds references to ?

(lets not get stuck on this though, the main thing is that the implementation works fine for now, though needs more work in order to save/restore sequenceInfo objects from Jalview project files)

Because it's instantiated in a static context e.g. uniquify and it does not need an instance of SeqsetUtils object to work.

Because it's instantiated in a static context e.g. uniquify and it does not need an instance of SeqsetUtils object to work.

we won't see this messages unless asserts are enabled. Cache.log.warn is perhaps better ?

we won't see this messages unless asserts are enabled. Cache.log.warn is perhaps better ?

it's a reasonable first pass, though stylistically all you've done is transformed a single concrete instance (Hashtable) to a more strongly typed verbose instance (Map<String,SequenceInfo>). Why no...

it's a reasonable first pass, though stylistically all you've done is transformed a single concrete instance (Hashtable) to a more strongly typed verbose instance (Map<String,SequenceInfo>). Why not go further and have a SequencesInfo object that records metadata for one or more sequences ?

There are also other requirements: SequenceInfo sets will need to be persisted for a web services job. You could expand JAL-3899 to incorporate this perhaps - JAL-1786 is the relevant epic for that.

why does this class need to be static ?

why does this class need to be static ?

this should probably be Cache.log.warn(..)

this should probably be Cache.log.warn(..)

JAL-3899 Refactor sequence de/uniquification.
JAL-3899 Refactor sequence de/uniquification.
JAL-3899 Refactor sequence de/uniquification.

  1. … 1 more file in changeset.
JAL-3691 automatic insertion of Locale.ROOT to toUpperCase() and toLowerCase() and added import java.util.Locale appropriately

  1. … 96 more files in changeset.
JAL-3854 patched SeqSeqUtils.deUniquify to not use instanceOf - seems to work

WIP
WIP
Merge branch 'Jalview-JS/develop' into merge_js_develop also patched new code from JAL-3690 refactorings

  1. … 56 more files in changeset.
JAL-3759 exclude hidden columns when processing column selection

  1. … 1 more file in changeset.
JAL-3700 JAL-3748 JAL-3763 don’t add stop codon via alignAs if guide peptide doesn’t include C terminus.

fix for JAL-3765

fix for JAL-3765

JAL-3763 always make a new dataset sequence for CDS sequence

JAL-3763 always make a new dataset sequence for CDS sequence

JAL-3748 don’t trash start/end on SequenceI reconstructed from a SeqCigar via SeqsetUtils.SeqCharacterUnhash

  1. … 1 more file in changeset.
JAL-3748 pass a list to findAlignedSequence to return mapping that relates CDS and the returned Peptide sequence to avoid searching twice

  1. … 1 more file in changeset.
JAL-3490 merged with 2.11.2 develop

  1. … 22 more files in changeset.
JAL-3490 match count independent of contiguous matches count

  1. … 8 more files in changeset.
JAL-3490 match count independent of contiguous matches count

  1. … 8 more files in changeset.
Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work! Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this m...

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work!
Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this method seems to be trying to do two different things.