viewmodel

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-3878 Create pollable task and executor it can be run with.

  1. … 3 more files in changeset.
JAL-3878 Rename web service worker to more generic pollable task.

  1. … 8 more files in changeset.
This is waiting for us to define the "language" of edam classifiers that we are going to support. Currently we only define services by what operation they perform but there is plenty of room for fi...

This is waiting for us to define the "language" of edam classifiers that we are going to support. Currently we only define services by what operation they perform but there is plenty of room for fine grained tuning of operations based on other classifiers.

Yes, there are pieces of code that can be reused across multiple if not all other workers. I suppose we can either add component classes that can be used by the workers that need them or we can cre...

Yes, there are pieces of code that can be reused across multiple if not all other workers. I suppose we can either add component classes that can be used by the workers that need them or we can create an abstract base class for all workers with implementations of common methods. The purpose of operation class is to provide metadata and create a worker, so the operation should stay as it is, but the worker needs to be tidied up. I absolutely agree that currently it is too bloated and should be split into smaller pieces but for now I wanted something that just works.
Regarding tuning, the whole point is that now the service is made of operations instead of extending one, so we can create new operations or add extra parameters to the existing operation classes that would alter worker behaviour without touching other parts of the code.

after taking a look at the rest I can see that the next step is to split this class up further. There's plenty of code that will be used by many different operations - e.g. job state management - i...

after taking a look at the rest I can see that the next step is to split this class up further. There's plenty of code that will be used by many different operations - e.g. job state management - is that the plan ?

not really the recommended way - see e.g. https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/java/beans/PropertyChangeSupport.html *do you need to expose the generic binders ? what k...

not really the recommended way - see e.g. https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/java/beans/PropertyChangeSupport.html

  • do you need to expose the generic binders ? what kind of events need to be monitored ?
is utils really the right name ? suggest the classes are used in several different places

is utils really the right name ? suggest the classes are used in several different places

this is going to get much more complex. there are plenty of additional attributes - e.g. input type (dna, protein, rna) - none of them are currently being configured on the operation.

this is going to get much more complex. there are plenty of additional attributes - e.g. input type (dna, protein, rna) - none of them are currently being configured on the operation.

this class seems to contain a bunch of hard coded stuff taken from the original web services configuration code rather than provide a way for a web services provider to configure an instance of Ali...

this class seems to contain a bunch of hard coded stuff taken from the original web services configuration code rather than provide a way for a web services provider to configure an instance of AlignmentOperation tuned to the alignment service that the provider is offering.

first review of Web Services overhaul for 2.12
first review of Web Services overhaul for 2.12
JAL-3878 Add web service executor class and instantiate for each alignment viewport.

  1. … 1 more file in changeset.
patch needed for 2.11.2 - JAL-3518 - catch case when no replies are available

patch needed for 2.11.2 - JAL-3518 - catch case when no replies are available

semantics for determining if a PDB file has a SIFTs mapping - could be absorbed into the PDB metadata object

semantics for determining if a PDB file has a SIFTs mapping - could be absorbed into the PDB metadata object

magic logic to recognise which structure database provider client to use - PDB or AlphaFold - ensures metadata and annotation rows are propagates

magic logic to recognise which structure database provider client to use - PDB or AlphaFold - ensures metadata and annotation rows are propagates

Reviewing the alphafold + contact matrix patch for 2.11.2
Reviewing the alphafold + contact matrix patch for 2.11.2
Merge branch 'features/JAL-2349_matrixvis' into features/JAL-2349_matrixvis_2112

  1. … 6 more files in changeset.
JAL-3690 Remove references to old AlignCalcManager.

  1. … 5 more files in changeset.
WIP
WIP
Merge branch 'Jalview-JS/develop' into merge_js_develop also patched new code from JAL-3690 refactorings

  1. … 56 more files in changeset.
JAL-3690 - introduce shutdown method that cleans up manager's resources.

  1. … 3 more files in changeset.
JAL-3763 refactored getCoveringMapping for virtual feature discovery

    • -7
    • +7
    ./seqfeatures/FeatureRendererModel.java
  1. … 1 more file in changeset.
JAL-3763 refactored getCoveringMapping for virtual feature discovery

    • -7
    • +7
    ./seqfeatures/FeatureRendererModel.java
  1. … 1 more file in changeset.
JAL-3748 store an AlignmentView for the complement within an viewport’s AlignView so it can be recovered after a web service operation

  1. … 3 more files in changeset.
JAL-3719 Format->Colour Gaps option uses Overview gap colour logic pulled up to alignment viewport sequence renderer

  1. … 9 more files in changeset.
JAL-3719 Format->Colour Gaps option uses Overview gap colour logic pulled up to alignment viewport sequence renderer Conflicts: resources/lang/Messages.properties resources/lang/Messages_es.properties

  1. … 9 more files in changeset.
JAL-3490 merged with 2.11.2 develop

  1. … 22 more files in changeset.