jalview/swingjs

timestamp

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 12 Sep
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 12 Sep
3:53 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3829 upgrade Jmol to 14.31.53, SwingJS-JSMol to 14.31.54 and SwingJS to 3.3.1

Options
    • -1
    • +1
    ./timestamp
  2. … 22 more files in changeset.
Sunday 25 Jul
2:47 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3848 update swingJS runtime and transpiler to 3.3.1

Options
    • -1
    • +1
    ./timestamp
  2. … 16 more files in changeset.
Tuesday 06 Jul
5:42 pm

Jim Procter

5:42 pm

Jim Procter

WIP
WIP
Monday 11 Jan
9:28 pm

Ben Soares

JAL-3789 New swingjs for Java2Script 3.2.10 with j2s.config.altfileproperty

Options
    • -1
    • +1
    ./timestamp
  2. … 38 more files in changeset.
9:28 pm

Ben Soares

JAL-3789 New swingjs for Java2Script 3.2.10 with j2s.config.altfileproperty

Options
    • -1
    • +1
    ./timestamp
  2. … 46 more files in changeset.
Friday 11 Dec 2020
2:33 pm

Mateusz Warowny

JAL-3690 Let's enable web services (seriously this time)

Options
    • -1
    • +1
    ./timestamp
  2. … 41 more files in changeset.
2:33 pm

Mateusz Warowny

JAL-3690 Web services and interactive workers somewhat working.

Options
    • -1
    • +1
    ./timestamp
  2. … 41 more files in changeset.
Thursday 10 Dec 2020
5:50 pm

Jim Procter

JAL-3223 - update swingjs to 3.2.9-j11

Options
    • -1
    • +1
    ./timestamp
  2. … 14 more files in changeset.
Sunday 06 Dec 2020
1:35 pm

Jim Procter

JAL-3690 update to swingjs patch 3.2.9

Options
    • -1
    • +1
    ./timestamp
  2. … 10 more files in changeset.
Monday 30 Nov 2020
3:59 pm

Jim Procter

JAL-3690 update to next patched 3.2.9 j2s c336e447

Options
    • -1
    • +1
    ./timestamp
  2. … 3 more files in changeset.
3:56 pm

Jim Procter

JAL-3690 update j2s from hanson1 branch 0b8b02bb

Options
    • -1
    • +1
    ./timestamp
  2. … 8 more files in changeset.
Tuesday 30 Jun 2020
4:50 pm

Mungo Carstairs

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work! Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this m...

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work!
Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this method seems to be trying to do two different things.

2:24 pm

Mungo Carstairs

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

2:12 pm

Mungo Carstairs

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called). So what is it there for?

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called).
So what is it there for?

1:54 pm

Mungo Carstairs

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

1:52 pm

Mungo Carstairs

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

12:36 pm

Mungo Carstairs

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

12:18 pm

Mungo Carstairs

Needs proper Javadoc

Needs proper Javadoc

11:37 am

Mungo Carstairs

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide...

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide documentation.
e.g. http://source.jalview.org/gitweb/?p=jalview.git;a=blob;f=doc/JalviewJS-startupParams.md;h=9ff33529b2dbc2da34d2a573ccf5d042194fbb0d;hb=refs/heads/Jalview-JS/develop

Thursday 25 Jun 2020
2:16 pm

Mungo Carstairs

Due to the number of changes this is likely to be a 'best efforts' review.

Due to the number of changes this is likely to be a 'best efforts' review.

2:14 pm

Mungo Carstairs

Commits to JS-develop from 2nd to 25th June 2020
Commits to JS-develop from 2nd to 25th June 2020
2:01 pm

Mungo Carstairs

Tuesday 23 Jun 2020
5:21 pm

Jim Procter

JAL-3622 update with swingJS from hansonr1

Options
    • -1
    • +1
    ./timestamp
  2. … 8 more files in changeset.
Monday 15 Jun 2020
6:54 pm

Bob Hanson

JAL-3657 SwingJS HashMap.putEntries() coding mistake.

Options
    • -1
    • +1
    ./timestamp
  2. … 5 more files in changeset.
Sunday 14 Jun 2020
3:42 am

Bob Hanson

JAL-3653 SwingJS support for indeterminate JProgressBar

Options
    • -1
    • +1
    ./timestamp
  2. … 5 more files in changeset.
Saturday 13 Jun 2020
10:37 pm

Bob Hanson

JAL-3487 Splash screen

- cleaner code, more comments

- adds SwingJS support for 1-ms image finalization

(using JSToolkit.dispatch instead of invokeLater

Options
    • -1
    • +1
    ./timestamp
  2. … 4 more files in changeset.
3:30 pm

Bob Hanson

minor changes

Options
    • -1
    • +1
    ./timestamp
  2. … 10 more files in changeset.
Friday 12 Jun 2020
3:02 pm

Bob Hanson

JAL-3446 SwingJS update

-fixes desktop frame not taking focus when clicked, so not processing

menu shortcuts

Options
    • -1
    • +1
    ./timestamp
  2. … 3 more files in changeset.
2:32 pm

Bob Hanson

JAL-3664 shortcuts in Desktop not working from AlignFrame

- missing test for JInternalFrame in JComponent.processKeyBindings

Options
    • -1
    • +1
    ./timestamp
  2. … 3 more files in changeset.