timestamp

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-3789 New swingjs for Java2Script 3.2.10 with j2s.config.altfileproperty

  1. … 38 more files in changeset.
JAL-3789 New swingjs for Java2Script 3.2.10 with j2s.config.altfileproperty

  1. … 46 more files in changeset.
JAL-3690 Let's enable web services (seriously this time)

  1. … 41 more files in changeset.
JAL-3690 Web services and interactive workers somewhat working.

  1. … 41 more files in changeset.
JAL-3223 - update swingjs to 3.2.9-j11

  1. … 14 more files in changeset.
JAL-3690 update to swingjs patch 3.2.9

  1. … 10 more files in changeset.
JAL-3690 update to next patched 3.2.9 j2s c336e447

  1. … 3 more files in changeset.
JAL-3690 update j2s from hanson1 branch 0b8b02bb

  1. … 8 more files in changeset.
Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work! Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this m...

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work!
Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this method seems to be trying to do two different things.

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called). So what is it there for?

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called).
So what is it there for?

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

Needs proper Javadoc

Needs proper Javadoc

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide...

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide documentation.
e.g. http://source.jalview.org/gitweb/?p=jalview.git;a=blob;f=doc/JalviewJS-startupParams.md;h=9ff33529b2dbc2da34d2a573ccf5d042194fbb0d;hb=refs/heads/Jalview-JS/develop

Due to the number of changes this is likely to be a 'best efforts' review.

Due to the number of changes this is likely to be a 'best efforts' review.

Commits to JS-develop from 2nd to 25th June 2020
Commits to JS-develop from 2nd to 25th June 2020
JAL-3622 update with swingJS from hansonr1

  1. … 8 more files in changeset.
JAL-3657 SwingJS HashMap.putEntries() coding mistake.

  1. … 5 more files in changeset.
JAL-3653 SwingJS support for indeterminate JProgressBar

  1. … 5 more files in changeset.
JAL-3487 Splash screen

- cleaner code, more comments

- adds SwingJS support for 1-ms image finalization

(using JSToolkit.dispatch instead of invokeLater

  1. … 4 more files in changeset.
minor changes

  1. … 10 more files in changeset.
JAL-3446 SwingJS update

-fixes desktop frame not taking focus when clicked, so not processing

menu shortcuts

  1. … 3 more files in changeset.
JAL-3664 shortcuts in Desktop not working from AlignFrame

- missing test for JInternalFrame in JComponent.processKeyBindings

  1. … 3 more files in changeset.
SwingJS upgrade fixes AlignmentPanel keyPressed not called

- ContentPane was getting the message, not JInternalFrame

  1. … 5 more files in changeset.
JAL-3446 SwingJS upgrade for html labels and tooltips preferred size fix

- adds display:inline-block to label spans

- better testing for isHTML in labels

  1. … 3 more files in changeset.
JAL-3446 SwingJS-site.zip for dynamic menus

- adds missing mouse-event bindings to all

dynamically created menu items

immediately after return from menuSelected event

- fixes issue of menus too eager to close

  1. … 3 more files in changeset.
JAL-3446 proposed dropdown fix

- 100 ms delay for opening

- proper toggle operation for button

- all actions on mouseup

- tooltips open and close appropriately

  1. … 5 more files in changeset.