jalview_embedded_example1.html

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work! Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this m...

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work!
Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this method seems to be trying to do two different things.

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called). So what is it there for?

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called).
So what is it there for?

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

Needs proper Javadoc

Needs proper Javadoc

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide...

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide documentation.
e.g. http://source.jalview.org/gitweb/?p=jalview.git;a=blob;f=doc/JalviewJS-startupParams.md;h=9ff33529b2dbc2da34d2a573ccf5d042194fbb0d;hb=refs/heads/Jalview-JS/develop

Due to the number of changes this is likely to be a 'best efforts' review.

Due to the number of changes this is likely to be a 'best efforts' review.

Commits to JS-develop from 2nd to 25th June 2020
Commits to JS-develop from 2nd to 25th June 2020
JAL-3446 reorganized JalviewJSApp (accidentally put that in jalview/api) and fixes for 2-applet example

- API.md

- follows commit 01717e2 (missing JAL-3446 tag)

    • -147
    • +0
    ./jalview_embedded_example1.html
  1. … 17 more files in changeset.
reorganized JalviewJSApp (accidentally put that in jalview/api) and fixes for 2-applet example

    • -147
    • +0
    ./jalview_embedded_example1.html
  1. … 16 more files in changeset.
JAL-3446 adds Jmol viewer embedding.

    • -12
    • +20
    ./jalview_embedded_example1.html
JAL-3446 embedded file for proper name matching

web app name "Jalview"

div id="Jalview-desktop-div"

So whatever name you give the applet must match the div tags.

Previously, the div name was associated with a different name,

Info.j2sAppID, or something like that. This is much more sensible.

Just don't name it "jalview", because that is a package name!

    • -11
    • +13
    ./jalview_embedded_example1.html
JAL-3210 New site-resources dir too

    • -0
    • +137
    ./jalview_embedded_example1.html
  1. … 43 more files in changeset.
JAL-3210 Improvements to eclipse detection. New src tree and SwingJS updated from the applet branch. AND IT WORKS (sometimes)

    • -0
    • +134
    ./jalview_embedded_example1.html
  1. … 343 more files in changeset.