jalview/utils/jalviewjs

template.html

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 15 Dec 20
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 15 Dec 2020
7:04 pm

Jim Procter

JAL-3690 tweak J2S direct DB access registration for jalview, compbio and other sites

Options
    • -2
    • +2
    ./template.html
  2. … 1 more file in changeset.
6:46 pm

Jim Procter

JAL-3690 direct access to slivka, compbio, jalview.org and localhost/loopback.

Options
    • -0
    • +3
    ./template.html
  2. … 1 more file in changeset.
11:53 am

Jim Procter

JAL-3690 disable proxy server for JalviewJS

Options
    • -1
    • +1
    ./template.html
Tuesday 30 Jun 2020
4:50 pm

Mungo Carstairs

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work! Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this m...

Ah it does run when a column selection is made in a split frame (and propagated to the other panel). Which seems to work!
Maybe just needs a less clumsy AlignmentViewport.isColSelChanged() - this method seems to be trying to do two different things.

2:24 pm

Mungo Carstairs

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

Suggesting renaming to PROPERTY_COLUMNS = "columns" as this is used to notify changes to column selection or visibility, not sequences

2:12 pm

Mungo Carstairs

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called). So what is it there for?

I think this code path rarely gets run (AlignmentViewport.notifySequence() rarely gets called).
So what is it there for?

1:54 pm

Mungo Carstairs

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

Suggest renaming notifyAlignment() to notifyAlignmentChanged(), and notifySequence() to notifyColumnChange() as it it fired for changes to column (not sequence) selection or visibility.

1:52 pm

Mungo Carstairs

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

Unclear what notifySequence() adds. As placed here, it is hardly ever reached.

12:36 pm

Mungo Carstairs

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

Not sure how to review this (and the appletgui/js classes) without pointers to documentation and/or examples of how it is used.

12:18 pm

Mungo Carstairs

Needs proper Javadoc

Needs proper Javadoc

11:37 am

Mungo Carstairs

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide...

Files added to doc folder: are this intended as working documents, or publishable documentation? Bearing in mind that that are findable on the web and a user might reasonably expect them to provide documentation.
e.g. http://source.jalview.org/gitweb/?p=jalview.git;a=blob;f=doc/JalviewJS-startupParams.md;h=9ff33529b2dbc2da34d2a573ccf5d042194fbb0d;hb=refs/heads/Jalview-JS/develop

Thursday 25 Jun 2020
2:16 pm

Mungo Carstairs

Due to the number of changes this is likely to be a 'best efforts' review.

Due to the number of changes this is likely to be a 'best efforts' review.

2:14 pm

Mungo Carstairs

Commits to JS-develop from 2nd to 25th June 2020
Commits to JS-develop from 2nd to 25th June 2020
Wednesday 03 Jun 2020
10:30 pm

Bob Hanson

adds link for __j2sflags.htm to template.html

Options
    • -1
    • +1
    ./template.html
  2. … 1 more file in changeset.
Friday 11 Oct 2019
5:23 pm

Ben Soares

JAL-3210 Just about working transpilation. Some work needed for new Java 11 classes

Options
    • -0
    • +32
    ./template.html
  2. … 5 more files in changeset.