Activity jalview/

3:57 pm

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no sma...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

2:21 pm

Mungo Carstairs

More
Re: CR-JAL-245
commented on review

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

2:17 pm

Mungo Carstairs

More
Re: CR-JAL-245
commented on review

It would be good to add Javadoc to this method

2:14 pm

Mungo Carstairs

More
Re: CR-JAL-245
commented on review

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

4:45 pm

Jim Procter

More
CR-JAL-246
Closed

4:43 pm

Jim Procter

More
CR-JAL-246
started review

JAL-3818 process Jmol callbacks in AWT thread

5:06 pm

Mungo Carstairs

Or can it be compiled to Java 8 bytecode?

3:00 pm

Mungo Carstairs

More
Re: CR-JAL-245
commented on review

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly). Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatibl...

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly).
Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatible syntax).

2:27 pm

Mungo Carstairs

More
Re: CR-JAL-245
commented on review

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

2:26 pm

Mungo Carstairs

More
Re: CR-JAL-245
commented on review

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

2:17 pm

Mungo Carstairs

More
Re: CR-JAL-245
commented on review

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

12:29 pm

Mungo Carstairs

More
CR-JAL-245
started review

JAL-3809: Edit web service parameters dialog does not work in jalviewjs

9:30 pm

Ben Soares

More
650bca3
changed 2 files
Jalview-JS/develop, alpha/JAL-3066_Jalview_212_slivka-integration and 4 more

JAL-3789 Use j2s.config.altfileproperty in .j2s for alternative temporary build/jalviewjs/config/j2s settings file when running a headless build in gradle

- -4
- +37
/build.gradle
- History
- Source
- Diff
/build.gradle
- -1
- +14
/gradle.properties
- History
- Source
- Diff
/gradle.properties

9:28 pm

Ben Soares

More
7b2a742
changed 39 files
Jalview-JS/develop, alpha/JAL-3066_Jalview_212_slivka-integration and 4 more

JAL-3789 New swingjs for Java2Script 3.2.10 with j2s.config.altfileproperty

- -8
- +0
/swingjs/README.txt
- History
- Source
- Diff
/swingjs/README.txt
- binary
/swingjs/SwingJS-site.zip
- History
- Source
- Diff
/swingjs/SwingJS-site.zip
- binary
/swingjs/net.sf.j2s.core-j11.jar
- History
- Source
- Diff
/swingjs/net.sf.j2s.core-j11.jar
- binary
/swingjs/net.sf.j2s.core.jar
- History
- Source
- Diff
/swingjs/net.sf.j2s.core.jar
- -1
- +1
/swingjs/timestamp
- History
- Source
- Diff
/swingjs/timestamp
- -0
- +10
/swingjs/ver/3.2.10-j11/DEV_NOTES.txt
- History
- Source
/swingjs/ver/3.2.10-j11/DEV_NOTES.txt
- binary
/swingjs/ver/3.2.10-j11/SwingJS-site.zip
- History
- Source
/swingjs/ver/3.2.10-j11/SwingJS-site.zip
- -0
- +412
/swingjs/ver/3.2.10-j11/_j2sclasslist.txt
- History
- Source
/swingjs/ver/3.2.10-j11/_j2sclasslist.txt
- -0
- +1541
/swingjs/ver/3.2.10-j11/differences.txt
- History
- Source
/swingjs/ver/3.2.10-j11/differences.txt
- binary
/swingjs/ver/3.2.10-j11/net.sf.j2s.core-j11.jar
- History
- Source
/swingjs/ver/.../net.sf.j2s.core-j11.jar
- -0
- +1
/swingjs/ver/3.2.10-j11/timestamp
- History
- Source
/swingjs/ver/3.2.10-j11/timestamp
- -0
- +10
/swingjs/ver/3.2.10/DEV_NOTES.txt
- History
- Source
/swingjs/ver/3.2.10/DEV_NOTES.txt
- binary
/swingjs/ver/3.2.10/SwingJS-site.zip
- History
- Source
/swingjs/ver/3.2.10/SwingJS-site.zip
- -0
- +412
/swingjs/ver/3.2.10/_j2sclasslist.txt
- History
- Source
/swingjs/ver/3.2.10/_j2sclasslist.txt
- -0
- +1541
/swingjs/ver/3.2.10/differences.txt
- History
- Source
/swingjs/ver/3.2.10/differences.txt
… 24 more files in changeset.

4:27 pm

Jim Procter

More
54f6fe3
changed 0 files
Jalview-JS/develop, alpha/JAL-3066_Jalview_212_slivka-integration and 5 more

Merge branch 'Jalview-JS/develop_j2s_v3_2_9_j11' into Jalview-JS/develop

5:50 pm

Jim Procter

More
0aa2894
changed 15 files
Jalview-JS/develop, Jalview-JS/develop_j2s_v3_2_9_j11 and 6 more

JAL-3223 - update swingjs to 3.2.9-j11

- binary
/swingjs/SwingJS-site.zip
- History
- Source
- Diff
/swingjs/SwingJS-site.zip
- -0
- +61
/swingjs/differences.txt
- History
- Source
- Diff
/swingjs/differences.txt
- binary
/swingjs/net.sf.j2s.core-j11.jar
- History
- Source
- Diff
/swingjs/net.sf.j2s.core-j11.jar
- binary
/swingjs/net.sf.j2s.core.jar
- History
- Source
- Diff
/swingjs/net.sf.j2s.core.jar
- -1
- +1
/swingjs/timestamp
- History
- Source
- Diff
/swingjs/timestamp
- binary
/swingjs/ver/3.2.7/SwingJS-site.zip
- History
- Source
- Diff
/swingjs/ver/3.2.7/SwingJS-site.zip
- binary
/swingjs/ver/3.2.8/SwingJS-site.zip
- History
- Source
- Diff
/swingjs/ver/3.2.8/SwingJS-site.zip
- binary
/swingjs/ver/3.2.9-j11/SwingJS-site.zip
- History
- Source
- Diff
/swingjs/ver/3.2.9-j11/SwingJS-site.zip
- -0
- +4
/swingjs/ver/3.2.9-j11/differences.txt
- History
- Source
- Diff
/swingjs/ver/3.2.9-j11/differences.txt
- binary
/swingjs/ver/3.2.9-j11/net.sf.j2s.core-j11.jar
- History
- Source
- Diff
/swingjs/ver/.../net.sf.j2s.core-j11.jar
- -1
- +1
/swingjs/ver/3.2.9-j11/timestamp
- History
- Source
- Diff
/swingjs/ver/3.2.9-j11/timestamp
- binary
/swingjs/ver/3.2.9/SwingJS-site.zip
- History
- Source
- Diff
/swingjs/ver/3.2.9/SwingJS-site.zip
- -0
- +61
/swingjs/ver/3.2.9/differences.txt
- History
- Source
- Diff
/swingjs/ver/3.2.9/differences.txt
- binary
/swingjs/ver/3.2.9/net.sf.j2s.core.jar
- History
- Source
- Diff
/swingjs/ver/3.2.9/net.sf.j2s.core.jar
- -1
- +1
/swingjs/ver/3.2.9/timestamp
- History
- Source
- Diff
/swingjs/ver/3.2.9/timestamp

5:35 pm

Ben Soares

More
Re: CR-JAL-244
replied to Jim Procter

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

5:31 pm

Ben Soares

More
Re: CR-JAL-244
commented on review

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

5:56 pm

Jim Procter

More
Re: CR-JAL-244
commented on review

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

5:53 pm

Jim Procter

More
Re: CR-JAL-244
commented on review

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

5:20 pm