jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I've now put in a warn with the e.getMessage(), but I've left in a debug with the full stacktrace. This catch block is a little odd in that it's used as programmatic flow for non 200 HTTP responses...

I've now put in a warn with the e.getMessage(), but I've left in a debug with the full stacktrace.
This catch block is a little odd in that it's used as programmatic flow for non 200 HTTP responses. I notice that the new API server is sending back a 400 for bad input (including for non-existent query fields and wrong types for non-string query fields), which is invoking the warning triangle which puts the HTTP error message into the tooltip so this block is now getting more use!

The reason for wanting a full stacktrace in debug mode is that both the API and the changed client are new, so any errors in the next few months will be more quickly diagnosed if we can allow the user to easily obtain a stacktrace of the exception.

after trying it out I think the old behaviour is better, unless 1) there's a really clear message in the UI explaining that now the field has changed, the search needs to be executed again 2) a con...

after trying it out I think the old behaviour is better, unless 1) there's a really clear message in the UI explaining that now the field has changed, the search needs to be executed again 2) a convenient [search] button is shown so one doesn't have to click into the query field and press enter to trigger the search again.

should be Console.warn

should be Console.warn

Need to add logic that either 1) modifies config if an existing value of UNIPROT_DOMAIN is found that is legacy.uniprot.org or 2) uses UNIPROT_2022_DOMAIN as a config value so old versions of Jalvi...

Need to add logic that either 1) modifies config if an existing value of UNIPROT_DOMAIN is found that is legacy.uniprot.org or 2) uses UNIPROT_2022_DOMAIN as a config value so old versions of Jalview still work (up until legacy.uniprot.org goes away).

shouldn't this be a warn ?

shouldn't this be a warn ?

this comment block should really be after the imports ?

this comment block should really be after the imports ?

makes sense. I do wonder if there needs to be some indication that any results currently shown are stale, however ?

makes sense. I do wonder if there needs to be some indication that any results currently shown are stale, however ?

JAL-4036: Jalview 2.11.2.2 and earlier no longer compatible with Uniprot REST API
JAL-4036: Jalview 2.11.2.2 and earlier no longer compatible with Uniprot REST API
JAL-3066 update classlist for jalviewjs

    • -44
    • +200
    /utils/jalviewjs/classlists/jalview.txt
make AlignFrame the parent of FeatureEditor dialog, and have parent Component request focus after...
make AlignFrame the parent of FeatureEditor dialog, and have parent Component request focus after...
JAL-3975 forced re-focus to alignframe after Create Sequence Feature dialog.
JAL-3975 forced re-focus to alignframe after Create Sequence Feature dialog.
Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
That looks good. I was almost going to do something similar (I was thinking jalview.log.Log, but jalview.bin.Console is just as good) so happy with this!

That looks good. I was almost going to do something similar (I was thinking jalview.log.Log, but jalview.bin.Console is just as good) so happy with this!

Added those in. I'm still converting to String with getCanonicalName in the getLogger(Class ...) method because, e.g. JLogger jlogger1 = JLogger.getLogger(Jalview.class); JLogger jlogger2 = JLogger...

Added those in. I'm still converting to String with getCanonicalName in the getLogger(Class ...) method because, e.g.
JLogger jlogger1 = JLogger.getLogger(Jalview.class);
JLogger jlogger2 = JLogger.getLogger("jalview.bin.Jalview");
should really return an existing logger in the registry if it exists, and the String name is the registry key.

I was thinking that JLogger did this comparison anyway, but I've followed it through and it didn't. So I've added if (loglevel.compareTo(this.level) < 0) { return false; } to JLogger.println so t...

I was thinking that JLogger did this comparison anyway, but I've followed it through and it didn't. So I've added

if (loglevel.compareTo(this.level) < 0) { return false; }

to JLogger.println so that a comparison is made between the (enums) of JLogger.level and the message LogLevel, and if it's not going to be logged then it doesn't call the actual logger at all (in this case Log4j, so the log4j object is never even touched [even with logger.isDebugEnabled() because the answer should be no]).
This now applies to all log calls.
The check whether Cache.log != null is equivalent to Cache.log.loggerExists() which already happens within JLoggerLog4j.
There is admittedly the wrapper of the JLogger getting brought to forefront of memory, but that's presumably smaller than the old Cache.log which was a Log4j.Logger object.

AWESOME JOB !!!! one tiny niggle I had was that Cache.debug/Cache.error doesn't read nicely, so I've abstracted the logging stuff even farther to a new jalview.bin.Console class: see https://source...

AWESOME JOB !!!! one tiny niggle I had was that Cache.debug/Cache.error doesn't read nicely, so I've abstracted the logging stuff even farther to a new jalview.bin.Console class: see https://source.jalview.org/crucible/changelog/~br=update%402fJAL-3949_jalview_bin_Console_to_cure_sanity_even_more/jalview/

the reason for conditionals is that Java won't perform the string append operation if logLevel>debug. It saves a minor amount of processing time which is important for code that is executed lots.

the reason for conditionals is that Java won't perform the string append operation if logLevel>debug. It saves a minor amount of processing time which is important for code that is executed lots.

You could have .getLogger(Class ..) rather than having to call getCanonicalName ?

You could have .getLogger(Class ..) rather than having to call getCanonicalName ?

JAL-3949 An attempt at converting to Log4j 2 -- no output achieved!
JAL-3949 An attempt at converting to Log4j 2 -- no output achieved!
JAL-3553: Create working getdown appbase and jvl file(s) for each old version of Jalview
JAL-3553: Create working getdown appbase and jvl file(s) for each old version of Jalview
I'm abandoning this review for now (see my comments on the issue). For what its worth since this is a string literal you should at least follow convention JALVIEW_LOGGER rather than a generic 'LOGG...

I'm abandoning this review for now (see my comments on the issue). For what its worth since this is a string literal you should at least follow convention JALVIEW_LOGGER rather than a generic 'LOGGER_NAME'. The code for routing logged content from other loggers should probably be a method on Cache... or even better, separate all this out into the jalview.util.Log4j class so Cache doesn't get polluted with log configuration cruft.