jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-3829 more testing wit tdbeacons data columns and FTSclient

    • -1
    • +4
    /resources/fts/tdbeacons_data_columns.txt
    • -2
    • +7
    /test/jalview/gui/StructureChooserTest.java
JAL-3829 attempt to fix my changes to follow the Jira issue

    • -0
    • +3
    /resources/fts/tdbeacons_data_columns.txt
fixed last commit

Request now parses the whole structures, need to fix the result

TDB.executeRequest fix & test passed

    • -4
    • +4
    /src/jalview/fts/core/FTSRestResponse.java
Added (and passed !)all the FTS tests from test.fts.core

Created 3Dbeacons data_columns.txt Test passed for data columns

    • -0
    • +44
    /resources/fts/tdbeacons_data_columns.txt
    • -0
    • +10
    /src/jalview/fts/core/FTSRestResponse.java
added untracked parsing attempts files

    • -0
    • +1
    /src/jalview/fts/service/threedbeacons/.gitignore
    • -0
    • +2
    /test/jalview/fts/threedbeacons/.gitignore
Adding tests for 3DB, currently 2/4 corrects on PanelTest

    • -0
    • +76
    /test/jalview/fts/threedbeacons/TDBeaconsFTSRestClientTest.java
First commit of 3DB FTS Panel & Restclient

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no sma...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

It would be good to add Javadoc to this method

It would be good to add Javadoc to this method

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

JAL-3818 process Jmol callbacks in AWT thread
JAL-3818 process Jmol callbacks in AWT thread
Or can it be compiled to Java 8 bytecode?

Or can it be compiled to Java 8 bytecode?

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly). Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatibl...

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly).
Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatible syntax).

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3251 On linux set (sun.awt.X11.XToolkit.)awtAppClassName to set the grouped application name in the taskbar

JAL-3521 Changed wording of INSTALLATION in source tarball build_properties

JAL-3521 Adding a build_properties into sourceDist tarball, with INSTALLATION=SourceDist git-commit...

JAL-2422 updated unit test for ChimeraX command change

JAL-2422 a fix and a fudge for two failing ChimeraX commands

Merge branch 'task/JAL-3796_notarization_no_uninstaller' into develop

Merge branch 'task/JAL-3805_Remove_Uninstall_Old_Jalview_application_for_develop_branch' into task/JAL-3796_notarization_no_uninstaller