THIRDPARTYLIBS

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-3933 Updated log4j jars with log4j-2.16.0 and compatibility API log4j-1.2-api-2.16.0. Stripped...
JAL-3933 Updated log4j jars with log4j-2.16.0 and compatibility API log4j-1.2-api-2.16.0. Stripped...
Can remove class Jalview$FeatureFetcher.

Can remove class Jalview$FeatureFetcher.

Were added 2012 commit 3d37b44 "jdas runtime dependencies". All classes in jars are org.springframework.*, no longer referenced in any source code in Jalview. I will remove from classpath and THIRD...

Were added 2012 commit 3d37b44 "jdas runtime dependencies".
All classes in jars are org.springframework.*, no longer referenced in any source code in Jalview.
I will remove from classpath and THIRDPARTYLIBS.

yeah. probably.

yeah. probably.

I tried removing these (Spring jars) and Jalview seemed to function ok. Can they go?

I tried removing these (Spring jars) and Jalview seemed to function ok. Can they go?

jalview.util.DBRefUtils - can remove dasCoordinateSystemsLookup and (unused) isDasCoordinateSystem

jalview.util.DBRefUtils - can remove dasCoordinateSystemsLookup and (unused) isDasCoordinateSystem

could remove above comment

could remove above comment

Run MessageBundleChecker to show 25 entries that can now be removed from Messages(_es).properties.

Run MessageBundleChecker to show 25 entries that can now be removed from Messages(_es).properties.

Also remove GDasSourceBrowser

Also remove GDasSourceBrowser

remove above 3 fields

remove above 3 fields

AlignFrame.build_fetchdbmenu has a branch of code which I think is no longer hit and could be removed? Lines 5115 - 5243 (case otherdb.size() > 1).

AlignFrame.build_fetchdbmenu has a branch of code which I think is no longer hit and could be removed?
Lines 5115 - 5243 (case otherdb.size() > 1).

remove -dasserver line

remove -dasserver line

remove variable

remove variable

remove the above block and methods checkDasArguments, startFeatureFetching.

remove the above block and methods checkDasArguments, startFeatureFetching.

remove DAS constants

remove DAS constants

can remove DAS_REGISTRY_URL and DAS_ACTIVE_SOURCE

can remove DAS_REGISTRY_URL and DAS_ACTIVE_SOURCE

can remove this

can remove this

Are we ok with also removing the capability of hosting a local DAS source with this change?

Are we ok with also removing the capability of hosting a local DAS source with this change?

JAL-3035: Remove dependency on jdas client library
JAL-3035: Remove dependency on jdas client library
The method that begins where the comment is - see context - transferFromDropTarget

The method that begins where the comment is - see context - transferFromDropTarget

nope - it might work with them though (since it didn't work for URL links!)

nope - it might work with them though (since it didn't work for URL links!)

which method ?

which method ?

Same behaviour I would expect, since file drags are covered by existing code in the drag handler, and this code doesn't seem to get called at all. FYI: JAL-510 covers doing sensible things when dr...

Same behaviour I would expect, since file drags are covered by existing code in the drag handler, and this code doesn't seem to get called at all.

FYI: JAL-510 covers doing sensible things when dragging a directory - we don't do anything right now as you noticed.

What happens if you drag a directory to Jalview Desktop? Mac: exception thrown by IdentifyFile / FileParse "FILE IS A DIRECTORY". Windows: ?

What happens if you drag a directory to Jalview Desktop?
Mac: exception thrown by IdentifyFile / FileParse "FILE IS A DIRECTORY".
Windows: ?

Has this been tested for Windows symbolic link files as well as for URLs?

Has this been tested for Windows symbolic link files as well as for URLs?

Would like some Javadoc to describe what this method does (and doesn't?) handle

Would like some Javadoc to describe what this method does (and doesn't?) handle