jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

JAL-3608 cherry pick of 92cb745e7
JAL-3608 cherry pick of 92cb745e7
JAL-3753 ensure correct dependencies for shadowJar task

Merge branch 'develop' into bug/JAL-3753_resources_duplicated_in_jalview_jar

JAL-3577 Removed default JALVIEW_VERSION from gradle.properties. Now being set by build.gradle

JAL-3577 Quick fix adding quotation marks for findProperty("JALVIEW_VERSION")==null...

JAL-3751 only merge strictly contiguous ranges of mappings
JAL-3751 only merge strictly contiguous ranges of mappings
Merge branch 'develop' into bug/JAL-3753_resources_duplicated_in_jalview_jar

JAL-3477 Added 10k leeway to amount of memory reserved for OS test for float rounding errors (needed to fix failing test)

    • -11
    • +19
    /test/jalview/bin/MemorySettingTest.java
JAL-3753 Resources seen in tests and appropriate filters now being used as file opt-in rather than opt-out.

Merge branch 'merge_review/JAL-3490_2_11_2_develop' into develop

JAL-3753 put resources in gradle run and test path

JAL-3753 JAL-3754 first rejig

JAL-3700: Complement sequence correspondence is broken for CDS with shared dataset sequence
JAL-3700: Complement sequence correspondence is broken for CDS with shared dataset sequence
Merge branch 'develop' of https://source.jalview.org/git/jalview into develop

JAL-3718 force re-initialise of getdown.txt file when new getdown.txt downloaded from appbase. getdown jar and version files

    • binary
    /getdown/lib/getdown-launcher-local.jar
JAL-3718 force re-initialise of getdown.txt file when new getdown.txt downloaded from appbase. getdown src files

Merge branch 'feature/JAL-3615gzipXfam' into develop

JAL-3746 bump release version for 2.11.2 series (currently on develop)

JAL-3679 Added externally specified plugins dir to J2sPlugin check

JAL-3679 Added externally specified plugins dir to J2sPlugin check

Merge branch 'develop' of https://source.jalview.org/git/jalview into develop

Decision made in the issue to just check release build_properties.

Decision made in the issue to just check release build_properties.