jalview

Clone Tools

Stats

Commits this week: 65
Total Committers: 72
Last Commit:
Commits this week: 65

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
8 hrs ago

Jim Procter

Wednesday 15 Sep
7:52 am

Jim Procter

Monday 30 Aug
2:44 pm

Jim Procter

Monday 23 Aug
4:52 pm

Jim Procter

patch needed for 2.11.2 - JAL-3518 - catch case when no replies are available

patch needed for 2.11.2 - JAL-3518 - catch case when no replies are available

4:49 pm

Jim Procter

semantics for determining if a PDB file has a SIFTs mapping - could be absorbed into the PDB metadata object

semantics for determining if a PDB file has a SIFTs mapping - could be absorbed into the PDB metadata object

4:48 pm

Jim Procter

magic logic to recognise which structure database provider client to use - PDB or AlphaFold - ensures metadata and annotation rows are propagates

magic logic to recognise which structure database provider client to use - PDB or AlphaFold - ensures metadata and annotation rows are propagates

4:43 pm

Jim Procter

Reviewing the alphafold + contact matrix patch for 2.11.2
Reviewing the alphafold + contact matrix patch for 2.11.2
2:12 pm

Jim Procter

remove debugging printlns

remove debugging printlns

2:12 pm

Jim Procter

aim is normally to avoid creating query-specific data containers on the core query response class

aim is normally to avoid creating query-specific data containers on the core query response class

10:26 am

Jim Procter

? not sure this is correct

? not sure this is correct

10:24 am

Jim Procter

Needs additionally: model_category created sequence_identity uniprot_start uniprot_end resolution coverage qmean_version ? model_version

Needs additionally:
model_category
created
sequence_identity
uniprot_start
uniprot_end
resolution
coverage
qmean_version ?
model_version

10:19 am

Jim Procter

10:18 am

Jim Procter

Evaluate 3D-Beacons dev path based on Arnaud's ERASMUS+ project code
Evaluate 3D-Beacons dev path based on Arnaud's ERASMUS+ project code
Wednesday 11 Aug
9:44 pm

Jim Procter

1:38 pm

Jim Procter

JAL-3851 start a listener with -testlistener and suggest a port with -testlistener_port. wget -S -O...
JAL-3851 start a listener with -testlistener and suggest a port with -testlistener_port. wget -S -O...
Tuesday 06 Jul
5:42 pm

Jim Procter

5:42 pm

Jim Procter

WIP
WIP
Thursday 25 Feb
3:57 pm

Mungo Carstairs

3:56 pm

Mungo Carstairs

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no sma...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

2:21 pm

Mungo Carstairs

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

2:17 pm

Mungo Carstairs

It would be good to add Javadoc to this method

It would be good to add Javadoc to this method

2:14 pm

Mungo Carstairs

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

Wednesday 24 Feb
4:45 pm

Jim Procter

4:43 pm

Jim Procter

JAL-3818 process Jmol callbacks in AWT thread
JAL-3818 process Jmol callbacks in AWT thread
Thursday 11 Feb
5:06 pm

Mungo Carstairs

Or can it be compiled to Java 8 bytecode?

Or can it be compiled to Java 8 bytecode?

3:00 pm

Mungo Carstairs

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly). Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatibl...

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly).
Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatible syntax).

2:27 pm

Mungo Carstairs

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

2:26 pm

Mungo Carstairs

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

2:17 pm

Mungo Carstairs

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

12:29 pm

Mungo Carstairs

JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3809: Edit web service parameters dialog does not work in jalviewjs