jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no sma...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

It would be good to add Javadoc to this method

It would be good to add Javadoc to this method

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

JAL-3818 process Jmol callbacks in AWT thread
JAL-3818 process Jmol callbacks in AWT thread
Or can it be compiled to Java 8 bytecode?

Or can it be compiled to Java 8 bytecode?

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly). Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatibl...

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly).
Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatible syntax).

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3788 synchronize concurrent findColour() and alignmentChanged()

JAL-3280 Fixed the version checking URL formulation (getdown build_properties) for jalviewjs, can also use it for jalviewjs in future

JAL-3783 Reverting to using groovy-all-2.4.12-indy.jar to fix serious problem with Groovy console using shadowJar

    • binary
    /j11lib/groovy-all-2.4.12-indy.jar
    • binary
    /j11lib/groovy-cli-commons-2.5.7.jar
    • binary
    /j11lib/groovy-cli-picocli-2.5.7.jar
    • binary
    /j11lib/groovy-docgenerator-2.5.7.jar
  1. … 12 more files in changeset.
JAL-3628 Test for doubly saved single backup file scheme

    • -23
    • +71
    /test/jalview/io/BackupFilesTest.java
    • -0
    • +112
    /test/jalview/io/testProps_singlefilebackup.jvprops
JAL-3594 Allow setting of getdownappbase and getdowndistdir properties for DEVELOP channel, and change DEVELOP version to be VERSION-dDATE instead of VERSION-develop. dDATE will help users know when Jalview Develop applicaiton updated

JAL-3594 Defintely want SplashScreen to appear in the Desktop window otherwise it might not be closeable

JAL-3594 Changed building.md to describe -PCHANNEL=JALVIEWJS and JALVIEWJS-TEST

JAL-3594 Changed building.md to reflect change of name of channel_properties to channel.props

JAL-3594 Adjustments to allow JalviewJS to use ChannelProperties, and new utils/channels dir for jalviewjs and jalviewjs-release

    • -4
    • +8
    /src/jalview/util/ChannelProperties.java
    • -0
    • +18
    /utils/channels/default/resources/channel.props
    • -0
    • +18
    /utils/channels/develop/resources/channel.props
    • -0
    • +1
    /utils/channels/jalviewjs-release
    • -0
    • +22
    /utils/channels/jalviewjs/channel_gradle.properties
    • binary
    /utils/channels/jalviewjs/images/UoD_banner-28.png
    • binary
    /utils/channels/jalviewjs/images/UoD_banner-32.png
    • binary
    /utils/channels/jalviewjs/images/barton_group-30.png
    • binary
    /utils/channels/jalviewjs/images/barton_group-512.png
    • binary
    /utils/channels/jalviewjs/images/barton_group-62.png
    • binary
    /utils/channels/jalviewjs/images/barton_group-white-512.png
  1. … 36 more files in changeset.
JAL-3775 JAL-3633 Make java.net.Authenticator code conditional on not being JalviewJS

    • -39
    • +50
    /src/jalview/jbgui/GPreferences.java
Merge branch 'task/JAL-3594_updated--CHANNEL_cosmetics' into develop

JAL-3594 Better Jalview Develop banner

JAL-3594 Documentation added to building.md for using the utils/channels/... folders

Merge branch 'task/JAL-3594_updated--CHANNEL_cosmetics' into develop

Merge branch 'merge/develop_and_rebase_squashed_merge_JAL-3628+JAL-3608+JAL-3609+JAL-3541+Release_2_11_1_Branch' into develop

JAL-3594 Improved About banners for develop and test-release

    • binary
    /utils/channels/develop/images/jalview_develop_banner.xcf
JAL-3594 Images for splash screen

    • binary
    /resources/default_images/UoD_banner-28.png
    • binary
    /resources/default_images/UoD_banner-30.png
    • binary
    /resources/default_images/UoD_banner-32.png
    • binary
    /resources/default_images/UoD_banner.png
    • binary
    /resources/default_images/barton_group-28.png
    • binary
    /resources/default_images/barton_group-30.png
    • binary
    /resources/default_images/barton_group-32.png
    • -2
    • +31
    /src/jalview/util/ChannelProperties.java
    • binary
    /utils/channels/default/images/UoD_banner-28.png
    • binary
    /utils/channels/default/images/UoD_banner-30.png
    • binary
    /utils/channels/default/images/UoD_banner-32.png
    • binary
    /utils/channels/default/images/UoD_banner-65.png
  1. … 51 more files in changeset.