jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
WIP
WIP
This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no sma...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

It would be good to add Javadoc to this method

It would be good to add Javadoc to this method

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

JAL-3818 process Jmol callbacks in AWT thread
JAL-3818 process Jmol callbacks in AWT thread
Merge branch 'bug/JAL-3810_annotation_ws_stopping_abruptly' into bug/JAL-3809_ws_params_dialog_fix

Or can it be compiled to Java 8 bytecode?

Or can it be compiled to Java 8 bytecode?

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly). Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatibl...

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly).
Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatible syntax).

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3810 - Add trace method to javascript implementation of Logger

    • -15
    • +25
    /src/jalview/javascript/log4j/Logger.java
JAL-3810 - Replace log.trace() calls with log.debug()

JAL-3809 - Fixed param edit dialog for jalviewjs.

Edit settings dialog now works asynchronously.

Annotation services still do not add annotations to the sequences.

    • -39
    • +48
    /src/jalview/gui/AlignFrame.java
    • -71
    • +35
    /src/jalview/gui/WsJobParameters.java
    • -36
    • +35
    /src/jalview/ws/jws2/MsaWSClient.java
JAL-3690 Introduce AlignCalcManager2 tests.

    • -0
    • +7
    /src/jalview/api/AlignCalcManagerI2.java
    • -0
    • +377
    /test/jalview/workers/AlignCaclManager2Test.java
Merge branch 'Jalview-JS/develop' into feature/JAL-3690_callback-based-web-services

JAL-3690 AlignCalcManager - add full support for oneshot workers

    • -87
    • +124
    /src/jalview/workers/AlignCalcManager2.java
JAL-3690 AACon ws menu entry fix.

JAL-3690 Allow unregistered workers to be run with CalcManager.

JAL-3690 Fix typo in enum name in slivka client.

    • binary
    /utils/jalviewjs/libjs/slivka-client-site.zip
Merge remote-tracking branch 'origin/merge/Jalview-JS/develop_feature/JAL-3690_callback-based-web-services' into feature/JAL-3690_callback-based-web-services

JAL-3690 Fixed slivka wsmenu categories.

JAL-3789 Use j2s.config.altfileproperty in .j2s for alternative temporary build/jalviewjs/config/j2s settings file when running a headless build in gradle

JAL-3789 New swingjs for Java2Script 3.2.10 with j2s.config.altfileproperty

    • -0
    • +10
    /swingjs/ver/3.2.10-j11/DEV_NOTES.txt
    • binary
    /swingjs/ver/3.2.10-j11/SwingJS-site.zip
    • -0
    • +412
    /swingjs/ver/3.2.10-j11/_j2sclasslist.txt
    • -0
    • +1541
    /swingjs/ver/3.2.10-j11/differences.txt
    • binary
    /swingjs/ver/3.2.10-j11/net.sf.j2s.core-j11.jar
    • -0
    • +1
    /swingjs/ver/3.2.10-j11/timestamp
    • -0
    • +10
    /swingjs/ver/3.2.10/DEV_NOTES.txt
    • binary
    /swingjs/ver/3.2.10/SwingJS-site.zip
    • -0
    • +412
    /swingjs/ver/3.2.10/_j2sclasslist.txt
    • -0
    • +1541
    /swingjs/ver/3.2.10/differences.txt
  1. … 24 more files in changeset.
JAL-3690 recoded AWSThread to use javax.swing.Timer (see https://github.com/BobHanson/java2script/issues/195#issuecomment-747695834 )- web service submission works, but doesn’t seem to be happening as a background task.