build.gradle

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-3553: Create working getdown appbase and jvl file(s) for each old version of Jalview
JAL-3553: Create working getdown appbase and jvl file(s) for each old version of Jalview
Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

JAL-3608 cherry pick of 92cb745e7
JAL-3608 cherry pick of 92cb745e7
Decision made in the issue to just check release build_properties.

Decision made in the issue to just check release build_properties.

I'll add a Test. Perhaps this stems from me misunderstanding a comment in the issue: "We should provide a way to find out what the latest version available from a channel is. I suggest we have a b...

I'll add a Test.

Perhaps this stems from me misunderstanding a comment in the issue: "We should provide a way to find out what the latest version available from a channel is. I suggest we have a build details URL for each channel".
For non-Release/Test channel versions the "remote" build_properties will be a local file://.../getdown/website/11/alt/build_properties (which works if you're on the machine you built it on).
For Release/Test channel versions, the remote build_properties will be the most recent one available in https://www.jalview.org/getdown/release/11/release/build_properties (or test/1.8/alt etc). It is true that if this is the case then getdown SHOULD have already updated the jalview.jar. This is fine, and you would expect nothing to be reported anyway.
If you're using the shadowJar or an otherwise non-updatable version of Jalview or for whatever reason getdown has not auto-updated then you will get the message saying what the most recent version (in your channel) is. [This is perhaps the main part of the target audience for this message now???]
If we just want to check the current release version, this simplifies things quite a lot and I don't mind making that change at all (it means we don't have to pass any properties in to jalview to suggest a different appbase etc).

I can only think a bad copy and paste but why I did that I don't know (possibly I leant on "p" by accident after a "yy"? I need to be careful about my copy and pastes.) I'll remove.

I can only think a bad copy and paste but why I did that I don't know (possibly I leant on "p" by accident after a "yy"? I need to be careful about my copy and pastes.) I'll remove.

Yes this should be removed. Cache.log.debug doesn't work (NullPointer) because (I think) log hasn't been initialised yet. I thought this System.out had been there before, but it wasn't so I'll remo...

Yes this should be removed. Cache.log.debug doesn't work (NullPointer) because (I think) log hasn't been initialised yet. I thought this System.out had been there before, but it wasn't so I'll remove it!

Best to have tests covering these methods. The original idea of the versionChecker is to compare the latest version in the Jalview release channel to what the user is running. Maybe I'm missing s...

Best to have tests covering these methods.

The original idea of the versionChecker is to compare the latest version in the Jalview release channel to what the user is running.

Maybe I'm missing something, but If the versionChecker defaults to the getdown channel that it was launched from, it isn't going to be doing what it was originally intended ?

Why reading twice ?

Why reading twice ?

this should be a debug statement ? Seeing 'LATEST_VERSION=' on stdout seems a bit strange, also.

this should be a debug statement ? Seeing 'LATEST_VERSION=' on stdout seems a bit strange, also.

JAL-3280 Pass appbase and appdir from getdown to jalvew. Check appbase (defaults to release appbase)...
JAL-3280 Pass appbase and appdir from getdown to jalvew. Check appbase (defaults to release appbase)...
Merge branch 'task/JAL-3608_property_set_laf_and_tests' into develop

  1. … 2 more files in changeset.
Resolutions to this review are in task/JAL-3608_property_set_laf_and_tests_from_Release_2_11_1_Branch and will be migrated to task/JAL-3608_property_set_laf_and_tests soon...

Resolutions to this review are in

task/JAL-3608_property_set_laf_and_tests_from_Release_2_11_1_Branch

and will be migrated to task/JAL-3608_property_set_laf_and_tests soon...

Yes that's much nicer

Yes that's much nicer

Terrible copy and paste! fixed

Terrible copy and paste! fixed

Agreed, done.

Agreed, done.

Eclipse installed for the umpteenth time not set up properly... better now https://source.jalview.org/crucible/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Eclipse installed for the umpteenth time not set up properly... better now

Will we need isNoJSLinux I wonder?

Will we need isNoJSLinux I wonder?

or use equalsIgnoreCase()

or use equalsIgnoreCase()

Use Cache.log.error() for logging (throughout)

Use Cache.log.error() for logging (throughout)

Test for if (!lafSet) is missing here - also metal, nimbus, quaqua, vaqua

Test for if (!lafSet) is missing here - also metal, nimbus, quaqua, vaqua