jalview

getdown

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Mar
9:26 am

Ben Soares

9:26 am

Ben Soares

Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

Wednesday 02 Mar
12:20 pm

Jim Procter

JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
Thursday 10 Feb
12:12 pm

Jim Procter

Friday 04 Dec 2020
5:35 pm

Ben Soares

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

5:31 pm

Ben Soares

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

Wednesday 02 Dec 2020
5:56 pm

Jim Procter

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

5:53 pm

Jim Procter

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

5:20 pm

Jim Procter

JAL-3608 cherry pick of 92cb745e7
JAL-3608 cherry pick of 92cb745e7
Thursday 02 Apr 2020
2:55 pm

Ben Soares

JAL-3572 Added getdown Implementation-Version to getdown jars META-INF/MANIFEST.MF

Options
    • -0
    • +1
    ./lib/FJVL_VERSION
    • -0
    • +1
    ./lib/JVL_VERSION
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
    • -1
    • +1
    ./src/getdown/ant/pom.xml
    • -1
    • +15
    ./src/getdown/core/pom.xml
    • -1
    • +2
    ./src/getdown/launcher/pom.xml
    • -1
    • +3
    ./src/getdown/mvn_cmd
    • -1
    • +1
    ./src/getdown/pom.xml
  11. … 2 more files in changeset.
Friday 06 Mar 2020
3:08 pm

Ben Soares

JAL-3394 getdown jar files had not been re-compiled

Options
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
  4. … 2 more files in changeset.
Wednesday 19 Feb 2020
3:22 pm

Jim Procter

(Notes for self) - Ben verified on linux, OSX, Windows. Need to check there are docs and logging to indicate that the hard limit is reached, so if people want to adjust the limit they can !

(Notes for self) - Ben verified on linux, OSX, Windows.
Need to check there are docs and logging to indicate that the hard limit is reached, so if people want to adjust the limit they can !

3:20 pm

Jim Procter

JAL-3477 New sensible default decisions on memory, and new jvmmemmax setting for setting absolute...
JAL-3477 New sensible default decisions on memory, and new jvmmemmax setting for setting absolute...
3:19 pm

Jim Procter

9:05 am

Ben Soares

JAL-3449 ensuring latest getdown jar files after merge

Options
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
  4. … 2 more files in changeset.
Monday 17 Feb 2020
2:49 pm

Ben Soares

JAL-3252 tgz unpacking no longer needed by getdown. Unfinished code and dependency on apache-commons-compress removed. Documentation mentioning common-compress updated.

Options
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
    • -1
    • +1
    ./src/getdown/ant/pom.xml
    • -1
    • +1
    ./src/getdown/core/pom.xml
    • -1
    • +1
    ./src/getdown/core/src/main/java/com/threerings/getdown/data/Application.java
    • -22
    • +3
    ./src/getdown/core/src/main/java/com/threerings/getdown/data/Resource.java
    • -74
    • +0
    ./src/getdown/core/src/main/java/com/threerings/getdown/util/FileUtil.java
    • -1
    • +1
    ./src/getdown/launcher/pom.xml
    • binary
    ./src/getdown/lib/commons-compress-1.18.jar
    • -1
    • +1
    ./src/getdown/mvn_cmd
    • -10
    • +5
    ./src/getdown/pom.xml
  13. … 7 more files in changeset.
Friday 10 Jan 2020
12:41 pm

Ben Soares

JAL-3477 getdown jars. This commit can be left out if it conflicts.

Options
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
  4. … 2 more files in changeset.
12:40 pm

Ben Soares

JAL-3477 updated getdown's jalview.bin.MemorySetting

Options
    • -3
    • +2
    ./src/getdown/core/src/main/java/jalview/bin/MemorySetting.java
Thursday 09 Jan 2020
4:56 pm

Ben Soares

JAL-3477 getdown jars. This commit can be left out if it conflicts.

Options
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
  4. … 2 more files in changeset.
4:55 pm

Ben Soares

JAL-3477 Newer jalview.bin.MemorySetting jalview.bin.GetMemory source files for getdown

Options
    • -1
    • +1
    ./src/getdown/core/src/main/java/jalview/bin/GetMemory.java
    • -38
    • +40
    ./src/getdown/core/src/main/java/jalview/bin/MemorySetting.java
4:29 pm

Ben Soares

Changing "... 8GB ..." to "... " + (noMemMaxHeapSizeDefault + 536870912) / 1073741824 + "GB ..." which does the trick! This should turn out to be the nearest integer number of GB being set (calcula...

Changing
"... 8GB ..."
to
"... " + (noMemMaxHeapSizeDefault + 536870912) / 1073741824 + "GB ..."
which does the trick!
This should turn out to be the nearest integer number of GB being set (calculated as (long)((mem+0.5GB)/1GB) ).

Just got to the comment about setting constant GIGABYTE. That makes much more sense and is much more readable

4:12 pm

Ben Soares

JAL-3477 getdown jars. This commit can be left out if it conflicts.

Options
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
  4. … 2 more files in changeset.
4:11 pm

Ben Soares

JAL-3477 New jalview.bin.MemorySetting jalview.bin.GetMemory source files for getdown

Options
    • -0
    • +52
    ./src/getdown/core/src/main/java/jalview/bin/GetMemory.java
    • -32
    • +0
    ./src/getdown/core/src/main/java/jalview/bin/MemoryPercent.java
    • -53
    • +112
    ./src/getdown/core/src/main/java/jalview/bin/MemorySetting.java
Wednesday 08 Jan 2020
4:45 pm

Ben Soares

I agree the getdown (adapted) source that we use is not in the right place. Currently all getdown resources and built components get put under ./getdown/ to keep it a separate entity from Jalview. ...

I agree the getdown (adapted) source that we use is not in the right place. Currently all getdown resources and built components get put under ./getdown/ to keep it a separate entity from Jalview. I've created an issue detailing where the different getdown folders should be moved to (including putting ./getdown/src under ./src), but the build process for getdown is still necessarily separate from the Jalview build process. See issue JAL-3500.

Monday 30 Dec 2019
1:55 am

Ben Soares

JAL-3394 catch a null pointer exception, when URI not parsed but not malformed ???

Options
    • binary
    ./lib/getdown-core.jar
    • binary
    ./lib/getdown-launcher-local.jar
    • binary
    ./lib/getdown-launcher.jar
    • -36
    • +39
    ./src/getdown/core/src/main/java/com/threerings/getdown/data/Application.java
  5. … 2 more files in changeset.
Friday 20 Dec 2019
2:35 pm

Mungo Carstairs

A public class with no public members doesn't quite make sense. Should maybe have default (package) visiblity (or be an inner class of MemorySetting)? In fact, can't this just be another method in ...

A public class with no public members doesn't quite make sense. Should maybe have default (package) visiblity (or be an inner class of MemorySetting)?
In fact, can't this just be another method in MemorySetting?

2:31 pm

Mungo Carstairs

Method javadoc please?

Method javadoc please?

1:45 pm

Mungo Carstairs

Should the getdown code be in a jar file? And include MemorySettings? cf comment https://issues.jalview.org/browse/?focusedCommentId=21949&page=com.atlassian.jira.plugin.system.issuetabpanels:comme...

Should the getdown code be in a jar file? And include MemorySettings?
cf comment https://issues.jalview.org/browse/?focusedCommentId=21949&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3278comment-21949

Not having getdown/data/Application on the project classpath confused me a bit (calls from Application to MemorySettings don't show up).

1:43 pm

Mungo Carstairs

do this in getMemorySetting() instead ...cancel that...I see this is called from getdown/data/Application and either or both property might be null.

do this in getMemorySetting() instead
...cancel that...I see this is called from getdown/data/Application and either or both property might be null.

12:06 pm

Mungo Carstairs

Declare type as List<String> is preferred style (refer to types by their interfaces wherever possible)

Declare type as List<String> is preferred style (refer to types by their interfaces wherever possible)