jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
WIP
WIP
This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no sma...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

It would be good to add Javadoc to this method

It would be good to add Javadoc to this method

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

JAL-3818 process Jmol callbacks in AWT thread
JAL-3818 process Jmol callbacks in AWT thread
Or can it be compiled to Java 8 bytecode?

Or can it be compiled to Java 8 bytecode?

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly). Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatibl...

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly).
Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatible syntax).

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-1713 restore project with no Overview, regardless of Preferences

JAL-1713 close and replace auto-opened Overview with restored Overview

    • -0
    • +12
    /src/jalview/gui/AlignmentPanel.java
    • -153
    • +166
    /src/jalview/project/Jalview2XML.java
JAL-1713 unit test for save/restore Overview in project

JAL-1713 renamed method to OverviewPanel.get/setFrameBounds()

JAL-1713 JAL-3119 JAL-3785 refactored get/set Overview bounds and title

    • -35
    • +15
    /src/jalview/gui/AlignFrame.java
    • -39
    • +65
    /src/jalview/gui/AlignmentPanel.java
    • -38
    • +91
    /src/jalview/gui/OverviewPanel.java
    • -1
    • +41
    /test/jalview/gui/AlignmentPanelTest.java
JAL-3785 set full title on automatically opened Overview windows

JAL-1713 fix typo; overview in project with open overview in preferences

JAL-3784 null the right overview reference when it is closed

JAL-1713 read/set OverviewPanel geometry on parent JInternalFrame

    • -11
    • +8
    /src/jalview/project/Jalview2XML.java
JAL-1713 save Overview title in project, don't save Overview on New View

    • -15
    • +34
    /src/jalview/project/Jalview2XML.java
JAL-3119 include view name (if any) in Overview title

JAL-1713 save/restore Overview in project (todo: restore geometry)

    • -0
    • +32
    /src/jalview/project/Jalview2XML.java
JAL-1713 refactorings to allow save/restore Overview to/from project

    • -16
    • +54
    /src/jalview/gui/OverviewCanvas.java
    • -12
    • +21
    /src/jalview/gui/OverviewPanel.java
    • -30
    • +23
    /src/jalview/gui/Preferences.java
    • -45
    • +59
    /src/jalview/renderer/OverviewResColourFinder.java
JAL-1713 schema and JAXB changes to save Overview in project file

JAL-3754 Fixed jar task creating strange dir because of outputs.file()