jalview

Clone Tools

Stats

Commits this week: 0
Total Committers: 73
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 30 Mar
4:23 pm

Jim Procter

4:22 pm

Jim Procter

make AlignFrame the parent of FeatureEditor dialog, and have parent Component request focus after...
make AlignFrame the parent of FeatureEditor dialog, and have parent Component request focus after...
4:20 pm

Jim Procter

JAL-3975 forced re-focus to alignframe after Create Sequence Feature dialog.
JAL-3975 forced re-focus to alignframe after Create Sequence Feature dialog.
Monday 07 Mar
8:03 pm

Jim Procter

Thursday 03 Mar
9:26 am

Ben Soares

9:26 am

Ben Soares

Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

Wednesday 02 Mar
12:20 pm

Jim Procter

JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
Wednesday 16 Feb
12:17 pm

Jim Procter <j.procter@dundee.ac.uk>

Merge branch 'develop' into feature/r2_11_2/JAL-3808_gff2_exonerate

Options
    • -1
    • +3
    /src/jalview/io/gff/ExonerateHelper.java
Tuesday 15 Feb
5:35 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-1761 backbone type parameter for configuring which atoms are used for superposition of structures

Options
    • -6
    • +7
    /src/jalview/ext/jmol/JmolCommands.java
    • -8
    • +13
    /src/jalview/ext/pymol/PymolCommands.java
    • -12
    • +16
    /src/jalview/ext/rbvi/chimera/ChimeraCommands.java
    • -9
    • +13
    /src/jalview/ext/rbvi/chimera/ChimeraXCommands.java
    • -1
    • +1
    /src/jalview/structure/StructureCommandsBase.java
    • -5
    • +5
    /src/jalview/structure/StructureCommandsI.java
    • -2
    • +3
    /src/jalview/structures/models/AAStructureBindingModel.java
    • -12
    • +13
    /test/jalview/ext/jmol/JmolCommandsTest.java
    • -23
    • +24
    /test/jalview/ext/pymol/PymolCommandsTest.java
    • -23
    • +24
    /test/jalview/ext/rbvi/chimera/ChimeraCommandsTest.java
    • -23
    • +25
    /test/jalview/ext/rbvi/chimera/ChimeraXCommandsTest.java
    • -5
    • +6
    /test/jalview/structures/models/AAStructureBindingModelTest.java
4:55 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-1761 need to pass molecule type when generating superposition commands

Options
    • -1
    • +1
    /test/jalview/ext/jmol/JmolCommandsTest.java
    • -1
    • +1
    /test/jalview/ext/rbvi/chimera/ChimeraCommandsTest.java
    • -1
    • +1
    /test/jalview/ext/rbvi/chimera/ChimeraXCommandsTest.java
4:54 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3551 patch test for altloc handling atom spec in superposition code

Options
    • -5
    • +5
    /test/jalview/ext/pymol/PymolCommandsTest.java
4:47 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-1761 need to pass molecule type when generating superposition commands

Options
    • -1
    • +1
    /src/jalview/ext/jmol/JmolCommands.java
    • -1
    • +1
    /src/jalview/ext/pymol/PymolCommands.java
    • -1
    • +1
    /src/jalview/ext/rbvi/chimera/ChimeraCommands.java
    • -1
    • +1
    /src/jalview/ext/rbvi/chimera/ChimeraXCommands.java
    • -1
    • +3
    /src/jalview/structure/StructureCommandsI.java
    • -3
    • +10
    /src/jalview/structures/models/AAStructureBindingModel.java
4:46 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3906 use indicate to highlight current mousedOver residue in Jalview in a Pymol view

Options
    • -13
    • +3
    /src/jalview/gui/PymolBindingModel.java
4:45 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3746 update release date to later in Feb 2022

Options
    • -1
    • +1
    /help/help/html/releases.html
4:44 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3551 pymol documentation

Options
    • -56
    • +62
    /help/help/html/features/pymol.html
Monday 14 Feb
11:02 pm

Jim Procter <j.procter@dundee.ac.uk>

Merge branch 'task/r_2_11_2/JAL-3956_alphaFill_authoritative_IDs' into develop

Options
10:58 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3551

Options
    • -4
    • +5
    /src/jalview/ext/pymol/PymolCommands.java
2:03 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3956 - PDBEntry objects constructed from 3D-Beacons have authoritative IDs overriding any embedded IDs

Options
    • -2
    • +28
    /src/jalview/datamodel/PDBEntry.java
    • -0
    • +1
    /src/jalview/gui/structurechooser/ThreeDBStructureChooserQuerySource.java
    • -1
    • +16
    /test/jalview/datamodel/PDBEntryTest.java
Saturday 12 Feb
11:49 am

Jim Procter <j.procter@dundee.ac.uk>

Merge branch 'update/JAL-3949_jalview_bin_Console_to_cure_sanity_even_more' into develop

Conflicts:

test/jalview/bin/CommandLineOperations.java

Options
    • -3
    • +3
    /test/jalview/bin/CommandLineOperations.java
10:09 am

Ben Soares

JAL-3949 fix testProps path and make line count more accurate

Options
    • -3
    • +3
    /test/jalview/bin/CommandLineOperations.java
    • -0
    • +1
    /test/jalview/bin/testProps.jvprops
Friday 11 Feb
6:52 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3949 increase command line ops test timeout

Options
    • -1
    • +1
    /test/jalview/bin/CommandLineOperations.java
6:44 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3949 ensure Jalview command line ops setup actually quits after SETUP_TIME milliseconds - seems there’s less stderr noise than before !

Options
    • -8
    • +43
    /test/jalview/bin/CommandLineOperations.java
5:27 pm

Jim Procter <j.procter@dundee.ac.uk>

Merge branch 'update/JAL-3949_jalview_bin_Console_to_cure_sanity_even_more' into develop

Options
    • -1
    • +2
    /src/jalview/gui/StructureViewerBase.java
5:09 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3931 fix - escape % symbols after urlencoding

Options
    • -1
    • +1
    /src/jalview/gui/StructureViewerBase.java
4:12 pm

Ben Soares

That looks good. I was almost going to do something similar (I was thinking jalview.log.Log, but jalview.bin.Console is just as good) so happy with this!

That looks good. I was almost going to do something similar (I was thinking jalview.log.Log, but jalview.bin.Console is just as good) so happy with this!

3:49 pm

Ben Soares

Added those in. I'm still converting to String with getCanonicalName in the getLogger(Class ...) method because, e.g. JLogger jlogger1 = JLogger.getLogger(Jalview.class); JLogger jlogger2 = JLogger...

Added those in. I'm still converting to String with getCanonicalName in the getLogger(Class ...) method because, e.g.
JLogger jlogger1 = JLogger.getLogger(Jalview.class);
JLogger jlogger2 = JLogger.getLogger("jalview.bin.Jalview");
should really return an existing logger in the registry if it exists, and the String name is the registry key.

3:43 pm

Ben Soares

Merge branch 'update/JAL-3949_jalview_bin_Console_to_cure_sanity_even_more' of https://source.jalview.org/git/jalview into update/JAL-3949_jalview_bin_Console_to_cure_sanity_even_more

Options
    • -9
    • +9
    /src/jalview/io/vamsas/DatastoreItem.java
    • -2
    • +2
    /src/jalview/log/JLogger.java
3:43 pm

Ben Soares

JLogger loglevel check on whether to call the actual logger or not. New factory methods with Class.

Options
    • -1
    • +1
    /src/jalview/io/vamsas/DatastoreItem.java
    • -1
    • +1
    /src/jalview/io/vamsas/DatastoreRegistry.java
    • -4
    • +19
    /src/jalview/log/JLogger.java
    • -3
    • +12
    /src/jalview/log/JLoggerLog4j.java
3:40 pm

Ben Soares

I was thinking that JLogger did this comparison anyway, but I've followed it through and it didn't. So I've added if (loglevel.compareTo(this.level) < 0) { return false; } to JLogger.println so t...

I was thinking that JLogger did this comparison anyway, but I've followed it through and it didn't. So I've added

if (loglevel.compareTo(this.level) < 0) { return false; }

to JLogger.println so that a comparison is made between the (enums) of JLogger.level and the message LogLevel, and if it's not going to be logged then it doesn't call the actual logger at all (in this case Log4j, so the log4j object is never even touched [even with logger.isDebugEnabled() because the answer should be no]).
This now applies to all log calls.
The check whether Cache.log != null is equivalent to Cache.log.loggerExists() which already happens within JLoggerLog4j.
There is admittedly the wrapper of the JLogger getting brought to forefront of memory, but that's presumably smaller than the old Cache.log which was a Log4j.Logger object.

3:27 pm

Jim Procter <j.procter@dundee.ac.uk>

JAL-3949 - refactor logging from jalview.bin.Cache to jalview.bin.Console

Conflicts:

src/jalview/bin/Jalview.java

Options
    • -2
    • +2
    /src/jalview/analysis/AlignmentUtils.java
    • -6
    • +5
    /src/jalview/analysis/GeneticCodes.java
    • -2
    • +2
    /src/jalview/analysis/PCA.java
    • -260
    • +31
    /src/jalview/bin/Cache.java
    • -0
    • +240
    /src/jalview/bin/Console.java
    • -28
    • +28
    /src/jalview/bin/Jalview.java
    • -2
    • +2
    /src/jalview/ext/ensembl/EnsemblLookup.java
    • -2
    • +2
    /src/jalview/ext/ensembl/EnsemblSeqProxy.java
    • -3
    • +2
    /src/jalview/ext/htsjdk/VCFReader.java
    • -3
    • +3
    /src/jalview/ext/jmol/JalviewJmolBinding.java
    • -10
    • +11
    /src/jalview/ext/pymol/PymolManager.java
    • -7
    • +7
    /src/jalview/ext/rbvi/chimera/JalviewChimeraBinding.java
    • -6
    • +6
    /src/jalview/ext/so/SequenceOntology.java
    • -2
    • +2
    /src/jalview/fts/service/alphafold/AlphafoldRestClient.java
    • -2
    • +2
    /src/jalview/fts/service/threedbeacons/TDBeaconsFTSPanel.java
  16. … 84 more files in changeset.