jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JAL-4034 button looks better also on other OSes with the 0 vertical insets

    • -7
    • +4
    /src/jalview/jbgui/GStructureChooser.java
JAL-4034 add round corners to 3DB confirmation button with icon on a mac

    • -4
    • +14
    /src/jalview/jbgui/GStructureChooser.java
I've now put in a warn with the e.getMessage(), but I've left in a debug with the full stacktrace. This catch block is a little odd in that it's used as programmatic flow for non 200 HTTP responses...

I've now put in a warn with the e.getMessage(), but I've left in a debug with the full stacktrace.
This catch block is a little odd in that it's used as programmatic flow for non 200 HTTP responses. I notice that the new API server is sending back a 400 for bad input (including for non-existent query fields and wrong types for non-string query fields), which is invoking the warning triangle which puts the HTTP error message into the tooltip so this block is now getting more use!

The reason for wanting a full stacktrace in debug mode is that both the API and the changed client are new, so any errors in the next few months will be more quickly diagnosed if we can allow the user to easily obtain a stacktrace of the exception.

after trying it out I think the old behaviour is better, unless 1) there's a really clear message in the UI explaining that now the field has changed, the search needs to be executed again 2) a con...

after trying it out I think the old behaviour is better, unless 1) there's a really clear message in the UI explaining that now the field has changed, the search needs to be executed again 2) a convenient [search] button is shown so one doesn't have to click into the query field and press enter to trigger the search again.

should be Console.warn

should be Console.warn

Need to add logic that either 1) modifies config if an existing value of UNIPROT_DOMAIN is found that is legacy.uniprot.org or 2) uses UNIPROT_2022_DOMAIN as a config value so old versions of Jalvi...

Need to add logic that either 1) modifies config if an existing value of UNIPROT_DOMAIN is found that is legacy.uniprot.org or 2) uses UNIPROT_2022_DOMAIN as a config value so old versions of Jalview still work (up until legacy.uniprot.org goes away).

shouldn't this be a warn ?

shouldn't this be a warn ?

this comment block should really be after the imports ?

this comment block should really be after the imports ?

makes sense. I do wonder if there needs to be some indication that any results currently shown are stale, however ?

makes sense. I do wonder if there needs to be some indication that any results currently shown are stale, however ?

JAL-4036: Jalview 2.11.2.2 and earlier no longer compatible with Uniprot REST API
JAL-4036: Jalview 2.11.2.2 and earlier no longer compatible with Uniprot REST API
JAL-4034 Use the new non-modal JDialog for 3DBeacons uniprot lookup confirmation. Link dialog to GStructureChooser's frame so it can moveToFront. Minor improvement to Search 3DB button appearance

    • -21
    • +21
    /src/jalview/gui/StructureChooser.java
    • -3
    • +16
    /src/jalview/jbgui/GStructureChooser.java
JAL-4034 Allow request for non-modal JDialog, which puts the Runnable action into the button click listener (similar to JalviewJS)

    • -14
    • +137
    /src/jalview/gui/JvOptionPane.java
JAL-4034 change to jalview property name

    • -1
    • +1
    /src/jalview/gui/StructureChooser.java
JAL-4034 showConfirmDialog works for both desktop and jalviewjs

    • -17
    • +2
    /src/jalview/gui/StructureChooser.java
JAL-4034 Non-blocking 3D Beacons query after warning dialog

    • -17
    • +36
    /src/jalview/gui/StructureChooser.java
JAL-4034 allow a jalview_property to set the threshold level

    • -2
    • +5
    /src/jalview/gui/StructureChooser.java
JAL-4034 fix #3 change uniprot ref fetch dialog to a ‘warning’ shown when many ids have to be retrieved

    • -2
    • +10
    /src/jalview/gui/StructureChooser.java
JAL-4034 Fix #2 show an icon and a button to press to initiate search

    • -0
    • +4
    /src/jalview/gui/StructureChooser.java
    • -17
    • +20
    /src/jalview/jbgui/GStructureChooser.java
JAL-4034 fix 1 - reword button

JAL-4012 updated release date and whats new for 2.11.2.3

JAL-4012 tweak release notes wording for legacy.uniprot

Merge branch 'patch/JAL-4036_uniprot_fts_legacy_endpoint' into develop

JAL-4036 JAL-4012 note about Uniprot FTS workaround in search documentation, and update to release notes and what’s new

JAL-4036 use the legacy endpoint (and report the FTS query when debug/trace enabled)

Merge branch 'improvement/JAL-1988+JAL-3416_Java8_macOS_APQHandlers_and_FlatLaF_option' into develop

JAL-1988 Don't put Quit in the File menu if there's a handler for it

Merge branch 'improvement/JAL-1988+JAL-3416_Java8_macOS_APQHandlers_and_FlatLaF_option' into develop

    • -45
    • +63
    /src/jalview/jbgui/APQHandlers.java
JAL-1988 Check for setHandler capability to avoid About and Preferences menu options disappearing into a void

    • -49
    • +69
    /src/jalview/jbgui/APQHandlers.java
JAL-3027 Avoid FlatLAF Desktop class is JalviewJS