jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SequencesInfo which is an individual object is doable, but I feel like it would be just a wrapper around a Map. What additional functionality would SequencesInfo have over a traditional Map? I'm n...

SequencesInfo which is an individual object is doable, but I feel like it would be just a wrapper around a Map. What additional functionality would SequencesInfo have over a traditional Map?

I'm not very familiar with serialization in java, I know there are libraries that can serialize beans to json or xml, but what are your expectations in this case?

one class with a static factory method seems to be better than two classes and an external mutable object.

one class with a static factory method seems to be better than two classes and an external mutable object.

What's wrong with static classes? They are just like regular classes but within other class' namespace. That's non-static inner classes that are special. About factory pattern, I think it would be ...

What's wrong with static classes? They are just like regular classes but within other class' namespace. That's non-static inner classes that are special.
About factory pattern, I think it would be an overkill for a class that is only used by SeqsetUtils' methods.

yes, I see that, but do you really need a nested static class ? in line with my general comments re encapsulating the Map<String,SequenceInfo> further: perhaps it might make sense to simply apply a...

yes, I see that, but do you really need a nested static class ? in line with my general comments re encapsulating the Map<String,SequenceInfo> further: perhaps it might make sense to simply apply a factory pattern rather than have an internal bean that a generic map holds references to ?

(lets not get stuck on this though, the main thing is that the implementation works fine for now, though needs more work in order to save/restore sequenceInfo objects from Jalview project files)

Because it's instantiated in a static context e.g. uniquify and it does not need an instance of SeqsetUtils object to work.

Because it's instantiated in a static context e.g. uniquify and it does not need an instance of SeqsetUtils object to work.

we won't see this messages unless asserts are enabled. Cache.log.warn is perhaps better ?

we won't see this messages unless asserts are enabled. Cache.log.warn is perhaps better ?

it's a reasonable first pass, though stylistically all you've done is transformed a single concrete instance (Hashtable) to a more strongly typed verbose instance (Map<String,SequenceInfo>). Why no...

it's a reasonable first pass, though stylistically all you've done is transformed a single concrete instance (Hashtable) to a more strongly typed verbose instance (Map<String,SequenceInfo>). Why not go further and have a SequencesInfo object that records metadata for one or more sequences ?

There are also other requirements: SequenceInfo sets will need to be persisted for a web services job. You could expand JAL-3899 to incorporate this perhaps - JAL-1786 is the relevant epic for that.

why does this class need to be static ?

why does this class need to be static ?

this should probably be Cache.log.warn(..)

this should probably be Cache.log.warn(..)

JAL-3899 Refactor sequence de/uniquification.
JAL-3899 Refactor sequence de/uniquification.
Merge branch 'develop' into improvement/JAL-3594_BG_and_UoD_logos_added

Merge branch 'features/r2_11_2/JAL-3829_3dbeacons' into develop

JAL-3829 3d beacons logo - misi varadi gave permission to re-use but most likely it is CC-0

    • binary
    /resources/images/3d-beacons-logo-transparent.png
Merge branch 'develop' into improvement/JAL-3594_BG_and_UoD_logos_added

Merge branch 'improvement/JAL-3594_logos_for_jalview_test' into develop

Merge branch 'features/r2_11_2/JAL-3829_3dbeacons' into develop

JAL-3829 fetch 3D beacons now started by clicking button shown above the drop-down filter/manual input combo box.

    • -17
    • +19
    /src/jalview/gui/StructureChooser.java
    • -4
    • +19
    /src/jalview/jbgui/GStructureChooser.java
Merge branch 'develop' into improvement/JAL-3594_logos_for_jalview_test

JAL-3594 New Jalview Test logos and .icns/.ico creation helper script

    • -0
    • +18
    /doc/README-DMG_background_image_creation.md
    • -0
    • +48
    /doc/README-DMG_creation.md
    • -0
    • +50
    /doc/README_convert_PNG_to_ICNS_and_ICO
    • -32
    • +132
    /utils/channels/release/images/jalview_logo.svg
  1. … 15 more files in changeset.
Merge branch 'develop' into features/r2_11_2/JAL-3829_3dbeacons

    • -1
    • +7
    /src/jalview/gui/StructureChooser.java
JAL-3594 Changed logo for Jalview Test

    • -0
    • +170
    /utils/channels/test-release/images/jalview_test-release_logo.svg
  1. … 21 more files in changeset.
JAL-1260 Added .gbk to GenBank extensions. Added GenBank extensions to the installer.

    • -0
    • +39
    /utils/install4j/file_associations_auto-Info_plist.xml
    • -66
    • +156
    /utils/install4j/file_associations_auto-install4j8.xml
Merge branch 'bug/JAL-3885_sequence_fetched_not_displaying_PFAM_Seed' into develop

JAL-3885 Made the database JComboBox have StringPair entries to allow a display value, set to the single item dbname if there's a single item

    • -42
    • +112
    /src/jalview/gui/SequenceFetcher.java
This is waiting for us to define the "language" of edam classifiers that we are going to support. Currently we only define services by what operation they perform but there is plenty of room for fi...

This is waiting for us to define the "language" of edam classifiers that we are going to support. Currently we only define services by what operation they perform but there is plenty of room for fine grained tuning of operations based on other classifiers.

Yes, there are pieces of code that can be reused across multiple if not all other workers. I suppose we can either add component classes that can be used by the workers that need them or we can cre...

Yes, there are pieces of code that can be reused across multiple if not all other workers. I suppose we can either add component classes that can be used by the workers that need them or we can create an abstract base class for all workers with implementations of common methods. The purpose of operation class is to provide metadata and create a worker, so the operation should stay as it is, but the worker needs to be tidied up. I absolutely agree that currently it is too bloated and should be split into smaller pieces but for now I wanted something that just works.
Regarding tuning, the whole point is that now the service is made of operations instead of extending one, so we can create new operations or add extra parameters to the existing operation classes that would alter worker behaviour without touching other parts of the code.

JAL-3884 squish alarming but harmless errors when uniprot doesn’t have a record

    • -11
    • +21
    /src/jalview/ws/dbsources/Uniprot.java
JAL-3881 split on any nonalphanumeric symbol (plus _) to generate putative sequence identifiers with which to query databases

JAL-3829 report when 3d-beacons doesn’t provide any models

    • -1
    • +7
    /src/jalview/gui/StructureChooser.java