jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agreed. I seem to remember (this was a while ago now) that I found isAMacAndNotJS() and thought it might be an important distinction. Sounds like it's just redundant? Can tidy this another time then.

Agree this is just touching on a much bigger task. However... The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview...

Agree this is just touching on a much bigger task.
However...
The reason I /needed/ to do this rather than just /wanted/ to do this is that several of the classes I've been working on (e.g. jalview.bin.Launcher, jalview.bin.HiDPISetting, jalview.bin.MemorySetting) run very early on (especially jalview.bin.Launcher!). This means Cache.log has perhaps not yet been initialised, so a Cache.log.debug doesn't log (unless you count reams of NullPointerExceptions as logging!).

In the case of HiDPISetting and MemorySetting that also get used in Getdown, where there is no jalview.bin.Cache, they currently have to use System.out and System.err [or maybe I could stub jalview.bin.Cache too]. I'd prefer them to use Cache.log when they can so this is an attempt at starting to decouple jalview.bin.Cache from other jalview things so it can be used standalone within Getdown. The main reason for wanting to do that is to have shared code to read the preferences between Jalview and Getdown.

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly u...

I think there are lots of things that could be tidied up (particularly the overloading and additional logging functions via Cache which don't really reduce code at point of use, but are certainly useful in spirit), but now is most definitely not the time to optimise and beautify code.

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS,...

Ben Soares as far as I can see the only thing missing after this branch is merged to develop is this logic. I just did a quick test and it appears 'Platform.isAMac()' returns false under JalviewJS, so probably not a dealbreaker. Do you agree ?

JAL-3608 cherry pick of 92cb745e7
JAL-3608 cherry pick of 92cb745e7
Merge branch 'releases/Release_2_11_1_Branch'

JAL-3766 what’s new and release notes for 2.11.1.3

JAL-3759 fix compilation error for test

    • -1
    • +1
    /test/jalview/analysis/GroupingTest.java
JAL-3766 release notes for JAL-3759

JAL-3759 exclude hidden columns when processing column selection

    • -3
    • +18
    /src/jalview/analysis/Grouping.java
Merge branch 'documentation/JAL-3766_relnotes' into releases/Release_2_11_1_Branch

Merge branch 'patch/JAL-3700_JAL-3748_JAL-3763_for_2_11_1_3' into releases/Release_2_11_1_Branch

JAL-3248 Fixed path typos in building.md/html and corrected shadow jar filename

JAL-3700 mapped sequence group includes short (or all gapped) sequences

    • -13
    • +17
    /src/jalview/util/MappingUtils.java
    • -25
    • +24
    /test/jalview/util/MappingUtilsTest.java
JAL-3725 fix tests for EMBLFlatFile parser when mapping doesn’t include stop codon

    • -7
    • +8
    /test/jalview/io/EmblFlatFileTest.java
JAL-3725 patch EMBL flat file to exclude stop codon from the mapping (for 2.11.1.3 - needs cherry-pick to 2.11.2)

Merge branch 'bug/JAL-3760_protsTreatedAsNucleotides' into releases/Release_2_11_1_Branch

JAL-3248 Added step to create the eclipse files before project import. Noted non-fatal NPEs during build with gradle 6.6+

update test for JAL-3763 redact shared DS sequences for contiguous CDS

JAL-3768 noticed failure of test when run as part of suite via gradle - whilst patching JAL-3700 JAL-3748 JAL-3763 for 2.11.1.3

JAL-3700 JAL-3748 JAL-3763 don’t add stop codon via alignAs if guide peptide doesn’t include C terminus.

    • -2
    • +2
    /src/jalview/analysis/AlignmentUtils.java
JAL-3763 Javadoc, check for null, additional tests

JAL-3763 test coverage for AlignedCodonFrame.markMappedRegion

    • -2
    • +4
    /src/jalview/datamodel/SearchResults.java
    • -26
    • +129
    /test/jalview/datamodel/AlignedCodonFrameTest.java
JAL-3766 release notes for JAL-3611 JAL-3765

Merge branch 'releases/Release_2_11_1_Branch' of http://source.jalview.org/git/jalview into releases/Release_2_11_1_Branch

Merge branch 'bug/JAL-3765_Find_bugs_in_21112' into releases/Release_2_11_1_Branch

JAL-3766 cut new patch release

Merge branch 'releases/Release_2_11_1_Branch'

JAL-3765 fix test

    • -10
    • +13
    /test/jalview/analysis/FinderTest.java