jalview

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
patch needed for 2.11.2 - JAL-3518 - catch case when no replies are available

patch needed for 2.11.2 - JAL-3518 - catch case when no replies are available

semantics for determining if a PDB file has a SIFTs mapping - could be absorbed into the PDB metadata object

semantics for determining if a PDB file has a SIFTs mapping - could be absorbed into the PDB metadata object

magic logic to recognise which structure database provider client to use - PDB or AlphaFold - ensures metadata and annotation rows are propagates

magic logic to recognise which structure database provider client to use - PDB or AlphaFold - ensures metadata and annotation rows are propagates

Reviewing the alphafold + contact matrix patch for 2.11.2
Reviewing the alphafold + contact matrix patch for 2.11.2
remove debugging printlns

remove debugging printlns

aim is normally to avoid creating query-specific data containers on the core query response class

aim is normally to avoid creating query-specific data containers on the core query response class

? not sure this is correct

? not sure this is correct

Needs additionally: model_category created sequence_identity uniprot_start uniprot_end resolution coverage qmean_version ? model_version

Needs additionally:
model_category
created
sequence_identity
uniprot_start
uniprot_end
resolution
coverage
qmean_version ?
model_version

Evaluate 3D-Beacons dev path based on Arnaud's ERASMUS+ project code
Evaluate 3D-Beacons dev path based on Arnaud's ERASMUS+ project code
JAL-3851 start a listener with -testlistener and suggest a port with -testlistener_port. wget -S -O...
JAL-3851 start a listener with -testlistener and suggest a port with -testlistener_port. wget -S -O...
WIP
WIP
This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no sma...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

Class has some compiler warnings which could easily be resolved (typed Hashtable, unused import).

It would be good to add Javadoc to this method

It would be good to add Javadoc to this method

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

As an aside, I would suggest inlining (removing) the two overloaded constructors that call this one (to reduce code bloat).

JAL-3818 process Jmol callbacks in AWT thread
JAL-3818 process Jmol callbacks in AWT thread
Or can it be compiled to Java 8 bytecode?

Or can it be compiled to Java 8 bytecode?

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly). Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatibl...

'var' is since Java 10. We are still supporting Java 8 runtime which will not run this code (sadly).
Compile with JDK 8 to find other occurrences (also Preferences, line 596 is not Java 8 compatible syntax).

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

Above statement is a duplicate - should only be inside the check for service != null. It fails with NPE if service is null.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

startjob and canceljob are only referenced in jbinit() so should be local variables in that method.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

Field startJob used to be the return value of showRunDialog(). As it no longer is, it can be removed.

JAL-3809: Edit web service parameters dialog does not work in jalviewjs
JAL-3809: Edit web service parameters dialog does not work in jalviewjs