CR-JAL-112 JAL-2779: Dialog box sequencing broken on OSX

open for 3 years

Author

Reviewers

JAL-2779: Dialog box sequencing broken on OSX

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 14

jalview 0
- Folder help/html 0
  - File releases.html 0 Remove
- Folder src 0
  - Folder ext/edu/ucsf/rbvi/strucviz2 0
    - File ChimeraResidue.java 0 Remove
  - Folder jalview 0
    - Folder ext/rbvi/chimera 0
      - File AtomSpecModel.java 0 Remove
    - Folder gui 0
      - File AlignFrame.java 0 Remove
      - File AquaInternalFrameManager.java 0 Remove
      - File AquaInternalFrameManager.java 0 Remove
      - File Desktop.java 2 Remove
      - File Desktop.java 1 Remove
      - File FeatureSettings.java 0 Remove
      - File PromptUserConfig.java 0 Remove
      - File PromptUserConfig.java 0 Remove
    - Folder renderer/seqfeatures 0
      - File FeatureRenderer.java 0 Remove
- Folder test/jalview 0
  - Folder ext/rbvi/chimera 0
    - File AtomSpecModelTest.java 0 Remove
  - Folder renderer/seqfeatures 0
    - File FeatureColourFinderTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jim Procter	Author	10m	1	desktop.getDesktopManager() was original behaviour prior ...
Mungo Carstairs	Reviewer - 92% reviewed	16m	3	Some unrelated commits for JAL-2777 seem to have got adde...
Total		26m	4

Linked Issue:
JAL-2779

#permalink

Objectives

Possibly related to the JAL-1900/JAL-2732 patch reinstating the Aqua Desktop manager for JDesktop.

1. Open the sequence fetcher and fetch a sequence - any db source will do.
do not close the fetcher once the alignment has appeared

2. right click on one of the sequences retrieved and open the structure chooser (3D structure...). Pick a structure or just click cancel.

On 2.10.2b1 and 2.10.2b2 on OSX, the structure dialog simply disappears and the alignment panel gets focus.
On the develop branch, where the JAL-2732 fix has been applied, the sequence fetcher dialog box gets input focus instead.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Mungo Carstairs

Some unrelated commits for JAL-2777 seem to have got added in here, ignoring.

23 Oct 17

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-112

JAL-2779: Dialog box sequencing broken on OSX

CR-JAL-112 4

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Mungo Carstairs

Log time against

JAL-2779: Dialog box sequencing broken on OSX

CR-JAL-112 4

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Mungo Carstairs

Log time against