JAL-2774: ViewportRanges fires 2 events when both start residue and start...

Activity

CR-JAL-122 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1m 1 I did consider it at the time...
    Reviewer - 92% reviewed 21m 2 How about making a class for ResAndSeq to hold the values...
    Total   22m 3  
    #permalink

    Objectives

    When the position of the viewport changes, ViewportRanges fires update events to notify listeners of the new position. In particular if the view box in the overview panel is moved, both the start residue and start sequence can be updated in ViewportRanges at the same time, resulting in an unnecessary double update of the alignment viewport. Instead a single event could be fired.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../appletgui/AnnotationPanel.java Changed
    /src/.../appletgui/AnnotationPanel.java Changed
    /src/jalview/appletgui/IdCanvas.java Changed
    /src/jalview/appletgui/ScalePanel.java Changed
    /src/jalview/appletgui/ScalePanel.java Changed
    /src/jalview/appletgui/SeqCanvas.java Changed
    /src/jalview/gui/AnnotationPanel.java Changed
    /src/jalview/gui/AnnotationPanel.java Changed
    /src/jalview/gui/IdCanvas.java Changed
    /src/jalview/gui/ScalePanel.java Changed
    /src/jalview/gui/ScalePanel.java Changed
    /src/jalview/gui/SeqCanvas.java Changed
    /src/.../viewmodel/OverviewDimensionsHideHidden.java Changed
    /src/.../viewmodel/OverviewDimensionsShowHidden.java Changed
    /src/jalview/viewmodel/ViewportRanges.java Changed 2
    /src/jalview/viewmodel/ViewportRanges.java Changed 1
    /test/.../viewmodel/ViewportRangesTest.java Changed
    /test/.../viewmodel/ViewportRangesTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against