JAL-2494: tests for...

Activity

CR-JAL-125 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 6m 1 OK. This changeset has been merged to 2.10.2, so will cre...
    Reviewer - Complete 1m 1 Having to duplicate the findAnnotations method in Sequenc...
    Total   7m 2  
    #permalink

    Objectives

    findAnnotations should behave as documented:

    /**

    • Returns an iterable collection of any annotations that match on given
    • sequence ref, calcId and label (ignoring null values).
      */


    In 2.10.1, null values mean't that annotation rows with null values were ignored. This makes it impossible to search for annotation just by its label - e.g. AlignmentI.findAnnotations(null,null,"Conservation")

    adding test to verify expected behaviour (null implies wildcard or exact match, non-null requires equality)

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    JAL-2828
    #permalink

    General Comments

    Kira Mourão

    Having to duplicate the findAnnotations method in SequenceGroup and Alignment...

    Having to duplicate the findAnnotations method in SequenceGroup and Alignment is a bit icky but the design doesn't really support an alternative just now. Probably ought to duplicate the tests into SequenceGroup though? And maybe a comment in the code pointing out the duplication.

    Jim Procter

    OK. This changeset has been merged to 2.10.2, so will create a task for the c...

    OK. This changeset has been merged to 2.10.2, so will create a task for the current release.

    /src/jalview/datamodel/Alignment.java Changed
    Open in IDE #permalink
    /src/.../datamodel/AnnotatedCollectionI.java Changed
    Open in IDE #permalink
    /src/jalview/datamodel/SequenceGroup.java Changed
    /test/jalview/datamodel/AlignmentTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against