CR-JAL-125
JAL-2494: tests for...
Details
Participant | Role | Time Spent | Comments | Latest Comment |
---|---|---|---|---|
Author | 6m | 1 | OK. This changeset has been merged to 2.10.2, so will cre... | |
Reviewer - Complete | 1m | 1 | Having to duplicate the findAnnotations method in Sequenc... | |
Total | 7m | 2 |
- Linked Issue:
-
Objectives
findAnnotations should behave as documented:
/**
- Returns an iterable collection of any annotations that match on given
- sequence ref, calcId and label (ignoring null values).
*/
In 2.10.1, null values mean't that annotation rows with null values were ignored. This makes it impossible to search for annotation just by its label - e.g. AlignmentI.findAnnotations(null,null,"Conservation")
adding test to verify expected behaviour (null implies wildcard or exact match, non-null requires equality)
Branches in review
General Comments
Jim Procter
OK. This changeset has been merged to 2.10.2, so will create a task for the c...OK. This changeset has been merged to 2.10.2, so will create a task for the current release.
Having to duplicate the findAnnotations method in SequenceGroup and Alignment is a bit icky but the design doesn't really support an alternative just now. Probably ought to duplicate the tests into SequenceGroup though? And maybe a comment in the code pointing out the duplication.
Jim Procter marked as Resolved 10 Nov 17