CR-JAL-125 JAL-2494: tests for jalview.datamodel.AnnotatedCollectionI.findAnnotations(SequenceI, String, String)

open for 3 years

Author

Reviewers

JAL-2494: tests for...

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 4

jalview 0
- Folder src/jalview/datamodel 0
  - File Alignment.java 0 Remove
  - File AnnotatedCollectionI.java 0 Remove
  - File SequenceGroup.java 0 Remove
- Folder test/jalview/datamodel 0
  - File AlignmentTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jim Procter	Author	6m	1	OK. This changeset has been merged to 2.10.2, so will cre...
Kira Mourão	Reviewer - Complete	1m	1	Having to duplicate the findAnnotations method in Sequenc...
Total		7m	2

Linked Issue:
JAL-2494

#permalink

Objectives

findAnnotations should behave as documented:

/**

Returns an iterable collection of any annotations that match on given
sequence ref, calcId and label (ignoring null values).
*/

In 2.10.1, null values mean't that annotation rows with null values were ignored. This makes it impossible to search for annotation just by its label - e.g. AlignmentI.findAnnotations(null,null,"Conservation")

adding test to verify expected behaviour (null implies wildcard or exact match, non-null requires equality)

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee
JAL-2828

#permalink

General Comments

Kira Mourão

Having to duplicate the findAnnotations method in SequenceGroup and Alignment...

Having to duplicate the findAnnotations method in SequenceGroup and Alignment is a bit icky but the design doesn't really support an alternative just now. Probably ought to duplicate the tests into SequenceGroup though? And maybe a comment in the code pointing out the duplication.

Jim Procter

Resolved

10 Nov 17

Jim Procter

OK. This changeset has been merged to 2.10.2, so will create a task for the c...

OK. This changeset has been merged to 2.10.2, so will create a task for the current release.

10 Nov 17

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-125

JAL-2494: tests for...

CR-JAL-125 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Kira Mourão

Jim Procter

Log time against

JAL-2494: tests for...

CR-JAL-125 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Kira Mourão

Jim Procter

Log time against