JAL-2829: Sequence.deleteChars (including gaps) makes incorrect new dataset...


CR-JAL-126 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 0m    
    Reviewer - Complete 1m    
    Total   1m 0  


    Sequence.deleteChars only creates a new dataset sequence if the deletion is 'internal' i.e. doesn't start at the beginning, or end at the end, of the sequence.
    However in this case, the same number of characters are deleted from the dataset sequence, as from the aligned sequence.
    This is incorrect if the deleted region includes gaps.
    Import from Textbox
    and Cut B
    The resulting dataset sequence should be ADEFG... but inspection in the debugger shows it is AGHIJ...

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /src/jalview/datamodel/Sequence.java Changed
    Open in IDE #permalink
    /test/jalview/datamodel/SequenceTest.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against