CR-JAL-126 JAL-2829: Sequence.deleteChars (including gaps) makes incorrect new dataset sequence

open for 3 years

Author

Reviewers

JAL-2829: Sequence.deleteChars (including gaps) makes incorrect new dataset...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 2

jalview 0
- Folder src/jalview/datamodel 0
  - File Sequence.java 0 Remove
- Folder test/jalview/datamodel 0
  - File SequenceTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Mungo Carstairs	Author	0m
Kira Mourão	Reviewer - Complete	1m
Total		1m	0

Linked Issue:
JAL-2829

#permalink

Objectives

Sequence.deleteChars only creates a new dataset sequence if the deletion is 'internal' i.e. doesn't start at the beginning, or end at the end, of the sequence.
However in this case, the same number of characters are deleted from the dataset sequence, as from the aligned sequence.
This is incorrect if the deleted region includes gaps.
Import from Textbox
>seq
AB--CDEFGHIJK
and Cut B--C
The resulting dataset sequence should be ADEFG... but inspection in the debugger shows it is AGHIJ...

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-126

JAL-2829: Sequence.deleteChars (including gaps) makes incorrect new dataset...

CR-JAL-126 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2829: Sequence.deleteChars (including gaps) makes incorrect new dataset...

CR-JAL-126 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against