JAL-2828: Document duplicate findAnnotations code in SequenceGroup and Alignment

Activity

CR-JAL-129 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author      
    Total   0m 0  
    #permalink

    Objectives

    Having to duplicate the findAnnotations method in SequenceGroup and Alignment is a bit icky but the design doesn't really support an alternative just now. Probably ought to duplicate the tests into SequenceGroup though? And maybe a comment in the code pointing out the duplication.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/jalview/datamodel/Alignment.java Changed
    /src/.../datamodel/AlignmentAnnotation.java Changed
    Open in IDE #permalink
    /src/jalview/datamodel/SequenceGroup.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against