JAL-2811: Double residue highlights in cursor mode if new selection moves...


CR-JAL-131 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 3m 2 Done.
    Reviewer - Complete 8m 2 Call to dispose() looks odd here - the Graphics context i...
    Total   11m 4  


    Jumping from a previously highlighted residue in cursor mode to a new position far away enough to move the alignment window, but still close enough to include the original highlighted residue position, leads to both positions being highlighted.

    See attachment for example where, starting with the view covering positions 0-60, residue 40 was highlighted and then followed by highlighting residue 70.

    Same problem in wrapped mode though harder to create a situation where it arises - set up an alignment with 3 wrapped widths so that 1 panel + part of the next can be seen, show the middle panel in full, put cursor at position at top, then enter e.g. 1C to jump to top of previous panel. 2 highlighted positions are shown (see screenshot).

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /src/jalview/gui/SeqCanvas.java Changed 2
    /src/jalview/gui/SeqCanvas.java Changed 2
    /src/jalview/gui/SequenceRenderer.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against