CR-JAL-131 JAL-2811: Double residue highlights in cursor mode if new selection moves alignment window

open for 3 years

Author

Reviewers

JAL-2811: Double residue highlights in cursor mode if new selection moves...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 3

jalview 0
- Folder src/jalview/gui 0
  - File SeqCanvas.java 2 Remove
  - File SeqCanvas.java 2 Remove
  - File SequenceRenderer.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Kira Mourão	Author	3m	2	Done.
Mungo Carstairs	Reviewer - Complete	8m	2	Call to dispose() looks odd here - the Graphics context i...
Total		11m	4

Linked Issue:
JAL-2811

#permalink

Objectives

Jumping from a previously highlighted residue in cursor mode to a new position far away enough to move the alignment window, but still close enough to include the original highlighted residue position, leads to both positions being highlighted.

See attachment for example where, starting with the view covering positions 0-60, residue 40 was highlighted and then followed by highlighting residue 70.

Same problem in wrapped mode though harder to create a situation where it arises - set up an alignment with 3 wrapped widths so that 1 panel + part of the next can be seen, show the middle panel in full, put cursor at position at top, then enter e.g. 1C to jump to top of previous panel. 2 highlighted positions are shown (see screenshot).

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-131

JAL-2811: Double residue highlights in cursor mode if new selection moves...

CR-JAL-131 4

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2811: Double residue highlights in cursor mode if new selection moves...

CR-JAL-131 4

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against