Review patches from develop for Release 2.10.3b1

Activity

CR-JAL-148 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author      
    Reviewer - 100% reviewed 19m 3 :q – yuk. wonder if there are any cases where 'ID' is eve...
    Total   19m 4  
    #permalink

    Objectives

    • JAL-2662 Updated README
    • Merge remote-tracking branch 'origin/task/JAL-2662' into develop
      Conflicts:
      benchmarking/README
    • JAL-2886 trivial unit test fix
    • JAL-2679 use object_type=Transcript for lookup of Parent for Protein
    • JAL-2679 case-insensitive comparison of query and retrieved accession
    • JAL-2679 update query id to actual case of retrieved gene
    • JAL-2810 JAL-2886 i18n

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /benchmarking/README Changed
    Open in IDE #permalink
    /resources/lang/Messages.properties Changed
    /resources/lang/Messages_es.properties Changed
    /src/jalview/ext/ensembl/EnsemblCdna.java Changed
    Open in IDE #permalink
    /src/jalview/.../ensembl/EnsemblFeatures.java Changed
    /src/jalview/ext/ensembl/EnsemblGene.java Changed
    Open in IDE #permalink
    /src/jalview/.../ensembl/EnsemblGenome.java Changed 4
    Open in IDE #permalink
    /src/jalview/.../ensembl/EnsemblLookup.java Changed
    /src/jalview/.../ensembl/EnsemblSeqProxy.java Changed
    /src/.../ensembl/EnsemblSequenceFetcher.java Changed
    /src/jalview/.../ensembl/EnsemblSymbol.java Changed
    Open in IDE #permalink
    /src/jalview/fts/core/GFTSPanel.java Changed
    Open in IDE #permalink
    /src/jalview/gui/StructureChooser.java Changed
    /src/jalview/jbgui/GStructureChooser.java Changed
    /test/jalview/.../ensembl/EnsemblCdnaTest.java Changed
    Open in IDE #permalink
    /test/jalview/.../ensembl/EnsemblGeneTest.java Changed
    /test/.../gui/StructureChooserTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against