1. Jalview Code Reviews

CR-JAL-154

Tools
abandoned on 10 Apr 18
Author
Reviewers

JAL-2944: Allow structures to be opened in a specific structure view

Activity

CR-JAL-154 0

Keyboard shortcuts  
    • Summarize the review outcomes (optional)
    Previewwiki syntax help
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Jim Procter
    		Author      
    Mungo Carstairs
    		Reviewer - 2% reviewed 1m    
    Total   1m 0  
    #permalink

    Objectives

    On selecting a structure to view, Jalview prompts the user about adding the structure to an existing view (each in turn), before opening it in a new view. The sequential prompt is a modal dialog, and cumbersome when many structure views are available - it would be better if the user could select the destination prior to initiating retrieval/display.

    Selecting the destination for structures would also make it easier to add several structures to an existing view, because in 2.10.3 and earlier, when several structures are selected, Jalview always opens a new view.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /.settings/org.eclipse.jdt.core.prefs Changed
    Open in IDE #permalink
    /benchmarking/.../jalview/HiddenColsIteratorsBenchmark.java Added
    Open in IDE #permalink
    /benchmarking/.../jalview/HiddenColumnsBenchmark.java Changed
    Open in IDE #permalink
    /benchmarking/.../jalview/SeqWidthBenchmark.java Added
    Open in IDE #permalink
    /benchmarking/README Changed
    Open in IDE #permalink
    /examples/testdata/4IM2_missing.pdb Added
    Open in IDE #permalink
    /examples/testdata/4IM2_missing_noid.pdb Added
    Open in IDE #permalink
    /examples/testdata/4IM2_nterm.pdb Added
    Open in IDE #permalink
    /help/html/features/splitView.html Changed
    Open in IDE #permalink
    /help/html/releases.html Changed
    /help/html/whatsNew.html Changed
    /help/help.jhm Changed
    /resources/images/idwidth.gif Deleted
    Open in IDE #permalink
    /src/MCview/PDBChain.java Changed
    /src/jalview/analysis/AlignmentUtils.java Changed
    Open in IDE #permalink
    /src/jalview/analysis/Dna.java Changed
    Open in IDE #permalink
    /src/.../structures/JalviewStructureDisplayI.java Changed
    /src/jalview/appletgui/AlignFrame.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/AlignmentPanel.java Changed
    Open in IDE #permalink
    /src/.../appletgui/AnnotationColumnChooser.java Changed
    Open in IDE #permalink
    /src/.../appletgui/AnnotationLabels.java Changed
    Open in IDE #permalink
    /src/.../appletgui/AnnotationPanel.java Changed
    Open in IDE #permalink
    /src/.../appletgui/FeatureSettings.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/IdCanvas.java Changed
    Open in IDE #permalink
    /src/.../appletgui/IdwidthAdjuster.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/OverviewCanvas.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/OverviewPanel.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/ScalePanel.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/SeqCanvas.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/SeqPanel.java Changed
    Open in IDE #permalink
    /src/jalview/bin/Cache.java Changed
    Open in IDE #permalink
    /src/jalview/bin/JalviewLite.java Changed
    Open in IDE #permalink
    /src/jalview/datamodel/Alignment.java Changed
    Open in IDE #permalink
    /src/.../datamodel/AlignmentAnnotation.java Changed
    /src/jalview/datamodel/AlignmentI.java Changed
    Open in IDE #permalink
    /src/.../datamodel/BoundedHiddenColsIterator.java Deleted
    Open in IDE #permalink
    /src/.../datamodel/BoundedStartRegionIterator.java Deleted
    Open in IDE #permalink
    /src/jalview/datamodel/CigarArray.java Changed
    Open in IDE #permalink
    /src/jalview/datamodel/DBRefSource.java Changed
    Open in IDE #permalink
    /src/.../datamodel/HiddenColsIterator.java Deleted
    Open in IDE #permalink
    /src/jalview/datamodel/HiddenColumns.java Changed
    Open in IDE #permalink
    /src/.../datamodel/HiddenColumnsCursor.java Added
    Open in IDE #permalink
    /src/.../datamodel/HiddenCursorPosition.java Added
    /src/.../datamodel/RangeElementsIterator.java Added
    /src/jalview/datamodel/RangeIterator.java Added
    /src/.../datamodel/RegionsIterator.java Deleted
    Open in IDE #permalink
    /src/.../datamodel/ReverseRegionsIterator.java Deleted
    Open in IDE #permalink
    /src/jalview/datamodel/Sequence.java Changed
    Open in IDE #permalink
    /src/jalview/datamodel/SequenceGroup.java Changed
    Open in IDE #permalink
    /src/jalview/datamodel/SequenceI.java Changed
    Open in IDE #permalink
    /src/.../datamodel/StartRegionIterator.java Added
    Open in IDE #permalink
    /src/.../datamodel/VisibleColsCollection.java Changed
    Open in IDE #permalink
    /src/.../datamodel/VisibleColsIterator.java Deleted
    Open in IDE #permalink
    /src/.../datamodel/VisibleContigsIterator.java Added
    /src/jalview/.../ensembl/EnsemblGenomes.java Changed
    Open in IDE #permalink
    /src/jalview/.../ensembl/EnsemblLookup.java Changed
    /src/.../ensembl/EnsemblRestClient.java Changed
    /src/.../ensembl/EnsemblSequenceFetcher.java Changed
    Open in IDE #permalink
    /src/jalview/.../jmol/JalviewJmolBinding.java Changed
    /src/jalview/ext/jmol/JmolCommands.java Changed
    Open in IDE #permalink
    /src/.../uniprot/UniProtFTSRestClient.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AlignFrame.java Changed
    /src/jalview/gui/AlignViewport.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AlignmentPanel.java Changed
    /src/.../gui/AnnotationColumnChooser.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AnnotationLabels.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AnnotationPanel.java Changed
    /src/jalview/gui/AppJmol.java Changed