JAL-3048 jalview.utils.dialogrunner.DialogRunner allows sequences of runnable...

Activity

CR-JAL-164 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 17m 1 this won't be called in js - move before JVOptionPane ..
    Reviewer - 0% reviewed 5m    
    Reviewer - 69% reviewed 46m 11 Does this issue also cover use of JColor.showDialog()? Th...
    Total   1h 8m 12  
    #permalink

    Objectives

    • JAL-3048 jalview.utils.dialogrunner.DialogRunner allows sequences of runnable methods to be sequentially triggered according to response codes from a dialog.
    • JAL-3048 refactored Desktop->File->Open to use jalview.utils.dialogrunner.DialogRunner
    • JAL-3048 AlignFrame->File->Load Tree adapted for js
    • JAL-1551 JAL-3048 formatting
    • JAL-3048 use FileParse to transfer File to NewickFile parser

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mungo Carstairs

    Sorry, I've failed to understand this code, but will add comments anyway and ...

    Sorry, I've failed to understand this code, but will add comments anyway and hope to get it the second time around.

    Mungo Carstairs

    Does this issue also cover use of JColor.showDialog()? These need a small ref...

    Does this issue also cover use of JColor.showDialog()?
    These need a small refactoring to pass in a listener to action the OK button, e.g.
    JColorChooser colorChooser = new JColorChooser();
    colorChooser.setColor(currentColour);
    JDialog dialog = JColorChooser.createDialog(this, title, true, colorChooser, listener, null);
    in 14 places: AnnotationColourChooser, AnnotationPanel, FeatureRenderer.amendFeatures, PCAPanel (background colour), set group outline, (Preferences Colour tab), structure viewer (set background), TextColourChooser, TreeCanvas.chooseSubtreeColour.

    /src/jalview/gui/AlignFrame.java Changed 2
    Open in IDE #permalink
    /src/jalview/gui/Desktop.java Changed
    Open in IDE #permalink
    /src/jalview/io/JalviewFileChooser.java Changed
    /src/.../dialogrunner/DialogRunner.java Added 5
    /src/.../dialogrunner/DialogRunnerI.java Added 1
    /src/jalview/.../dialogrunner/Response.java Added 1
    Open in IDE #permalink
    /src/jalview/.../dialogrunner/RunResponse.java Added 1
    Open in IDE #permalink
    /src/jalview/util/ImageMaker.java Changed
    /test/.../dialogrunner/DialogRunnerTest.java Added
    /test/.../dialogrunner/ResponseTest.java Added
    Open in IDE #permalink
    /test/.../dialogrunner/RunResponseTest.java Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against