CR-JAL-18 JAL-2438: Make findFeatureColour thread-safe and smarter

closed on 12 Apr 17

Author

Reviewers

JAL-2438: Make findFeatureColour thread-safe and smarter

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 30

jalview 0
- Folder src 0
  - Folder MCview 0
    - File AppletPDBCanvas.java 0 Remove
    - File PDBCanvas.java 0 Remove
  - Folder jalview 0
    - Folder api 0
      - File FeatureRenderer.java 0 Remove
      - File SequenceRenderer.java 0 Remove
    - Folder appletgui 0
      - File AppletJmolBinding.java 0 Remove
      - File ExtJmol.java 0 Remove
      - File OverviewPanel.java 0 Remove
      - File SeqCanvas.java 0 Remove
      - File SequenceRenderer.java 0 Remove
    - Folder ext 0
      - Folder jmol 0
        
        File JalviewJmolBinding.java 3 Remove
        
        File JmolCommands.java 0 Remove
      - Folder rbvi/chimera 0
        
        File ChimeraCommands.java 0 Remove
        
        File JalviewChimeraBinding.java 2 Remove
      - Folder varna 0
        
        File VarnaCommands.java 0 Remove
    - Folder gui 0
      - File AppJmolBinding.java 0 Remove
      - File FeatureRenderer.java 0 Remove
      - File JalviewChimeraBindingModel.java 3 Remove
      - File OverviewPanel.java 0 Remove
      - File SeqCanvas.java 0 Remove
      - File SequenceRenderer.java 0 Remove
    - Folder io 0
      - File JSONFile.java 0 Remove
    - Folder javascript 0
      - File MouseOverStructureListener.java 0 Remove
    - Folder renderer/seqfeatures 0
      - File FeatureColourFinder.java 0 Remove
      - File FeatureRenderer.java 3 Remove
    - Folder structures/models 0
      - File AAStructureBindingModel.java 0 Remove
    - Folder viewmodel/seqfeatures 0
      - File FeatureRendererModel.java 0 Remove
- Folder test/jalview 0
  - Folder ext 0
    - Folder jmol 0
      - File JmolCommandsTest.java 0 Remove
    - Folder rbvi/chimera 0
      - File ChimeraCommandsTest.java 0 Remove
  - Folder renderer/seqfeatures 0
    - File FeatureColourFinderTest.java 0 Remove
  - Folder structures/models 0
    - File AAStructureBindingModelTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Mungo Carstairs	Author	20m	5	I agree. I had swerved these fields as not sure what they...
Kira Mourão	Reviewer - Complete	57m	4	I realise this code is unchanged, but I think it actually...
Total		1h 17m	11

Linked Issue:
JAL-2438

#permalink

Objectives

FeatureRenderer.findFeatureColour is called when determining feature colours for structures or the overview window. Because it is not currently thread-safe, 'clones' of FeatureRenderer are used for this. This is fragile (see JAL-2436 for a bug resulting).

Proposed to explore how to make the method thread-safe so that no clones are needed, only a 'read-only' view of the FeatureRenderer.

Performance is critical here so must be preserved - and improved where possible.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-18

JAL-2438: Make findFeatureColour thread-safe and smarter

CR-JAL-18 11

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2438: Make findFeatureColour thread-safe and smarter

CR-JAL-18 11

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against