JAL-3477 New sensible default decisions on memory, and new jvmmemmax setting for...

Activity

CR-JAL-204 1

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author      
    Reviewer - 100% reviewed 12m 1 (Notes for self) - Ben verified on linux, OSX, Windows. N...
    Total   12m 1  
    #permalink

    Objectives

    • JAL-3477 New sensible default decisions on memory, and new jvmmemmax setting for setting absolute memory level
    • JAL-3477 New jvmmemmax config option in getdown and getdown config. Set to 32G cap.
    • JAL-3210 removing overly complicated logging. Settling for System.out.println and System.err.println for MemorySetting output
    • JAL-3210 cache getdown config, remove jvmmem options for better defaults
    • JAL-3477 A bit of refactoring for the better
    • JAL-3477 Javadoc, refactoring and slight changes to memory default decisions based on CR-JAL-189
    • JAL-3477 New jalview.bin.MemorySetting jalview.bin.GetMemory source files for getdown
    • JAL-3477 getdown jars. This commit can be left out if it conflicts.
    • JAL-3477 Refactoring based on CR-JAL-189
    • JAL-3477 Newer jalview.bin.MemorySetting jalview.bin.GetMemory source files for getdown
    • JAL-3477 getdown jars. This commit can be left out if it conflicts.
    • JAL-3477 Javadoc, addition of -jvmmempc and -jvmmemmax args detection and some small tidying in jalview.bin.Launcher based on CR-JAL-189, small tidy in jalview.bin.MemorySetting
    • JAL-3477 updated getdown's jalview.bin.MemorySetting
    • JAL-3477 getdown jars. This commit can be left out if it conflicts.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Jim Procter

    (Notes for self) - Ben verified on linux, OSX, Windows. Need to check there a...

    (Notes for self) - Ben verified on linux, OSX, Windows.
    Need to check there are docs and logging to indicate that the hard limit is reached, so if people want to adjust the limit they can !

    /getdown/lib/getdown-core.jar Changed
    Open in IDE #permalink
    /getdown/lib/getdown-launcher-local.jar Changed
    Open in IDE #permalink
    /getdown/lib/getdown-launcher.jar Changed
    Open in IDE #permalink
    /getdown/src/getdown/ant/pom.xml Changed
    Open in IDE #permalink
    /getdown/src/.../getdown/data/Application.java Changed
    Open in IDE #permalink
    /getdown/src/.../getdown/util/Config.java Changed
    Open in IDE #permalink
    /getdown/src/.../jalview/bin/GetMemory.java Added
    Open in IDE #permalink
    /getdown/src/.../bin/MemoryPercent.java Deleted
    Open in IDE #permalink
    /getdown/src/.../bin/MemorySetting.java Changed
    Open in IDE #permalink
    /getdown/src/getdown/core/pom.xml Changed
    Open in IDE #permalink
    /getdown/src/getdown/launcher/pom.xml Changed
    Open in IDE #permalink
    /getdown/src/getdown/mvn_cmd Changed
    Open in IDE #permalink
    /getdown/src/getdown/pom.xml Changed
    Open in IDE #permalink
    /j11lib/getdown-core.jar Changed
    Open in IDE #permalink
    /j8lib/getdown-core.jar Changed
    Open in IDE #permalink
    /src/jalview/bin/GetMemory.java Added
    Open in IDE #permalink
    /src/jalview/bin/Launcher.java Changed
    Open in IDE #permalink
    /src/jalview/bin/MemoryPercent.java Deleted
    Open in IDE #permalink
    /src/jalview/bin/MemorySetting.java Changed
    Open in IDE #permalink
    /test/jalview/bin/MemorySettingTest.java Added
    Open in IDE #permalink
    /utils/testnglibs/classgraph-4.1.6.jar Added
    Open in IDE #permalink
    /utils/classgraph-4.1.6.jar Deleted
    Open in IDE #permalink
    /gradle.properties Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against