JAL-3659 proper headless check; skips setProperty for JS


CR-JAL-230 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   1m 0  


    84be38a183e5c51a5759b7a88362198b2687907c: JAL-3659 proper headless check; skips setProperty for JS

    curious why setting the java.awt.headless property would be productive here. This setting is only used in one place in Java core classes, only in GraphicsEnvironment, where it is checked as just one part of a more complex determination of headlessness. That test, GraphicsEnvironment.isHeadless(), is done once and only once.

    By NOT setting this flag, we allow a truly "-nodisplay" environment that still allows a lot of functionality, just no display.

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /src/jalview/bin/Jalview.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against