CR-JAL-230 JAL-3659 proper headless check; skips setProperty for JS

open for 24 months

Author

Reviewers

JAL-3659 proper headless check; skips setProperty for JS

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 1

jalview 0
- Folder src/jalview/bin 0
  - File Jalview.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Bob Hanson	Author	1m
Jim Procter	Reviewer - 0% reviewed
Mungo Carstairs	Reviewer - 0% reviewed
Total		1m	0

Linked Issue:
JAL-3659

#permalink

Objectives

84be38a183e5c51a5759b7a88362198b2687907c: JAL-3659 proper headless check; skips setProperty for JS

curious why setting the java.awt.headless property would be productive here. This setting is only used in one place in Java core classes, only in GraphicsEnvironment, where it is checked as just one part of a more complex determination of headlessness. That test, GraphicsEnvironment.isHeadless(), is done once and only once.

By NOT setting this flag, we allow a truly "-nodisplay" environment that still allows a lot of functionality, just no display.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-230

JAL-3659 proper headless check; skips setProperty for JS

CR-JAL-230 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-3659 proper headless check; skips setProperty for JS

CR-JAL-230 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against