JAL-3608: Set choice of Look and Feel via system property

Activity

CR-JAL-236 13

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 57m 5 Resolutions to this review are in task/JAL-3608_property...
    Reviewer - Complete 23m 8 (1 defect) Will we need isNoJSLinux I wonder?
    Total   1h 20m 13 (1 defect)  
    #permalink

    Objectives

    Jalview desktop currently chooses the SystemLookAndFeel by default, and if you're on a mac it tries to set the Look and Feel to Quaqua, failing that Vaqua (and failing that it remains SystemLookAndFeel).
    This has caused at least one test (jalview.gui.AlignmentPanelTest.testCalculateIdWidth_withMaxWidth) to consistently work on a mac desktop but consistently fail on the build server clover tests.

    We could allow an option for Jalview to choose the CrossPlatformLookAndFeel (also known as Metal) which should work the same, um, cross platform. This is the Look And Feel being used on the build server (it is the usual Linux SystemLookAndFeel), so will allow more accurate testing on a mac or in windows (or a GtkLookAndFeel default-enabled linux desktop).

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Ben Soares

    Resolutions to this review are in task/JAL-3608_property_set_laf_and_tests_f...

    Resolutions to this review are in

    task/JAL-3608_property_set_laf_and_tests_from_Release_2_11_1_Branch

    and will be migrated to task/JAL-3608_property_set_laf_and_tests soon...

    /src/jalview/bin/Cache.java Changed 3
    /src/jalview/bin/Cache.java Changed
    Open in IDE #permalink
    /src/jalview/bin/Jalview.java Changed 8
    /src/jalview/bin/Jalview.java Changed
    Open in IDE #permalink
    /src/jalview/bin/Jalview.java Changed
    /src/jalview/util/Platform.java Changed
    Open in IDE #permalink
    /src/jalview/util/Platform.java Changed 1
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against