CR-JAL-236 JAL-3608: Set choice of Look and Feel via system property

closed on 09 Jul 20

Author

Reviewers

JAL-3608: Set choice of Look and Feel via system property

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 9

jalview 0
- Folder src/jalview 0
  - Folder bin 0
    - File Cache.java 3 Remove
    - File Cache.java 0 Remove
    - File Jalview.java 8 Remove
    - File Jalview.java 0 Remove
    - File Jalview.java 0 Remove
  - Folder util 0
    - File Platform.java 0 Remove
    - File Platform.java 1 Remove
- File build.gradle 0 Remove
- File build.gradle 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ben Soares	Author	57m	5	Resolutions to this review are in task/JAL-3608_property...
Mungo Carstairs	Reviewer - Complete	23m	8 (1 defect)	Will we need isNoJSLinux I wonder?
Total		1h 20m	13 (1 defect)

Linked Issue:
JAL-3608

#permalink

Objectives

Jalview desktop currently chooses the SystemLookAndFeel by default, and if you're on a mac it tries to set the Look and Feel to Quaqua, failing that Vaqua (and failing that it remains SystemLookAndFeel).
This has caused at least one test (jalview.gui.AlignmentPanelTest.testCalculateIdWidth_withMaxWidth) to consistently work on a mac desktop but consistently fail on the build server clover tests.

We could allow an option for Jalview to choose the CrossPlatformLookAndFeel (also known as Metal) which should work the same, um, cross platform. This is the Look And Feel being used on the build server (it is the usual Linux SystemLookAndFeel), so will allow more accurate testing on a mac or in windows (or a GtkLookAndFeel default-enabled linux desktop).

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Ben Soares

Resolutions to this review are in task/JAL-3608_property_set_laf_and_tests_f...

Resolutions to this review are in

task/JAL-3608_property_set_laf_and_tests_from_Release_2_11_1_Branch

and will be migrated to task/JAL-3608_property_set_laf_and_tests soon...

08 Jul 20

Ben Soares

Unresolved

08 Jul 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-236

JAL-3608: Set choice of Look and Feel via system property

CR-JAL-236 13

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Ben Soares

Log time against

JAL-3608: Set choice of Look and Feel via system property

CR-JAL-236 13

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Ben Soares

Log time against