CR-JAL-245 JAL-3809: Edit web service parameters dialog does not work in jalviewjs

open for 4 months

Author

Reviewers

JAL-3809: Edit web service parameters dialog does not work in jalviewjs

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 5

jalview 0
- Folder src/jalview 0
  - Folder gui 0
    - File AlignFrame.java 2 Remove
    - File WsJobParameters.java 3 Remove
  - Folder ws 0
    - Folder jws2 0
      - File MsaWSClient.java 1 Remove
      - File SequenceAnnotationWSClient.java 0 Remove
    - File WSClient.java 2 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Mateusz Warowny	Author
Mungo Carstairs	Reviewer - Complete	36m	9 (1 defect)	This is likely an improvement on the "roll your own" patt...
Total		36m	9 (1 defect)

Linked Issue:
JAL-3809

#permalink

Objectives

Due to the blocking nature of JDialog used, the parameter editor does not work properly in JalviewJS. The fix would be to replace JDialog with JFrame and use callbacks in place of the synchronous code.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Mungo Carstairs

This is likely an improvement on the "roll your own" pattern of setting Runna...

This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.

There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.

25 Feb

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-245

JAL-3809: Edit web service parameters dialog does not work in jalviewjs

CR-JAL-245 9

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Mungo Carstairs

Log time against

JAL-3809: Edit web service parameters dialog does not work in jalviewjs

CR-JAL-245 9

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Mungo Carstairs

Log time against