CR-JAL-245
JAL-3809: Edit web service parameters dialog does not work in jalviewjs
#permalink
Details
Warning: no files are visible, they have all been filtered.
Participant | Role | Time Spent | Comments | Latest Comment |
---|---|---|---|---|
Author | ||||
Reviewer - Complete | 36m | 9 (1 defect) | This is likely an improvement on the "roll your own" patt... | |
Total | 36m | 9 (1 defect) |
- Linked Issue:
-
#permalink
Objectives
Due to the blocking nature of JDialog used, the parameter editor does not work properly in JalviewJS. The fix would be to replace JDialog with JFrame and use callbacks in place of the synchronous code.
This is likely an improvement on the "roll your own" pattern of setting Runnable handlers for dialog responses as hacked together for JalviewJS (JAL-3048). If so, it would be preferable (but no small job) to change all dialogs to this pattern.
There are still numerous dialogs that have not been changed to either pattern (so won't work in SwingJS): see comment at https://issues.jalview.org/browse/?focusedCommentId=20525&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#JAL-3048comment-20525.