close filehandles straight after parse, without setting an error

Activity

CR-JAL-258 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 8m 1 I tried this first, but FileParse.close() deliberately le...
    Reviewer - 100% reviewed 36m 3 I know the problems you had with close() - you mentioned ...
    Total   44m 4  
    #permalink

    Objectives

    • close filehandles straight after parse, without setting an error
    • JAL-3703 fix Gff3 shared InputStream with embedded FASTA data
    • JAL-3703 Test that fails in Windows only, and only when the file handle isn't relinquished

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    JAL-3939
    #permalink

    General Comments

    There are no general comments on this review.
    /src/jalview/io/AlignFile.java Changed 3
    Open in IDE #permalink
    /src/jalview/io/FastaFile.java Changed
    Open in IDE #permalink
    /src/jalview/io/FeaturesFile.java Changed
    Open in IDE #permalink
    /src/jalview/io/FileParse.java Changed
    Open in IDE #permalink
    /src/jalview/project/Jalview2XML.java Changed 1
    Open in IDE #permalink
    /test/jalview/io/BackupFilesTest.java Changed
    Open in IDE #permalink
    /test/.../io/WindowsFileLoadAndSaveTest.java Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against