1. Jalview Code Reviews

CR-JAL-261

Tools
open
Author
Reviewers

JAL-3949 An attempt at converting to Log4j 2 -- no output achieved!

Activity

CR-JAL-261 6

Keyboard shortcuts  
    • Summarize the review outcomes (optional)
    Previewwiki syntax help
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Ben Soares
    		Author 34m 3 That looks good. I was almost going to do something simil...
    Jim Procter
    		Reviewer - 95% reviewed 24m 3 (1 defect) AWESOME JOB !!!! one tiny niggle I had was that Cache.deb...
    Total   58m 6 (1 defect)  
    #permalink

    Objectives

    • JAL-3949 An attempt at converting to Log4j 2 – no output achieved!
    • JAL-3949 Complete new abstracted logging framework in jalview.log. Updated log calls for this. Removal of jalview.javascript.log4j. Improvements to the Java Console (controllable autoscrolling).
    • Merge branch 'develop' into update/JAL-3949_abstracted_logging_for_jalviewjs_and_sanity

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Jim Procter

    AWESOME JOB !!!! one tiny niggle I had was that Cache.debug/Cache.error doesn...

    AWESOME JOB !!!! one tiny niggle I had was that Cache.debug/Cache.error doesn't read nicely, so I've abstracted the logging stuff even farther to a new jalview.bin.Console class: see https://source.jalview.org/crucible/changelog/~br=update%402fJAL-3949_jalview_bin_Console_to_cure_sanity_even_more/jalview/

    Ben Soares

    That looks good. I was almost going to do something similar (I was thinking j...

    That looks good. I was almost going to do something similar (I was thinking jalview.log.Log, but jalview.bin.Console is just as good) so happy with this!

    /help/help/html/logging.html Changed
    Open in IDE #permalink
    /j11lib/log4j-1.2-api-2.17.1.jar Deleted
    Open in IDE #permalink
    /j11lib/slf4j-log4j12-1.7.32.jar Deleted
    Open in IDE #permalink
    /j8lib/log4j-1.2-api-2.17.1.jar Deleted
    Open in IDE #permalink
    /j8lib/slf4j-log4j12-1.7.32.jar Deleted
    Open in IDE #permalink
    /src/jalview/analysis/AlignmentUtils.java Changed
    Open in IDE #permalink
    /src/jalview/analysis/GeneticCodes.java Changed
    Open in IDE #permalink
    /src/jalview/analysis/PCA.java Changed
    Open in IDE #permalink
    /src/jalview/analysis/TreeModel.java Changed
    Open in IDE #permalink
    /src/jalview/bin/Cache.java Changed
    Open in IDE #permalink
    /src/jalview/bin/Jalview.java Changed
    Open in IDE #permalink
    /src/jalview/.../ensembl/EnsemblLookup.java Changed
    Open in IDE #permalink
    /src/jalview/.../ensembl/EnsemblSeqProxy.java Changed
    Open in IDE #permalink
    /src/jalview/ext/htsjdk/VCFReader.java Changed
    Open in IDE #permalink
    /src/jalview/.../jmol/JalviewJmolBinding.java Changed
    Open in IDE #permalink
    /src/jalview/ext/pymol/PymolManager.java Changed
    Open in IDE #permalink
    /src/.../chimera/JalviewChimeraBinding.java Changed
    Open in IDE #permalink
    /src/jalview/ext/so/SequenceOntology.java Changed
    Open in IDE #permalink
    /src/jalview/fts/core/GFTSPanel.java Changed
    Open in IDE #permalink
    /src/.../alphafold/AlphafoldRestClient.java Changed
    Open in IDE #permalink
    /src/.../threedbeacons/TDBeaconsFTSPanel.java Changed
    Open in IDE #permalink
    /src/.../structurechooser/ThreeDBStructureChooserQuerySource.java Changed
    Open in IDE #permalink
    /src/jalview/gui/APQHandlers.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AlignFrame.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AlignViewport.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AlignmentPanel.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AppJmol.java Changed
    Open in IDE #permalink
    /src/jalview/gui/AppJmolBinding.java Changed
    Open in IDE #permalink
    /src/jalview/gui/BlogReader.java Changed
    Open in IDE #permalink
    /src/jalview/gui/ChimeraViewFrame.java Changed
    Open in IDE #permalink
    /src/jalview/gui/Console.java Changed
    Open in IDE #permalink
    /src/jalview/gui/CrossRefAction.java Changed
    Open in IDE #permalink
    /src/.../gui/CutAndPasteHtmlTransfer.java Changed
    Open in IDE #permalink
    /src/jalview/gui/CutAndPasteTransfer.java Changed
    Open in IDE #permalink
    /src/jalview/gui/Desktop.java Changed
    Open in IDE #permalink
    /src/jalview/gui/FeatureTypeSettings.java Changed
    Open in IDE #permalink
    /src/jalview/gui/JalviewAppender.java Deleted
    Open in IDE #permalink
    /src/jalview/gui/OOMWarning.java Changed
    Open in IDE #permalink
    /src/jalview/gui/PCAPanel.java Changed
    Open in IDE #permalink
    /src/jalview/gui/PopupMenu.java Changed
    Open in IDE #permalink
    /src/jalview/gui/Preferences.java Changed
    Open in IDE #permalink
    /src/jalview/gui/PromptUserConfig.java Changed
    Open in IDE #permalink
    /src/jalview/gui/PymolBindingModel.java Changed
    Open in IDE #permalink
    /src/jalview/gui/PymolViewer.java Changed
    Open in IDE #permalink
    /src/jalview/gui/RotatableCanvas.java Changed
    Open in IDE #permalink
    /src/jalview/gui/SeqPanel.java Changed
    Open in IDE #permalink
    /src/jalview/gui/SequenceFetcher.java Changed
    Open in IDE #permalink
    /src/jalview/gui/StructureChooser.java Changed
    Open in IDE #permalink
    /src/jalview/gui/StructureViewer.java Changed
    Open in IDE #permalink
    /src/jalview/gui/StructureViewerBase.java Changed
    Open in IDE #permalink
    /src/jalview/gui/TreePanel.java Changed
    Open in IDE #permalink
    /src/.../gui/UserQuestionnaireCheck.java Changed
    Open in IDE #permalink
    /src/jalview/gui/VamsasApplication.java Changed
    Open in IDE #permalink
    /src/jalview/gui/WsJobParameters.java Changed
    Open in IDE #permalink
    /src/jalview/gui/WsParamSetManager.java Changed
    Open in IDE #permalink
    /src/jalview/io/vamsas/DatastoreItem.java Changed 2
    Open in IDE #permalink
    /src/jalview/.../vamsas/DatastoreRegistry.java Changed
    Open in IDE #permalink
    /src/jalview/io/vamsas/Dbref.java Changed
    Open in IDE #permalink
    /src/jalview/io/vamsas/Rangetype.java Changed
    Open in IDE #permalink
    /src/jalview/.../vamsas/Sequencefeature.java Changed
    Open in IDE #permalink
    /src/jalview/.../vamsas/Sequencemapping.java Changed
    Open in IDE #permalink
    /src/jalview/io/vamsas/Tree.java Changed
    Open in IDE #permalink
    /src/jalview/io/vcf/VCFLoader.java Changed
    Open in IDE #permalink
    /src/.../io/BackupFilesPresetEntry.java Changed
    Open in IDE #permalink
    /src/jalview/io/BioJsHTMLOutput.java Changed
    Open in IDE #permalink
    /src/jalview/io/EMBLLikeFlatFile.java Changed
    Open in IDE #permalink
    /src/jalview/io/EmblFlatFile.java Changed
    Open in IDE #permalink
    /src/jalview/io/FileLoader.java Changed
    Open in IDE #permalink
    /src/jalview/io/FileParse.java Changed
    Open in IDE #permalink
    /src/jalview/io/FormatAdapter.java Changed
    Open in IDE #permalink
    /src/jalview/io/HtmlSvgOutput.java Changed
    Open in IDE #permalink
    /src/jalview/io/ModellerDescription.java Changed
    Open in IDE #permalink
    /src/jalview/io/StockholmFile.java Changed
    Open in IDE #permalink
    /src/jalview/io/VamsasAppDatastore.java Changed
    Open in IDE #permalink
    /src/jalview/.../log4j/spi/LoggingEvent.java Deleted
    Open in IDE #permalink
    /src/jalview/.../log4j/spi/OptionHandler.java Deleted
    Open in IDE #permalink
    /src/jalview/.../log4j/Appender.java Deleted
    Open in IDE #permalink