CR-JAL-261 6
- Details
- Objectives
- General Comments 2
- Unresolved
- Resolved
- Number of files included: 126
-
jalview
0
-
Folder
help/help/html
0
- File logging.html 0 Remove
-
Folder
j11lib
0
- File log4j-1.2-api-2.17.1.jar 0 Remove
- File slf4j-log4j12-1.7.32.jar 0 Remove
-
Folder
j8lib
0
- File log4j-1.2-api-2.17.1.jar 0 Remove
- File slf4j-log4j12-1.7.32.jar 0 Remove
-
Folder
src/jalview
0
-
Folder
analysis
0
- File AlignmentUtils.java 0 Remove
- File GeneticCodes.java 0 Remove
- File PCA.java 0 Remove
- File TreeModel.java 0 Remove
-
Folder
bin
0
- File Cache.java 0 Remove
- File Jalview.java 0 Remove
-
Folder
ext
0
-
Folder
ensembl
0
- File EnsemblLookup.java 0 Remove
- File EnsemblSeqProxy.java 0 Remove
-
Folder
htsjdk
0
- File VCFReader.java 0 Remove
-
Folder
jmol
0
- File JalviewJmolBinding.java 0 Remove
-
Folder
pymol
0
- File PymolManager.java 0 Remove
-
Folder
rbvi/chimera
0
- File JalviewChimeraBinding.java 0 Remove
-
Folder
so
0
- File SequenceOntology.java 0 Remove
-
Folder
ensembl
0
-
Folder
fts
0
-
Folder
core
0
- File GFTSPanel.java 0 Remove
-
Folder
service
0
-
Folder
alphafold
0
- File AlphafoldRestClient.java 0 Remove
-
Folder
threedbeacons
0
- File TDBeaconsFTSPanel.java 0 Remove
-
Folder
alphafold
0
-
Folder
core
0
-
Folder
gui
0
-
Folder
structurechooser
0
- File ThreeDBStructureChooserQuerySource.java 0 Remove
- File APQHandlers.java 0 Remove
- File AlignFrame.java 0 Remove
- File AlignViewport.java 0 Remove
- File AlignmentPanel.java 0 Remove
- File AppJmol.java 0 Remove
- File AppJmolBinding.java 0 Remove
- File BlogReader.java 0 Remove
- File ChimeraViewFrame.java 0 Remove
- File Console.java 0 Remove
- File CrossRefAction.java 0 Remove
- File CutAndPasteHtmlTransfer.java 0 Remove
- File CutAndPasteTransfer.java 0 Remove
- File Desktop.java 0 Remove
- File FeatureTypeSettings.java 0 Remove
- File JalviewAppender.java 0 Remove
- File OOMWarning.java 0 Remove
- File PCAPanel.java 0 Remove
- File PopupMenu.java 0 Remove
- File Preferences.java 0 Remove
- File PromptUserConfig.java 0 Remove
- File PymolBindingModel.java 0 Remove
- File PymolViewer.java 0 Remove
- File RotatableCanvas.java 0 Remove
- File SeqPanel.java 0 Remove
- File SequenceFetcher.java 0 Remove
- File StructureChooser.java 0 Remove
- File StructureViewer.java 0 Remove
- File StructureViewerBase.java 0 Remove
- File TreePanel.java 0 Remove
- File UserQuestionnaireCheck.java 0 Remove
- File VamsasApplication.java 0 Remove
- File WsJobParameters.java 0 Remove
- File WsParamSetManager.java 0 Remove
-
Folder
structurechooser
0
-
Folder
io
0
-
Folder
vamsas
0
- File DatastoreItem.java 2 Remove
- File DatastoreRegistry.java 0 Remove
- File Dbref.java 0 Remove
- File Rangetype.java 0 Remove
- File Sequencefeature.java 0 Remove
- File Sequencemapping.java 0 Remove
- File Tree.java 0 Remove
-
Folder
vcf
0
- File VCFLoader.java 0 Remove
- File BackupFilesPresetEntry.java 0 Remove
- File BioJsHTMLOutput.java 0 Remove
- File EMBLLikeFlatFile.java 0 Remove
- File EmblFlatFile.java 0 Remove
- File FileLoader.java 0 Remove
- File FileParse.java 0 Remove
- File FormatAdapter.java 0 Remove
- File HtmlSvgOutput.java 0 Remove
- File ModellerDescription.java 0 Remove
- File StockholmFile.java 0 Remove
- File VamsasAppDatastore.java 0 Remove
-
Folder
vamsas
0
-
Folder
javascript
0
-
Folder
log4j
0
-
Folder
spi
0
- File LoggingEvent.java 0 Remove
- File OptionHandler.java 0 Remove
- File Appender.java 0 Remove
- File ConsoleAppender.java 0 Remove
- File Layout.java 0 Remove
- File Level.java 0 Remove
- File Logger.java 0 Remove
- File Priority.java 0 Remove
- File SimpleLayout.java 0 Remove
- File WriterAppender.java 0 Remove
-
Folder
spi
0
- File MouseOverListener.java 0 Remove
-
Folder
log4j
0
-
Folder
jbgui
0
- File GAlignFrame.java 0 Remove
- File GPreferences.java 0 Remove
- File GWsPreferences.java 0 Remove
-
Folder
log
0
- File JLogger.java 0 Remove
- File JLoggerI.java 0 Remove
- File JLoggerLog4j.java 0 Remove
- File JalviewAppender.java 0 Remove
-
Folder
project
0
- File Jalview2XML.java 2 Remove
-
Folder
structure
0
- File StructureSelectionManager.java 0 Remove
-
Folder
structures/models
0
- File AAStructureBindingModel.java 0 Remove
-
Folder
urls
0
- File UrlLinkTableModel.java 0 Remove
-
Folder
util
0
- File BrowserLauncher.java 0 Remove
- File Log4j.java 0 Remove
- File MapList.java 0 Remove
- File MappingUtils.java 0 Remove
- File MessageManager.java 0 Remove
-
Folder
ws
0
-
Folder
dbsources
0
- File EmblFlatfileSource.java 0 Remove
- File EmblXmlSource.java 0 Remove
- File Xfam.java 0 Remove
-
Folder
jws1
0
- File Discoverer.java 0 Remove
- File JPredClient.java 0 Remove
- File JPredThread.java 0 Remove
- File MsaWSThread.java 0 Remove
- File SeqSearchWSClient.java 0 Remove
- File SeqSearchWSThread.java 0 Remove
-
Folder
jws2
0
- File AADisorderClient.java 0 Remove
- File AbstractJabaCalcWorker.java 0 Remove
- File JabaWsServerQuery.java 0 Remove
- File Jws2Client.java 0 Remove
- File Jws2Discoverer.java 0 Remove
- File MsaWSThread.java 0 Remove
-
Folder
rest
0
- File HttpResultSet.java 0 Remove
- File RestClient.java 0 Remove
- File RestJobThread.java 0 Remove
-
Folder
seqfetcher
0
- File ASequenceFetcher.java 0 Remove
- File AWSThread.java 0 Remove
- File DBRefFetcher.java 0 Remove
-
Folder
dbsources
0
-
Folder
analysis
0
-
Folder
test/jalview
0
-
Folder
bin
0
- File CommandLineOperations.java 0 Remove
-
Folder
util
0
- File Log4jTest.java 0 Remove
- File log4jTestProps.jvprops 0 Remove
-
Folder
bin
0
- File gradle.properties 0 Remove
-
Folder
help/help/html
0
-
Filter
- Only show me content:
- Unfiltered files: dynamically added content
- Filtered files: dynamically added content
- Clear filters
Keyboard shortcuts
Summarize the review outcomes (optional)
#permalink
Details
Warning: no files are visible, they have all been filtered.
Participant | Role | Time Spent | Comments | Latest Comment |
---|---|---|---|---|
Author | 34m | 3 | That looks good. I was almost going to do something simil... | |
Reviewer - 95% reviewed | 24m | 3 (1 defect) | AWESOME JOB !!!! one tiny niggle I had was that Cache.deb... | |
Total | 58m | 6 (1 defect) |
- Linked Issue:
-
#permalink
Objectives
- JAL-3949 An attempt at converting to Log4j 2 – no output achieved!
- JAL-3949 Complete new abstracted logging framework in jalview.log. Updated log calls for this. Removal of jalview.javascript.log4j. Improvements to the Java Console (controllable autoscrolling).
- Merge branch 'develop' into update/JAL-3949_abstracted_logging_for_jalviewjs_and_sanity
Branches in review
Repository | Branch to review | Branched from |
---|
#permalink
General Comments
Ben Soares
That looks good. I was almost going to do something similar (I was thinking j...That looks good. I was almost going to do something similar (I was thinking jalview.log.Log, but jalview.bin.Console is just as good) so happy with this!
/help/help/html/logging.html
Changed
0
(0)
/j11lib/log4j-1.2-api-2.17.1.jar
Deleted
0
(0)
/j11lib/slf4j-log4j12-1.7.32.jar
Deleted
0
(0)
/j8lib/log4j-1.2-api-2.17.1.jar
Deleted
0
(0)
/j8lib/slf4j-log4j12-1.7.32.jar
Deleted
0
(0)
/src/jalview/analysis/AlignmentUtils.java
Changed
0
(0)
/src/jalview/analysis/GeneticCodes.java
Changed
0
(0)
/src/jalview/analysis/PCA.java
Changed
0
(0)
/src/jalview/analysis/TreeModel.java
Changed
0
(0)
/src/jalview/bin/Cache.java
Changed
0
(0)
/src/jalview/bin/Jalview.java
Changed
0
(0)
/src/jalview/.../ensembl/EnsemblLookup.java
Changed
0
(0)
/src/jalview/.../ensembl/EnsemblSeqProxy.java
Changed
0
(0)
/src/jalview/ext/htsjdk/VCFReader.java
Changed
0
(0)
/src/jalview/.../jmol/JalviewJmolBinding.java
Changed
0
(0)
/src/jalview/ext/pymol/PymolManager.java
Changed
0
(0)
/src/.../chimera/JalviewChimeraBinding.java
Changed
0
(0)
/src/jalview/ext/so/SequenceOntology.java
Changed
0
(0)
/src/jalview/fts/core/GFTSPanel.java
Changed
0
(0)
/src/.../alphafold/AlphafoldRestClient.java
Changed
0
(0)
/src/.../threedbeacons/TDBeaconsFTSPanel.java
Changed
0
(0)
/src/.../structurechooser/ThreeDBStructureChooserQuerySource.java
Changed
0
(0)
/src/jalview/gui/APQHandlers.java
Changed
0
(0)
/src/jalview/gui/AlignFrame.java
Changed
0
(0)
/src/jalview/gui/AlignViewport.java
Changed
0
(0)
/src/jalview/gui/AlignmentPanel.java
Changed
0
(0)
/src/jalview/gui/AppJmol.java
Changed
0
(0)
/src/jalview/gui/AppJmolBinding.java
Changed
0
(0)
/src/jalview/gui/BlogReader.java
Changed
0
(0)
/src/jalview/gui/ChimeraViewFrame.java
Changed
0
(0)
/src/jalview/gui/Console.java
Changed
0
(0)
/src/jalview/gui/CrossRefAction.java
Changed
0
(0)
/src/.../gui/CutAndPasteHtmlTransfer.java
Changed
0
(0)
/src/jalview/gui/CutAndPasteTransfer.java
Changed
0
(0)
/src/jalview/gui/Desktop.java
Changed
0
(0)
/src/jalview/gui/FeatureTypeSettings.java
Changed
0
(0)
/src/jalview/gui/JalviewAppender.java
Deleted
0
(0)
/src/jalview/gui/OOMWarning.java
Changed
0
(0)
/src/jalview/gui/PCAPanel.java
Changed
0
(0)
/src/jalview/gui/PopupMenu.java
Changed
0
(0)
/src/jalview/gui/Preferences.java
Changed
0
(0)
/src/jalview/gui/PromptUserConfig.java
Changed
0
(0)
/src/jalview/gui/PymolBindingModel.java
Changed
0
(0)
/src/jalview/gui/PymolViewer.java
Changed
0
(0)
/src/jalview/gui/RotatableCanvas.java
Changed
0
(0)
/src/jalview/gui/SeqPanel.java
Changed
0
(0)
/src/jalview/gui/SequenceFetcher.java
Changed
0
(0)
/src/jalview/gui/StructureChooser.java
Changed
0
(0)
/src/jalview/gui/StructureViewer.java
Changed
0
(0)
/src/jalview/gui/StructureViewerBase.java
Changed
0
(0)
/src/jalview/gui/TreePanel.java
Changed
0
(0)
/src/.../gui/UserQuestionnaireCheck.java
Changed
0
(0)
/src/jalview/gui/VamsasApplication.java
Changed
0
(0)
/src/jalview/gui/WsJobParameters.java
Changed
0
(0)
/src/jalview/gui/WsParamSetManager.java
Changed
0
(0)
/src/jalview/io/vamsas/DatastoreItem.java
Changed
2
(0)
/src/jalview/.../vamsas/DatastoreRegistry.java
Changed
0
(0)
/src/jalview/io/vamsas/Dbref.java
Changed
0
(0)
/src/jalview/io/vamsas/Rangetype.java
Changed
0
(0)
/src/jalview/.../vamsas/Sequencefeature.java
Changed
0
(0)
/src/jalview/.../vamsas/Sequencemapping.java
Changed
0
(0)
/src/jalview/io/vamsas/Tree.java
Changed
0
(0)
/src/jalview/io/vcf/VCFLoader.java
Changed
0
(0)
/src/.../io/BackupFilesPresetEntry.java
Changed
0
(0)
/src/jalview/io/BioJsHTMLOutput.java
Changed
0
(0)
/src/jalview/io/EMBLLikeFlatFile.java
Changed
0
(0)
/src/jalview/io/EmblFlatFile.java
Changed
0
(0)
/src/jalview/io/FileLoader.java
Changed
0
(0)
/src/jalview/io/FileParse.java
Changed
0
(0)
/src/jalview/io/FormatAdapter.java
Changed
0
(0)
/src/jalview/io/HtmlSvgOutput.java
Changed
0
(0)
/src/jalview/io/ModellerDescription.java
Changed
0
(0)
/src/jalview/io/StockholmFile.java
Changed
0
(0)
/src/jalview/io/VamsasAppDatastore.java
Changed
0
(0)
/src/jalview/.../log4j/spi/LoggingEvent.java
Deleted
0
(0)
/src/jalview/.../log4j/spi/OptionHandler.java
Deleted
0
(0)
/src/jalview/.../log4j/Appender.java
Deleted
0
(0)
AWESOME JOB !!!! one tiny niggle I had was that Cache.debug/Cache.error doesn't read nicely, so I've abstracted the logging stuff even farther to a new jalview.bin.Console class: see https://source.jalview.org/crucible/changelog/~br=update%402fJAL-3949_jalview_bin_Console_to_cure_sanity_even_more/jalview/