JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src

Activity

CR-JAL-262 1

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 0m    
    Reviewer - Complete 11m 1 Looks good. I've bumped the version to 1.8.3-1.2.12 and r...
    Total   11m 1  
    #permalink

    Objectives

    II noticed that the getdown launcher included unsafe to(upper/lower) calls - could you quickly check over these ? I'm also not clear on how the getdown versioning works - presumably this needs a version bump ?

    • JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
    • JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 getdown - needs rebuild / redacting
    • JAL-3691 rebuilt getdown jars

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Ben Soares

    Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

    Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

    /getdown/lib/FJVL_VERSION Changed
    Open in IDE #permalink
    /getdown/lib/JVL_VERSION Changed
    Open in IDE #permalink
    /getdown/lib/getdown-core.jar Changed
    Open in IDE #permalink
    /getdown/lib/getdown-launcher-local.jar Changed
    Open in IDE #permalink
    /getdown/lib/getdown-launcher.jar Changed
    Open in IDE #permalink
    /getdown/src/getdown/ant/pom.xml Changed
    Open in IDE #permalink
    /getdown/src/.../getdown/data/Application.java Changed
    Open in IDE #permalink
    /getdown/src/.../getdown/data/EnvConfig.java Changed
    Open in IDE #permalink
    /getdown/src/.../getdown/util/LaunchUtil.java Changed
    Open in IDE #permalink
    /getdown/src/.../jalview/bin/HiDPISetting.java Changed
    Open in IDE #permalink
    /getdown/src/.../bin/MemorySetting.java Changed
    Open in IDE #permalink
    /getdown/src/.../jalview/util/StringUtils.java Changed
    Open in IDE #permalink
    /getdown/src/getdown/core/pom.xml Changed
    Open in IDE #permalink
    /getdown/src/getdown/launcher/pom.xml Changed
    Open in IDE #permalink
    /getdown/src/getdown/mvn_cmd Changed
    Open in IDE #permalink
    /getdown/src/getdown/pom.xml Changed
    Open in IDE #permalink
    /j11lib/getdown-core.jar Changed
    Open in IDE #permalink
    /j8lib/getdown-core.jar Changed
    Open in IDE #permalink
    /src/ext/edu/.../rbvi/strucviz2/ChimUtils.java Changed
    Open in IDE #permalink
    /src/ext/.../strucviz2/StructureManager.java Changed
    Open in IDE #permalink
    /src/jalview/bin/MemorySetting.java Changed
    Open in IDE #permalink
    /src/jalview/util/StringUtils.java Changed
    Open in IDE #permalink
    /src/mc_view/PDBChain.java Changed
    Open in IDE #permalink
    /src/org/json/simple/JSONValue.java Changed
    Open in IDE #permalink
    /src/org/.../file/WindowsShortcut.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against