CR-JAL-262 1
- Details
- Objectives
- General Comments 1
- Unresolved
- Resolved
- Number of files included: 25
-
jalview
0
-
Folder
getdown
0
-
Folder
lib
0
- File FJVL_VERSION 0 Remove
- File JVL_VERSION 0 Remove
- File getdown-core.jar 0 Remove
- File getdown-launcher-local.jar 0 Remove
- File getdown-launcher.jar 0 Remove
-
Folder
src/getdown
0
-
Folder
ant
0
- File pom.xml 0 Remove
-
Folder
core
0
-
Folder
src/main/java
0
-
Folder
com/threerings/getdown
0
-
Folder
data
0
- File Application.java 0 Remove
- File EnvConfig.java 0 Remove
-
Folder
util
0
- File LaunchUtil.java 0 Remove
-
Folder
data
0
-
Folder
jalview
0
-
Folder
bin
0
- File HiDPISetting.java 0 Remove
- File MemorySetting.java 0 Remove
-
Folder
util
0
- File StringUtils.java 0 Remove
-
Folder
bin
0
-
Folder
com/threerings/getdown
0
- File pom.xml 0 Remove
-
Folder
src/main/java
0
-
Folder
launcher
0
- File pom.xml 0 Remove
- File mvn_cmd 0 Remove
- File pom.xml 0 Remove
-
Folder
ant
0
-
Folder
lib
0
-
Folder
j11lib
0
- File getdown-core.jar 0 Remove
-
Folder
j8lib
0
- File getdown-core.jar 0 Remove
-
Folder
src
0
-
Folder
ext/edu/ucsf/rbvi/strucviz2
0
- File ChimUtils.java 0 Remove
- File StructureManager.java 0 Remove
-
Folder
jalview
0
-
Folder
bin
0
- File MemorySetting.java 0 Remove
-
Folder
util
0
- File StringUtils.java 0 Remove
-
Folder
bin
0
-
Folder
mc_view
0
- File PDBChain.java 0 Remove
-
Folder
org
0
-
Folder
json/simple
0
- File JSONValue.java 0 Remove
-
Folder
stackoverflowusers/file
0
- File WindowsShortcut.java 0 Remove
-
Folder
json/simple
0
-
Folder
ext/edu/ucsf/rbvi/strucviz2
0
-
Folder
getdown
0
-
Filter
- Only show me content:
- Unfiltered files: dynamically added content
- Filtered files: dynamically added content
- Clear filters
Keyboard shortcuts
Summarize the review outcomes (optional)
#permalink
Details
Warning: no files are visible, they have all been filtered.
Participant | Role | Time Spent | Comments | Latest Comment |
---|---|---|---|---|
Author | 0m | |||
Reviewer - Complete | 11m | 1 | Looks good. I've bumped the version to 1.8.3-1.2.12 and r... | |
Total | 11m | 1 |
- Linked Issue:
-
#permalink
Objectives
II noticed that the getdown launcher included unsafe to(upper/lower) calls - could you quickly check over these ? I'm also not clear on how the getdown versioning works - presumably this needs a version bump ?
Branches in review
Repository | Branch to review | Branched from |
---|
/getdown/lib/FJVL_VERSION
Changed
0
(0)
/getdown/lib/JVL_VERSION
Changed
0
(0)
/getdown/lib/getdown-core.jar
Changed
0
(0)
/getdown/lib/getdown-launcher-local.jar
Changed
0
(0)
/getdown/lib/getdown-launcher.jar
Changed
0
(0)
/getdown/src/getdown/ant/pom.xml
Changed
0
(0)
/getdown/src/.../getdown/data/Application.java
Changed
0
(0)
/getdown/src/.../getdown/data/EnvConfig.java
Changed
0
(0)
/getdown/src/.../getdown/util/LaunchUtil.java
Changed
0
(0)
/getdown/src/.../jalview/bin/HiDPISetting.java
Changed
0
(0)
/getdown/src/.../bin/MemorySetting.java
Changed
0
(0)
/getdown/src/.../jalview/util/StringUtils.java
Changed
0
(0)
/getdown/src/getdown/core/pom.xml
Changed
0
(0)
/getdown/src/getdown/launcher/pom.xml
Changed
0
(0)
/getdown/src/getdown/mvn_cmd
Changed
0
(0)
/getdown/src/getdown/pom.xml
Changed
0
(0)
/j11lib/getdown-core.jar
Changed
0
(0)
/j8lib/getdown-core.jar
Changed
0
(0)
/src/ext/edu/.../rbvi/strucviz2/ChimUtils.java
Changed
0
(0)
/src/ext/.../strucviz2/StructureManager.java
Changed
0
(0)
/src/jalview/bin/MemorySetting.java
Changed
0
(0)
/src/jalview/util/StringUtils.java
Changed
0
(0)
/src/mc_view/PDBChain.java
Changed
0
(0)
/src/org/json/simple/JSONValue.java
Changed
0
(0)
/src/org/.../file/WindowsShortcut.java
Changed
0
(0)
Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.