CR-JAL-262 JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src

open for 4 months

Author

Reviewers

JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 25

jalview 0
- Folder getdown 0
  - Folder lib 0
    - File FJVL_VERSION 0 Remove
    - File JVL_VERSION 0 Remove
    - File getdown-core.jar 0 Remove
    - File getdown-launcher-local.jar 0 Remove
    - File getdown-launcher.jar 0 Remove
  - Folder src/getdown 0
    - Folder ant 0
      - File pom.xml 0 Remove
    - Folder core 0
      - Folder src/main/java 0
        
        Folder com/threerings/getdown 0
        
        Folder data 0
        
        File Application.java 0 Remove
        
        File EnvConfig.java 0 Remove
        
        Folder util 0
        
        File LaunchUtil.java 0 Remove
        
        Folder jalview 0
        
        Folder bin 0
        
        File HiDPISetting.java 0 Remove
        
        File MemorySetting.java 0 Remove
        
        Folder util 0
        
        File StringUtils.java 0 Remove
      - File pom.xml 0 Remove
    - Folder launcher 0
      - File pom.xml 0 Remove
    - File mvn_cmd 0 Remove
    - File pom.xml 0 Remove
- Folder j11lib 0
  - File getdown-core.jar 0 Remove
- Folder j8lib 0
  - File getdown-core.jar 0 Remove
- Folder src 0
  - Folder ext/edu/ucsf/rbvi/strucviz2 0
    - File ChimUtils.java 0 Remove
    - File StructureManager.java 0 Remove
  - Folder jalview 0
    - Folder bin 0
      - File MemorySetting.java 0 Remove
    - Folder util 0
      - File StringUtils.java 0 Remove
  - Folder mc_view 0
    - File PDBChain.java 0 Remove
  - Folder org 0
    - Folder json/simple 0
      - File JSONValue.java 0 Remove
    - Folder stackoverflowusers/file 0
      - File WindowsShortcut.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jim Procter	Author	0m
Ben Soares	Reviewer - Complete	11m	1	Looks good. I've bumped the version to 1.8.3-1.2.12 and r...
Total		11m	1

Linked Issue:
JAL-3691

#permalink

Objectives

II noticed that the getdown launcher included unsafe to(upper/lower) calls - could you quickly check over these ? I'm also not clear on how the getdown versioning works - presumably this needs a version bump ?

JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src
JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 getdown - needs rebuild / redacting
JAL-3691 rebuilt getdown jars

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Ben Soares

Looks good. I've bumped the version to 1.8.3-1.2.12 and recompiled jars.

02 Mar

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-262

JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src

CR-JAL-262 1

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Ben Soares

Log time against

JAL-3691 patch toUpper/toLower to use Locale.ROOT for 2.11.2 src

CR-JAL-262 1

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Ben Soares

Log time against